Tags

None

Referenced Files

	F5359376: D14473.id47549.diff
	Wed, Apr 9, 12:02 PM

	F5356445: D14473.id47549.diff
	Wed, Apr 9, 11:31 AM

	F5356014: D14473.diff
	Wed, Apr 9, 11:26 AM

	Unknown Object (File)
	Sat, Apr 5, 3:48 PM

	Unknown Object (File)
	Sat, Apr 5, 11:42 AM

	Unknown Object (File)
	Sat, Apr 5, 9:30 AM

	Unknown Object (File)
	Fri, Apr 4, 10:11 PM

	Unknown Object (File)
	Thu, Apr 3, 1:56 PM

View All 26 Files

Subscribers

ashoat

tomek

Details

Reviewers

bartek

Commits

rCOMMa6bdf5a306c7: [ios] Implement hasMultipleFrames() function on iOS

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14472

Test Plan

Try to send a gif with animation and without animation and verify that the function returns correct result.
Set mediaType to 'photo_or_video' for gifs in order to trigger the check.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:39 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:39 AM

angelika added a child revision: D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg.Thu, Mar 20, 4:40 AM

Harbormaster failed remote builds in B33780: Diff 47484!Thu, Mar 20, 4:59 AM

Harbormaster completed remote builds in B33780: Diff 47484.Thu, Mar 20, 5:33 AM

angelika published this revision for review.Thu, Mar 20, 5:56 AM

bartek accepted this revision.Fri, Mar 21, 1:52 AM

This revision is now accepted and ready to land.Fri, Mar 21, 1:52 AM

Rebase

Harbormaster completed remote builds in B33831: Diff 47549.Tue, Mar 25, 10:23 PM

Closed by commit rCOMMa6bdf5a306c7: [ios] Implement hasMultipleFrames() function on iOS (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMa6bdf5a306c7: [ios] Implement hasMultipleFrames() function on iOS.

[ios] Implement hasMultipleFrames() function on iOS
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 47484

native/expo-modules/comm-expo-package/ios/MediaModule.swift

[ios] Implement hasMultipleFrames() function on iOSClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47484

native/expo-modules/comm-expo-package/ios/MediaModule.swift

[ios] Implement hasMultipleFrames() function on iOS
ClosedPublic
Actions

Revision Contents
Changeset List