Page MenuHomePhabricator
Differential D14476

[ios] Implement generateThumbnail() function on iOS
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 3:56 PM
Unknown Object (File)
Fri, Mar 28, 12:57 PM
Unknown Object (File)
Thu, Mar 27, 10:18 PM
Unknown Object (File)
Wed, Mar 26, 11:05 AM
Unknown Object (File)
Wed, Mar 26, 9:44 AM
Unknown Object (File)
Tue, Mar 25, 10:29 PM
Unknown Object (File)
Tue, Mar 25, 10:27 PM
Unknown Object (File)
Tue, Mar 25, 10:12 PM
View All 11 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMfb17f097913d: [ios] Implement generateThumbnail() function on iOS
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Copied and simplified from expo-module-thumbnails. I don't think it's worth to have a dependency for a few lines of code while we have already related code here. JPEG quality wasn't specified in the original implementation, but I had to put something so I've put 0.9.

Depends on D14475

Test Plan

Send a video and verify thumbnail is generated

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
ios/
35 lines

Diff 47487

View Options

native/expo-modules/comm-expo-package/ios/MediaModule.swift

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
} from '../types/message-types.js'; } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRawThreadInfo, MinimallyEncodedRawThreadInfo,
MinimallyEncodedThreadCurrentUserInfo, MinimallyEncodedThreadCurrentUserInfo,
MinimallyEncodedThreadInfo, MinimallyEncodedThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import { import {
decodeMinimallyEncodedRoleInfo, decodeMinimallyEncodedRoleInfo,
minimallyEncodeRawThreadInfo,
minimallyEncodeThreadInfo, minimallyEncodeThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { import {
threadPermissionPropagationPrefixes, threadPermissionPropagationPrefixes,
threadPermissions, threadPermissions,
configurableCommunityPermissions, configurableCommunityPermissions,
type ThreadPermission, type ThreadPermission,
▲ Show 20 Lines • Show All 655 Lines • ▼ Show 20 Linesasync function createRealThreadFromPendingThread({
return newThreadID; return newThreadID;
} }
type RawThreadInfoOptions = { type RawThreadInfoOptions = {
+filterThreadEditAvatarPermission?: boolean, +filterThreadEditAvatarPermission?: boolean,
+excludePinInfo?: boolean, +excludePinInfo?: boolean,
+filterManageInviteLinksPermission?: boolean, +filterManageInviteLinksPermission?: boolean,
+filterVoicedInAnnouncementChannelsPermission?: boolean, +filterVoicedInAnnouncementChannelsPermission?: boolean,
+minimallyEncodePermissions?: boolean,
}; };
function rawThreadInfoFromServerThreadInfo( function rawThreadInfoFromServerThreadInfo(
serverThreadInfo: ServerThreadInfo, serverThreadInfo: ServerThreadInfo,
viewerID: string, viewerID: string,
options?: RawThreadInfoOptions, options?: RawThreadInfoOptions,
): ?LegacyRawThreadInfo { ): ?RawThreadInfo {
const filterThreadEditAvatarPermission = const filterThreadEditAvatarPermission =
options?.filterThreadEditAvatarPermission; options?.filterThreadEditAvatarPermission;
const excludePinInfo = options?.excludePinInfo; const excludePinInfo = options?.excludePinInfo;
const filterManageInviteLinksPermission = const filterManageInviteLinksPermission =
options?.filterManageInviteLinksPermission; options?.filterManageInviteLinksPermission;
const filterVoicedInAnnouncementChannelsPermission = const filterVoicedInAnnouncementChannelsPermission =
options?.filterVoicedInAnnouncementChannelsPermission; options?.filterVoicedInAnnouncementChannelsPermission;
const shouldMinimallyEncodePermissions = options?.minimallyEncodePermissions;
const filterThreadPermissions = _omitBy( const filterThreadPermissions = _omitBy(
(v, k) => (v, k) =>
(filterThreadEditAvatarPermission && (filterThreadEditAvatarPermission &&
[ [
threadPermissions.EDIT_THREAD_AVATAR, threadPermissions.EDIT_THREAD_AVATAR,
threadPermissionPropagationPrefixes.DESCENDANT + threadPermissionPropagationPrefixes.DESCENDANT +
threadPermissions.EDIT_THREAD_AVATAR, threadPermissions.EDIT_THREAD_AVATAR,
▲ Show 20 Lines • Show All 88 Lines • ▼ Show 20 Lines): ?RawThreadInfo {
const sourceMessageID = serverThreadInfo.sourceMessageID; const sourceMessageID = serverThreadInfo.sourceMessageID;
if (sourceMessageID) { if (sourceMessageID) {
rawThreadInfo = { ...rawThreadInfo, sourceMessageID }; rawThreadInfo = { ...rawThreadInfo, sourceMessageID };
} }
if (serverThreadInfo.avatar) { if (serverThreadInfo.avatar) {
rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar }; rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar };
} }
if (!excludePinInfo) { if (!excludePinInfo) {
return { rawThreadInfo = {
...rawThreadInfo, ...rawThreadInfo,
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return rawThreadInfo; return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo;
} }
function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity { function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; let threadMembers: $ReadOnlyArray<RelativeMemberInfo>;
▲ Show 20 Lines • Show All 1,000 Lines • Show Last 20 Lines