Paths

Table of Contentst

-
native/expo-modules/comm-expo-package/ios/
-
expo-modules/
-
comm-expo-package/
-
ios/
-
MediaModule.swift

Differential D14479

[ios] Implement transcodeVideo() function on iOS
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:46 AM.

Details

Reviewers

bartek

Commits

rCOMMf0d2a66750c1: [ios] Implement transcodeVideo() function on iOS

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Changes:

on the native side we check progress every 200ms and send an event to the js side. The JS side then calls the callback with the progress
we can specify the profile and bitrate, we can't specify fps though
width and height is mandatory to keep it simple (ios requires it)
I'm returning some basic stats (speed, size and duration) but some are missing compared to ffmpeg implementation because I don't see much sense in collecting them. However I can add them if necessary (should be easy on Android, more complicated on iOS)

I'm using AVWriter instead of AVAssetExportSession. Using AVWriter is more complicated and messy but allows for more options.

Depends on D14478

Test Plan

Send some videos on some devices and verify they're transcoded correctly

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:46 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:46 AM

angelika added a child revision: D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.Thu, Mar 20, 4:47 AM

Harbormaster completed remote builds in B33786: Diff 47490.Thu, Mar 20, 5:15 AM

angelika edited the summary of this revision. (Show Details)Thu, Mar 20, 5:26 AM

angelika edited the summary of this revision. (Show Details)

angelika added inline comments.Thu, Mar 20, 5:31 AM

native/expo-modules/comm-expo-package/ios/MediaModule.swift
193	This is `-movflags +faststart` from ffmpeg

angelika published this revision for review.Thu, Mar 20, 5:57 AM

Nice work!

This revision is now accepted and ready to land.Fri, Mar 21, 8:52 AM

Rebase & fix

Harbormaster completed remote builds in B33837: Diff 47555.Tue, Mar 25, 10:43 PM

Fix rotation issue on android video

Harbormaster failed remote builds in B33857: Diff 47590!Thu, Mar 27, 7:37 AM

Harbormaster completed remote builds in B33857: Diff 47590.Thu, Mar 27, 9:07 AM

Closed by commit rCOMMf0d2a66750c1: [ios] Implement transcodeVideo() function on iOS (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMf0d2a66750c1: [ios] Implement transcodeVideo() function on iOS.

Revision Contents
Changeset List

Path

Size

native/

expo-modules/

comm-expo-package/

ios/

MediaModule.swift

223 lines

Diff 47490

View Options

native/expo-modules/comm-expo-package/ios/MediaModule.swift

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines	const changeThreadSettingsAction = React.useCallback(async () => {
try {		try {
setErrorMessage('');		setErrorMessage('');
return await callChangeThreadSettings({		return await callChangeThreadSettings({
threadID: threadInfo.id,		threadID: threadInfo.id,
changes: queuedChanges,		changes: queuedChanges,
});		});
} catch (e) {		} catch (e) {
setErrorMessage('unknown_error');		setErrorMessage('unknown_error');
setQueuedChanges(Object.freeze({}));
throw e;		throw e;
		} finally {
		setQueuedChanges(Object.freeze({}));
}		}
}, [		}, [
callChangeThreadSettings,		callChangeThreadSettings,
queuedChanges,		queuedChanges,
setErrorMessage,		setErrorMessage,
setQueuedChanges,		setQueuedChanges,
threadInfo.id,		threadInfo.id,
]);		]);
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines

[ios] Implement transcodeVideo() function on iOSClosedPublicActions