Page MenuHomePhabricator
Differential D14473

[ios] Implement hasMultipleFrames() function on iOS
ClosedPublic
Actions

Authored by angelika on Mar 20 2025, 4:39 AM.
Tags
None
Referenced Files
F6235082: D14473.id47484.diff
Thu, Apr 24, 2:03 PM
Unknown Object (File)
Thu, Apr 24, 12:15 PM
Unknown Object (File)
Wed, Apr 23, 3:20 AM
Unknown Object (File)
Thu, Apr 10, 7:27 AM
Unknown Object (File)
Thu, Apr 10, 4:06 AM
Unknown Object (File)
Wed, Apr 9, 12:02 PM
Unknown Object (File)
Wed, Apr 9, 11:31 AM
Unknown Object (File)
Wed, Apr 9, 11:26 AM
View All 31 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMa6bdf5a306c7: [ios] Implement hasMultipleFrames() function on iOS
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14472

Test Plan

Try to send a gif with animation and without animation and verify that the function returns correct result.
Set mediaType to 'photo_or_video' for gifs in order to trigger the check.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
ios/
17 lines

Diff 47549

View Options

native/expo-modules/comm-expo-package/ios/MediaModule.swift

  • This file was added.
// @flow
const ENCRYPTION_ALGORITHM = 'AES-GCM';
type EncryptionResult = {
bartekUnsubmitted
Not Done
Inline Actions

What about calling it EncryptedData? See my comment in decryptDatabaseFile

bartek: What about calling it `EncryptedData`? See my comment in `decryptDatabaseFile`
+iv: BufferSource,
+cipher: ArrayBuffer,
bartekUnsubmitted
Not Done
Inline Actions

I'd call it ciphertext to be consistent, but up to you

bartek: I'd call it `ciphertext` to be consistent, but up to you
};
function generateDatabaseCryptoKey(): Promise<CryptoKey> {
return crypto.subtle.generateKey(
{
name: ENCRYPTION_ALGORITHM,
length: 256,
},
false,
['encrypt', 'decrypt'],
);
}
function generateIv(): BufferSource {
bartekUnsubmitted
Not Done
Inline Actions
);
}
- function generateIv(): BufferSource {
+ function generateIV(): BufferSource {
return crypto.getRandomValues(new Uint8Array(12));

Nit

bartek: Nit
return crypto.getRandomValues(new Uint8Array(12));
}
async function encryptDatabaseFile(
data: ArrayBuffer,
key: CryptoKey,
): Promise<EncryptionResult> {
const iv = generateIv();
const cipher = await crypto.subtle.encrypt(
{
name: ENCRYPTION_ALGORITHM,
iv: iv,
},
key,
data,
);
return {
cipher,
iv,
};
}
async function decryptDatabaseFile(
cipher: ArrayBuffer,
key: CryptoKey,
iv: BufferSource,
bartekUnsubmitted
Not Done
Inline Actions
async function decryptDatabaseFile(
- cipher: ArrayBuffer,
+ { ciphertext, iv }: EncryptionResult,
key: CryptoKey,
- iv: BufferSource,
): Promise<ArrayBuffer> {

How about connecting cipher and iv by using the EncryptionResult type you defined above (and perhaps renaming the type)? In GCM mode, they always need to be provided together anyways

bartek: How about connecting `cipher` and `iv` by using the `EncryptionResult` type you defined above…
): Promise<ArrayBuffer> {
return crypto.subtle.decrypt(
{
name: ENCRYPTION_ALGORITHM,
iv,
},
key,
cipher,
);
}
export { generateDatabaseCryptoKey, encryptDatabaseFile, decryptDatabaseFile };