Page MenuHomePhabricator
Differential D14474

[native] Use hasMultipleFrames() from MediaModule instead of ffmpeg
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:40 AM.
Tags
None
Referenced Files
F5373461: D14474.id47550.diff
Wed, Apr 9, 4:07 PM
F5340934: D14474.id47600.diff
Wed, Apr 9, 2:59 AM
F5340434: D14474.diff
Wed, Apr 9, 2:53 AM
Unknown Object (File)
Sun, Apr 6, 2:54 PM
Unknown Object (File)
Sun, Apr 6, 4:26 AM
Unknown Object (File)
Thu, Apr 3, 1:40 PM
Unknown Object (File)
Wed, Apr 2, 10:48 AM
Unknown Object (File)
Mon, Mar 31, 11:43 AM
View All 25 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMa21fb87bf067: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14473

Test Plan

Try to send a gif with animation and without animation and verify that the function returns correct result.
Set mediaType to 'photo_or_video' for gifs in order to trigger the check.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
media/
18 lines
native/
media/
20 lines
utils/
5 lines

Diff 47550

View Options

lib/media/video-utils.js

Loading...
View Options

native/media/ffmpeg.js

Loading...
View Options

native/utils/media-module.js

Loading...