Differential D14476

[ios] Implement generateThumbnail() function on iOS
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:42 AM.

Tags

None

Referenced Files

	F5250933: D14476.id47552.diff
	Sun, Apr 6, 3:48 AM

	Unknown Object (File)
	Sat, Apr 5, 12:41 PM

	Unknown Object (File)
	Sat, Apr 5, 10:16 AM

	Unknown Object (File)
	Thu, Apr 3, 9:37 PM

	Unknown Object (File)
	Thu, Apr 3, 12:10 PM

	Unknown Object (File)
	Thu, Apr 3, 8:47 AM

	Unknown Object (File)
	Wed, Apr 2, 6:31 PM

	Unknown Object (File)
	Wed, Apr 2, 4:32 AM

View All 26 Files

Subscribers

Details

Reviewers

Commits

rCOMMfb17f097913d: [ios] Implement generateThumbnail() function on iOS

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Copied and simplified from expo-module-thumbnails. I don't think it's worth to have a dependency for a few lines of code while we have already related code here. JPEG quality wasn't specified in the original implementation, but I had to put something so I've put 0.9.

Depends on D14475

Test Plan

Send a video and verify thumbnail is generated

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:42 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:42 AM

angelika added a child revision: D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.Thu, Mar 20, 4:43 AM

Harbormaster completed remote builds in B33783: Diff 47487.Thu, Mar 20, 5:08 AM

angelika edited the summary of this revision. (Show Details)Thu, Mar 20, 5:10 AM

angelika published this revision for review.Thu, Mar 20, 5:56 AM

bartek accepted this revision.Fri, Mar 21, 1:57 AM

This revision is now accepted and ready to land.Fri, Mar 21, 1:57 AM

Rebase

Harbormaster completed remote builds in B33834: Diff 47552.Tue, Mar 25, 10:32 PM

Closed by commit rCOMMfb17f097913d: [ios] Implement generateThumbnail() function on iOS (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMfb17f097913d: [ios] Implement generateThumbnail() function on iOS.

Revision Contents
Changeset List

Path

Size

native/

expo-modules/

comm-expo-package/

ios/

MediaModule.swift

35 lines

Diff 47552

native/expo-modules/comm-expo-package/ios/MediaModule.swift

Loading...