Details

We shouldn't do that - these fields are empty because they were deprecated. By changing their types to strings, we're reintroducing them. It would be better to check if we're ready for removing them completely.

This revision now requires changes to proceed.Jul 31 2025, 2:28 PM

Rebase & review changes

Harbormaster completed remote builds in B35180: Diff 49431.Aug 9 2025, 12:29 PM

angelika planned changes to this revision.Aug 9 2025, 1:55 PM

Remove properties

In D15069#416249, @tomek wrote:

We shouldn't do that - these fields are empty because they were deprecated. By changing their types to strings, we're reintroducing them. It would be better to check if we're ready for removing them completely.

After removing them completely:

there were no new flow errors
I looked into git history and the commits that added empty properties were about 2 years old

angelika retitled this revision from [Flow262][skip-ci] Replace empty with string in request types to [Flow262][skip-ci] Remove empty types in request types.Aug 11 2025, 12:46 PM

Harbormaster completed remote builds in B35251: Diff 49508.Aug 11 2025, 12:46 PM

In D15069#417543, @angelika wrote:

In D15069#416249, @tomek wrote:

We shouldn't do that - these fields are empty because they were deprecated. By changing their types to strings, we're reintroducing them. It would be better to check if we're ready for removing them completely.

After removing them completely:

there were no new flow errors

I looked into git history and the commits that added empty properties were about 2 years old

If that's right, we can safely remove them. The last native version supported https://github.com/CommE2E/comm/blob/21d612af49dc2cccfd2a208527f4e682136920d3/keyserver/src/session/version.js#L13 is from 8 months ago https://github.com/CommE2E/comm/tree/mobile-v1.0.446.

This revision is now accepted and ready to land.Aug 11 2025, 3:16 PM

Rebase & review changes

Harbormaster completed remote builds in B35446: Diff 49735.Aug 21 2025, 12:52 PM

Closed by commit rCOMMa277038ac91f: [Flow262][skip-ci] Remove empty types in request types. · Explain WhyAug 21 2025, 7:33 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMa277038ac91f: [Flow262][skip-ci] Remove empty types in request types.

[Flow262][skip-ci] Remove empty types in request types
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 48929

lib/types/account-types.js

lib/types/entry-types.js

lib/types/thread-types.js

lib/types/user-types.js

[Flow262][skip-ci] Remove empty types in request typesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48929

lib/types/account-types.js

lib/types/entry-types.js

lib/types/thread-types.js

lib/types/user-types.js

[Flow262][skip-ci] Remove empty types in request types
ClosedPublic
Actions

Revision Contents
Changeset List