Details

Reviewers

tomek
ashoat

Commits

rCOMM17bce0978506: [Flow262][skip-ci] Fix colors.js errors

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

type Colors = $Exact<typeof light>; now resolves to an object with literals like:

 {
  blockQuoteBackground: '#...',
...

So we can't use it to type dark theme object.
Also there are not only strings but also numbers in the Colors type.
So sadly I had to create the Colors type manually.

Depends on D15018

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 22 2025, 1:53 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 22 2025, 1:53 AM

angelika added a child revision: D15020: [Flow262][skip-ci] Migrate React$Node -> React.Node.Jul 22 2025, 1:55 AM

Harbormaster completed remote builds in B34670: Diff 48869.Jul 22 2025, 1:57 AM

Squash other commit

Harbormaster completed remote builds in B34711: Diff 48915.Jul 23 2025, 4:46 AM

Rebase

Harbormaster completed remote builds in B34866: Diff 49073.Jul 24 2025, 4:23 PM

angelika published this revision for review.Jul 25 2025, 9:28 AM

angelika added a reviewer: tomek.

tomek accepted this revision.Jul 30 2025, 4:20 PM

tomek added inline comments.

native/themes/colors.js
257–259	Were these colors missing? Do we know if they look ok?

This revision is now accepted and ready to land.Jul 30 2025, 4:20 PM

ashoat added inline comments.Jul 30 2025, 8:31 PM

native/themes/colors.js
257–259	Strange that these were missing! Would be good to know where they are used, and a screenshot of before / after if applicable

ashoat requested changes to this revision.Jul 30 2025, 8:33 PM

ashoat added inline comments.

native/themes/colors.js
398	Why are we using `any` instead of `mixed` here? Can we do something smarter using the types in `native/types/styles.js`?
406	Why the change here?

This revision now requires changes to proceed.Jul 30 2025, 8:33 PM

Rebase & review changes

Harbormaster completed remote builds in B35133: Diff 49384.Aug 9 2025, 12:21 PM

angelika added inline comments.Aug 9 2025, 1:51 PM

native/themes/colors.js

416 ↗

(On Diff #49384)

Added ignore here because styleValue is a string and themeColors has literals as keys. And I can't see how could styleValue be a literal.

425 ↗

(On Diff #49384)

The changes above were due to an issue with StyleSheet.create here. Maybe it's better to just ignore the error here.
The error is for example this:

Cannot call StyleSheet.create because in property aspectRatio of the indexer property of type argument S:
[incompatible-call]
 • Either mixed [1] is incompatible with number [2].
 • Or mixed [1] is incompatible with string [3].

        themes/colors.js
    [1] 399│ type Styles = { [name: string]: { +[field: string]: mixed } };
           :
        422│     }
        423│     result[key] = filledInStyle;
        424│   }
        425│   return StyleSheet.create(result);
        426│ }
        427│
        428│ function styleSelector<IS: Styles>(

        ../node_modules/react-native/Libraries/StyleSheet/StyleSheetTypes.js
 [2][3] 617│   aspectRatio?: number | string,

And the create definition is this:

declare export const create: <+S: ____Styles_Internal>(
  obj: S & ____Styles_Internal,
) => $ReadOnly<S>;

so result is expected to be ____Styles_Internal but it's a map of maps of strings to mixed.
I tried changing the definition of Styles to for example this:

type Styles = { [name: string]: Partial<____DangerouslyImpreciseStyle_Internal> };

and that would've worked but we sometimes put strings in opacity (modalContrastOpacity) and in ____DangerouslyImpreciseStyle_Internal opacity accepts only numbers.