https://linear.app/comm/issue/ENG-10205/update-flow-to-02691
All I did here is changing the order of object properties, because flow was throwing errors about overwriting properties.
Depends on D15043
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
flow was throwing errors about overwriting properties
Do we know why it was throwing the errors? Sounds a bit concerning.
Comment Actions
Here is try flow for experimenting
The error appears in flow v0.257
And in the changelog there is this point:
We fixed a major unsoundness with regards to dictionary object creation. Previously, the computed property will just be ignored for string or any keys. Now, if the computed property is added to some existing objects (e.g. {foo: string, [stringTypedKey]: v}), then we will error on the property. Otherwise, the {[key]: value} will be {[typeof key}: typeof value}