https://linear.app/comm/issue/ENG-10205/update-flow-to-02691
There are no types available in flow-typed for those libraries and adding types for them would take time, so I created stubs automatically.
Depends on D15044
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
How were we able to use these in the past? Why are the type definitions required now?
Comment Actions
It's actually due to expo libraries upgrade. Let's see for example for expo-haptics. It breaks between versions 13.0.1 and 14.0.0. And between those versions there was this commit: https://github.com/expo/expo/commit/0f999166f4bc882b5d1c08474dcf0d6a9750bffd
There is the following change in package.json:
"main": "build/Haptics.js", -> "main": "src/Haptics.ts",
and build/Haptics.js is deleted. Now there are only ts files in src and build folders and probably flow has an issue with this.
Comment Actions
Do we have a plan for typing the surface of the libraries that we're using? Did you check if Flow-Typed contains definitions for them?
Comment Actions
I can create a follow up issue. I also mentioned in the diff description that:
There are no types available in flow-typed for those libraries
Comment Actions
Great, please do that.
There are no types available in flow-typed for those libraries
Ok, this looks right. I can see that e.g. expo-file-system has some definitions, but they are for versions 4-6, and we're on 15 (on the master). Not sure how much the API has changed, but we can consider checking that and maybe use it as an inspiration.
Comment Actions
Created a follow up task here: https://linear.app/comm/issue/ENG-11059/add-flow-types-for-expo-libraries