Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/types/endpoints.js | ||
|---|---|---|
| 150–156 ↗ | (On Diff #49122) | I think it would be better to keep the symmetry between Endpoint and endpoints. Currently export type Endpoint = | HTTPOnlyEndpoint | SocketOnlyEndpoint | HTTPPreferredEndpoint | SocketPreferredEndpoint; so we should aim for export const endpoints: $ReadOnlyArray<Endpoint> = [ ...values(httpOnlyEndpoints), ...values(socketOnlyEndpoints), ...values(httpPreferredEndpoints), ...values(socketPreferredEndpoints), and create the missing values if necessary. |