https://linear.app/comm/issue/ENG-10205/update-flow-to-02691
message.type can't be UPDATE_RELATIONSHIP
Depends on D15081
Details
Details
Flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Could you explain why message.type can't be UPDATE_RELATIONSHIP? Do we still need to keep the validatorMessageType === messageTypes.UPDATE_RELATIONSHIP && message.type === messageTypes.LEGACY_UPDATE_RELATIONSHIP condition?
Comment Actions
Look at the messages list a little higher. There is no message with type messageTypes.UPDATE_RELATIONSHIP. message comes from iterating over messages. So message.type === messageTypes.UPDATE_RELATIONSHIP is always false. So
(validatorMessageType === messageTypes.LEGACY_UPDATE_RELATIONSHIP &&
message.type === messageTypes.UPDATE_RELATIONSHIP)is always false.
Comment Actions
Ok, makes sense, but I think a better solution would be to introduce a new message type in that array so that our tests cover it.