Details

Reviewers

tomek

Commits

rCOMM734d91d3a35c: [Flow262][skip-ci] Update eslint configuration

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

Eslint failed to run after upgrade, so based on docs here: https://flow.org/en/docs/tools/eslint/

changed @babel/eslint-parser -> hermes-eslint
changed flowtype plugin -> ft-flow
updated packages versions

Depends on D14998

Test Plan

Run eslint

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 21 2025, 10:55 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 21 2025, 10:55 PM

Harbormaster completed remote builds in B34650: Diff 48849.Jul 21 2025, 10:59 PM

angelika added a child revision: D15000: [Flow262][skip-ci] Update lodash@4 flow-typed package.Jul 21 2025, 11:00 PM

Rebase

Harbormaster completed remote builds in B34846: Diff 49053.Jul 24 2025, 4:20 PM

angelika published this revision for review.Jul 25 2025, 9:20 AM

angelika added a reviewer: tomek.

tomek accepted this revision.Jul 28 2025, 2:16 PM

This revision is now accepted and ready to land.Jul 28 2025, 2:16 PM

Rebase & review changes

Harbormaster completed remote builds in B35113: Diff 49364.Aug 9 2025, 12:18 PM

Rebase & review changes

Harbormaster completed remote builds in B35379: Diff 49668.Aug 21 2025, 12:39 PM

Closed by commit rCOMM734d91d3a35c: [Flow262][skip-ci] Update eslint configuration. · Explain WhyAug 21 2025, 7:31 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM734d91d3a35c: [Flow262][skip-ci] Update eslint configuration.

[Flow262][skip-ci] Update eslint configuration
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49668

.eslintrc.json

keyserver/src/user/login.js

lib/hooks/chat-mention-hooks.js

lib/hooks/thread-hooks.js

native/app.config.js

native/chat/inner-text-message.react.js

native/chat/typeahead-tooltip.react.js

native/metro.config.js

native/navigation/chat-tab-bar-button.react.js

package.json

scripts/generate-phab-tag-removal-script.js

scripts/get-cargo-path.js

scripts/get-clang-paths-cli.js

scripts/get-clang-paths.js

scripts/set-admin-data.js

scripts/set-user-credentials.js

web/components/dropdown.react.js

web/jest-setup.js

web/media/image-utils.js

yarn.lock

[Flow262][skip-ci] Update eslint configurationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49668

.eslintrc.json

keyserver/src/user/login.js

lib/hooks/chat-mention-hooks.js

lib/hooks/thread-hooks.js

native/app.config.js

native/chat/inner-text-message.react.js

native/chat/typeahead-tooltip.react.js

native/metro.config.js

native/navigation/chat-tab-bar-button.react.js

package.json

scripts/generate-phab-tag-removal-script.js

scripts/get-cargo-path.js

scripts/get-clang-paths-cli.js

scripts/get-clang-paths.js

scripts/set-admin-data.js

scripts/set-user-credentials.js

web/components/dropdown.react.js

web/jest-setup.js

web/media/image-utils.js

yarn.lock

[Flow262][skip-ci] Update eslint configuration
ClosedPublic
Actions

Revision Contents
Changeset List