Details

Reviewers

tomek

Commits

rCOMM1d73e6549fb0: [Flow262][skip-ci] Fix Variance modifiers cannot appear on a type parameter of…

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

Depends on D15001

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 21 2025, 11:03 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 21 2025, 11:03 PM

Harbormaster completed remote builds in B34653: Diff 48852.Jul 21 2025, 11:06 PM

angelika added a child revision: D15003: [Flow262][skip-ci] Update redux@4 flow-typed package.Jul 22 2025, 12:58 AM

Rebase

Harbormaster completed remote builds in B34849: Diff 49056.Jul 24 2025, 4:20 PM

angelika published this revision for review.Jul 25 2025, 9:21 AM

angelika added a reviewer: tomek.

Why the variance modifiers were there? Is it safe to remove them?

This revision is now accepted and ready to land.Jul 28 2025, 2:21 PM

Rebase & review changes

Harbormaster completed remote builds in B35116: Diff 49367.Aug 9 2025, 12:18 PM

In D15002#415595, @tomek wrote:

Why the variance modifiers were there? Is it safe to remove them?

It is probably safe to remove them because flow ignored them anyway: https://github.com/facebook/flow/issues/7412

Rebase & review changes

Harbormaster completed remote builds in B35382: Diff 49671.Aug 21 2025, 12:40 PM

Closed by commit rCOMM1d73e6549fb0: [Flow262][skip-ci] Fix Variance modifiers cannot appear on a type parameter of…. · Explain WhyAug 21 2025, 7:31 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM1d73e6549fb0: [Flow262][skip-ci] Fix Variance modifiers cannot appear on a type parameter of….

[Flow262][skip-ci] Fix Variance modifiers cannot appear on a type parameter of a function type
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49671

keyserver/flow-typed/npm/react-redux_v7.x.x.js

lib/flow-typed/npm/react-redux_v7.x.x.js

lib/flow-typed/npm/tcomb_v3.x.x.js

native/flow-typed/npm/react-redux_v7.x.x.js

web/flow-typed/npm/react-redux_v7.x.x.js

[Flow262][skip-ci] Fix Variance modifiers cannot appear on a type parameter of a function typeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49671

keyserver/flow-typed/npm/react-redux_v7.x.x.js

lib/flow-typed/npm/react-redux_v7.x.x.js

lib/flow-typed/npm/tcomb_v3.x.x.js

native/flow-typed/npm/react-redux_v7.x.x.js

web/flow-typed/npm/react-redux_v7.x.x.js

[Flow262][skip-ci] Fix Variance modifiers cannot appear on a type parameter of a function type
ClosedPublic
Actions

Revision Contents
Changeset List