https://linear.app/comm/issue/ENG-10205/update-flow-to-02691
I simplified this type and there is a little difference after this change but it shouldn't affect us.
Depends on D15025
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
What is the difference after the change? It seems like some functionality is being lost here. Please explain this in detail
Comment Actions
Changed so there are less changes now.
Before: if ParamList[DestinationRouteName] was undefined we couldn't add params parameter. If ParamList[DestinationRouteName] was not undefined we can include params.
Now it's a bit less safe, because we can include params even though ParamList[DestinationRouteName] is undefined.
The change is necessary because there are errors like this:
Cannot call navigate because: [incompatible-call]
• Either object literal [1] is incompatible with string literal NUXTipOverlayBackdrop [2].
• Or property params is missing in object type [3] but exists in object literal [1].
components/directory-prompt-bottom-sheet.react.js
67│ }, [communities, goBack, navigate]);
68│
69│ const onCloseOrPressDecline = React.useCallback(() => {
[2][1] 70│ navigate<'NUXTipOverlayBackdrop'>({
71│ name: NUXTipOverlayBackdropRouteName,
72│ params: {
73│ orderedTips,
74│ },
75│ });
flow-typed/npm/@react-navigation/core_v6.x.x.js
[3] 815│ | {| +name: DestinationRouteName, +key?: string |},and it looks like $IsUndefined returns ParamList[DestinationRouteName] is undefined even though it isn't, I don't know why though.
Also made a check if $If and $IsUndefined work properly and indeed they are: try flow