Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
This is a step backward - in the past, MemberInfoWithPermissions was the type used here, but we migrated from that. After the mgrations, only MemberInfoSansPermissions correctly describes the types.
Comment Actions
It looks like the migration might not have been complete, after changing thinRawThreadInfoValidator from this:
const thinRawThreadInfoValidator: TInterface<ThinRawThreadInfo> =
tShape<ThinRawThreadInfo>({
…
members: t.union([
t.list(memberInfoWithPermissionsValidator),
t.list(memberInfoSansPermissionsValidator),
]),
});to this:
const thinRawThreadInfoValidator: TInterface<ThinRawThreadInfo> =
tShape<ThinRawThreadInfo>({
…
members: t.list(memberInfoSansPermissionsValidator),
});the test here fails, because minimallyEncodeRawThreadInfoWithMemberPermissions returns thread info with members with permissions. And minimallyEncodeRawThreadInfoWithMemberPermissions is used in a few places, in particular here. So for now I'm just modifying types and I've created a follow up task to figure out how to solve this: https://linear.app/comm/issue/ENG-11054/fix-thinrawthreadinfo-type