Could you add a screenshot here? Both with the button and error state?

Could you update exactly what you're removing (or planning to remove in this diff)? It's unclear which functionality should stay and which should go. It _seems_ like deleteAccount and logOut are to be removed. But, I want to make sure I'm on the same with you 100%.

Makes sense to just copy-paste the CSS we have and not continue to share it in a bunch of different modals.

In D3440#93771, @palys-swm wrote:

The screenshot matches the design from https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A79456 - when a message has failed. When a message is successful, we display the message below the sidebar https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A79202. Could you share a screenshot of that scenario? Also, it would be great to see how it looks like when there are more sidebars.

Accepting, with the assumption that it looks correct when the message has not failed and when there are more sidebars.

diff review

rebase

remove optional parameter

No code change, but setting to needs review to get this on ashoat's queue.

In D3421#93639, @ashoat wrote:

Ah yeah, I can see that design doesn't look good, with the mark-as-unread background being the same as the ChatThreadListItem background. What I don't understand, is that my suggestion was just to flip hover and selected state... so are you're saying that in the Figma design, one of either the hover state or the selected state has the same color as the mark-as-unread background? Or does the Figma design simply not cover both hover state and selected state?

If the Figma design only has a design for one, then we can just make the hover state and the selected state the same. If it has a design for both, but one of them has the same background as the mark-as-unread button, then we'll need to figure out a new design.

Should all of these diffs relating to the splash page be in a linked stack on phabricator? Looks good otherwise.

I'd also just double check in asset-meta-data.js in the landing project too.

Yeah, I should have removed them when I worked on it last. Good catch.

LGTM

Looking at the stackoverflow post, LGTM

Note, I'm aligining the menu button (three dot vertical) in the next diff.

Followed up with a comment about how this color switch will adversely effect the mark as unread button.

talked about this IRL with @atul . Going to land.

In D3421#93110, @ashoat wrote:

Looks good to me!

I don't think this will really work with the updated mark and unread styling.

Not sure what you're referring to, or what the issue would be. Can you clarify?

Back to you to make changes

diff review fix

diff review, change HTMLButtionElement to HTMLElement

diff review

rebase

add a function

rename

update onAfter --> actionAfter

Add typescript

remove comments, add additional packages

remove css

In D3409#92731, @ashoat wrote:

Accepting assuming this is a simple copy-paste. If it's not a simple copy-paste, then please separate out the changes into a different diff, and land this one as a simple copy-paste.

I flipped the colors. I don't think this will really work with the updated mark and unread styling.

Only had time for a short skim. Have one question. Looks good!

looks good, just have some qustions.

In D3397#92689, @atul wrote:

Cautiously accepting since it's hard to review

Were you able to convert the paths/strokes to objects/outlines?

In D3392#92367, @atul wrote:

The issue here is with the following in global.css:html:

/* Fallback styling if clamp isn't supported  */
  font-size: 1rem;
  /* https://css-tricks.com/simplified-fluid-typography/ */
  font-size: clamp(
    var(--min-font-size),
    calc(0.75rem + 1vw),
    var(--max-font-size)
  );

which changes the definition of 1rem = 16px to something that varies with the width. We shouldn't be doing this, as it messes up the math downstream.

I've created an issue to address this: https://linear.app/comm/issue/ENG-867/remove-font-size-clamp-from-globalcss

We can either let this diff through with values that we've found work experimentally, or we can make that change and do it "correctly." The issue is that after removing that global clamp, we'll need to change the other 4-5 occurrences of font-size: clamp and make sure they continue to look as expected.

cc: @ashoat @palys-swm @benschac

going to resign as a reviewer since both ashoat and tomek have feedback.

Going to re-request review now that all of the input elements using type="submit" (in the modals you mentioned above) have been updated in the parent diff.

In D3288#90945, @ashoat wrote:

Makes sense, glad to hear you figured out what went wrong and know how to improve.

To unblock this diff, can you make sure that it's not causing any regressions in any of the above listed modals?

add danger variant to delete

https://linear.app/comm/issue/ENG-799/message-tooltip-position-is-incorrect -- @atul assuming you're working on this. Could you update the linear task if you're taking this issue on?