https://phabricator.ashoat.com/D3620 -- you beat me to the punch. 🥲

diff review

update import

In D3611#98972, @atul wrote:

I think we can come up with a better name than assetURL? Maybe assetsCacheURLPrefix?

Just something to indicate that it's a prefix that we'll need to append the asset name to. iirc there was an issue before caused by confusing URL "part" names

last change

remove duplicated line

small fix

atul diff review round 2 plus varun fix

still can use this diff. Just need to swap out the arrow.

In D3444#98394, @atul wrote:

In D3444#98393, @benschac wrote:

These are blocked by getting longer arrow svgs

How much longer did you want the arrow?

These are blocked by getting longer arrow svgs

(solution where if the conversation has many threads, a longer arrow will be rendered to show a continuous line between threads)

Going to close this in favor of a longer arrow.

update diff

Can you add a screenshot of each of these components you're changing?

atuls comments

no longer needed. closing.

Great, I'll update the docs. I wasn't sure how much detail was really needed here. I'll add a bit more context.

not yet. Waiting on the arrow.

adding @ashoat as blocking since this is documentation: https://www.notion.so/commapp/Diff-Review-Rules-addfc3a41b324c7d8ba636dd9dcefeba

remove height

make mobile and web match

rebase

rebase

I should have waited for the CI to finish. Sorry everyone.

rebase

In D3505#95835, @benschac wrote:

css['white'] project for this string before landing.

diff review. update name

rebase

diff review

In D3500#95810, @palys-swm wrote:

My only note would be if we could make the css naming change here: D3505. The ternary is abstracted into one call and I wouldn't have rebasing conflicts if I made the change in that diff if that's okay?

Yeah, I think it makes sense.

after searching the code base. css.white, css.light, css.dark are only used in message-preview.react.js

It might be a good idea to also check css['white'] - we're using this syntax in a couple of places

In D3480#95747, @ashoat wrote:

sidebar arrows: that regression was introduced in D3440 because the arrows aren't long enough and will hopefully be resolved when https://linear.app/comm/issue/ENG-911/extend-arrow-svg-height-in-thread-sidebar-design is completed. D3440 should be blocked until ENG-911 is resolved (and hopefully fixes the problem).

Should this diff also be blocked until ENG-911 is resolved?

css['white'] project for this string before landing.

atul diff suggestions