update leave modal

Closing in favor of D3843

great, let's favor this diff instead of D3730, we should still add color to the component now that the fill is no longer rgb(128, 128 ,128) via the SWMIcon props.

This looks alright for me. What did you end up doing to actually fix the problem? Did you edit the SVG in Illistrator?

I ran this command on my machine and it's working as expected. LGTM

Makes sense, ran lint-staged locally and it's working as expected on my end.

@ashoat, you should probably commandeer at this point. You did the implementation while I watched. Happy to take it if that's easier for you though.

In D3809#106403, @atul wrote:

I just noticed modal styling broke during a rebase.

Are you planning changes to this diff, or did you want it to be reviewed as is?

In D3809#105846, @ashoat wrote:

I just noticed modal styling broke during a rebase

Broken in production or just in your stack? If that latter, might be better to hold off on submitting this diff until you have your stack straightened out.

This is also on me as a native English speaker. For reference, most of the onClick hander was auto-generated with GH autopilot and I didn't take the extra minute to really look at the copy, triple check it, read it out loud. Make sure it was correct.

In D3539#102420, @palys-swm wrote:

It looks ok as a workaround. Have you tested how it behaves if we zoom the page or resize it?

For me it looks like the best way to make it consistent with the rest of an arrow is to draw this whole shape via css. What do you think?

In D3782#106160, @ashoat wrote:

How about @palys-swm's questions?

It looks ok as a workaround. Have you tested how it behaves if we zoom the page or resize it?

Yeah, I can do that.

Added reference to the snippets in notion: https://www.notion.so/commapp/VSCode-setup-1ec2d3fefb0c416e88adce8a8ebad21c if anyone else is interested in using them.

In D3615#103707, @ashoat wrote:

If we're setting name to React.Node, then it seems like the parent component can just pass in <><SWMansionIcon size={24} icon={icon} />Name</>, which arguably is cleaner.

Whoopsy! didn't implement the entire change.

ashoat review changes

Looks good. Had a couple of questions. Additionally, could you add the figma link?

update types

add annotations to webpack files

In D3761#103878, @ashoat wrote:

How about lib/webpack/shared.cjs? Furthermore: if the ESLint parser simply can't handle CommonJS, should we just disable it for all .cjs files?

Is there a way to get this to work by configuring ESLint to treat .cjs files as CommonJS? Have you tried /* eslint-env commonjs */ annotation, or any of the other strategies described here?

remove method

change onCancel fn

https://linear.app/comm/issue/ENG-1026/follow-up-if-we-want-to-store-images-somewhere-for-backup

remove error arg

remove error arg

In D3723#104110, @palys-swm wrote:

Accepting, but it would be great if you could address this

The summary is confusing. Please add some description to the images, telling which one is "before" and which is "after".

diff review

rebase

rebase

rebase

rebase

change return type

diff review fixes

changes aren't reflected

rebase