Page MenuHomePhabricator
Feed Advanced Search

May 6 2022

jacek requested review of D3954: [web] Dispatch change notification settings action in `NotificationsModal`.
May 6 2022, 8:05 AM
jacek requested review of D3953: [web] Introduce thread notification settings options in modal.
May 6 2022, 8:00 AM
jacek requested review of D3952: [web] Introduce `NotificationsModal` component.
May 6 2022, 7:56 AM
jacek requested review of D3949: [web] Introduce `NotificationsOption` component.
May 6 2022, 7:49 AM
jacek requested review of D3947: [web] Introduce `NotificationsOptionInfo` component.
May 6 2022, 7:35 AM
jacek requested review of D3946: [web] Introduce custom `Radio` component.
May 6 2022, 7:24 AM
jacek requested review of D3944: [web] Add check and notifications settings icons.
May 6 2022, 7:19 AM
jacek closed D3876: [web] Display list of pending users to add in `AddMembersModal`.
May 6 2022, 1:56 AM
jacek committed rCOMM4f642b558436: [web] Display list of pending users to add in `AddMembersModal` (authored by jacek).
[web] Display list of pending users to add in `AddMembersModal`
May 6 2022, 1:55 AM
jacek closed D3875: [web] Introduce close button in `Label` component.
May 6 2022, 1:55 AM
jacek committed rCOMM22df63a928fd: [web] Introduce close button in `Label` component (authored by jacek).
[web] Introduce close button in `Label` component
May 6 2022, 1:55 AM
jacek closed D3877: [web] Memoize `Chat` component.
May 6 2022, 1:45 AM
jacek committed rCOMMb79a177080f0: [web] Memoize `Chat` component (authored by jacek).
[web] Memoize `Chat` component
May 6 2022, 1:44 AM
jacek updated the diff for D3876: [web] Display list of pending users to add in `AddMembersModal`.

replace spread with Array.from & rebase before landing

May 6 2022, 1:43 AM
jacek updated the diff for D3875: [web] Introduce close button in `Label` component.

rebase

May 6 2022, 1:40 AM
jacek updated the diff for D3877: [web] Memoize `Chat` component.

rebase

May 6 2022, 1:39 AM

May 4 2022

jacek accepted D3892: [web] Remove `max-height` property from `modal.css: modalContainer[Small/Large]`.

As far as I remember, all modals before D3669 (the smaller and the larger ones) had the max-height set to 500px, so when redesigning I didn't want to change this size.
I'm open to removing this height limit, but please make sure it doesn't break existing modals.

May 4 2022, 7:46 AM

Apr 29 2022

jacek added inline comments to D3876: [web] Display list of pending users to add in `AddMembersModal`.
Apr 29 2022, 9:58 AM
jacek requested review of D3877: [web] Memoize `Chat` component.
Apr 29 2022, 7:09 AM
jacek requested review of D3876: [web] Display list of pending users to add in `AddMembersModal`.
Apr 29 2022, 5:06 AM
jacek updated the summary of D3875: [web] Introduce close button in `Label` component.
Apr 29 2022, 4:53 AM
jacek requested review of D3875: [web] Introduce close button in `Label` component.
Apr 29 2022, 4:50 AM
jacek closed D3745: [web] Introduce "Add Members" button in `MembersModal`.
Apr 29 2022, 3:44 AM
jacek committed rCOMM5a5d54e9c537: [web] Introduce "Add Members" button in `MembersModal` (authored by jacek).
[web] Introduce "Add Members" button in `MembersModal`
Apr 29 2022, 3:44 AM
jacek closed D3744: [web] Add callback adding members to thread in `AddMembersModal`.
Apr 29 2022, 3:44 AM
jacek closed D3742: [web] Introduce `AddMembersModal` component.
Apr 29 2022, 3:44 AM
jacek closed D3743: [web] Introduce searching users in `AddMembersModal`.
Apr 29 2022, 3:44 AM
jacek committed rCOMMb9d09aa7006b: [web] Introduce `AddMembersModal` component (authored by jacek).
[web] Introduce `AddMembersModal` component
Apr 29 2022, 3:44 AM
jacek closed D3741: [web] Introduce `AddMembersList` component.
Apr 29 2022, 3:44 AM
jacek committed rCOMM5261b164eb1e: [web] Add callback adding members to thread in `AddMembersModal` (authored by jacek).
[web] Add callback adding members to thread in `AddMembersModal`
Apr 29 2022, 3:44 AM
jacek committed rCOMMac879d198c4c: [web] Introduce searching users in `AddMembersModal` (authored by jacek).
[web] Introduce searching users in `AddMembersModal`
Apr 29 2022, 3:44 AM
jacek committed rCOMM3dc3f65cceb8: [web] Introduce `AddMembersList` component (authored by jacek).
[web] Introduce `AddMembersList` component
Apr 29 2022, 3:44 AM
jacek closed D3739: [web] Introduce `AddMembersItem` component.
Apr 29 2022, 3:44 AM
jacek closed D3740: [web] Introduce `AddMemberGroup` component.
Apr 29 2022, 3:44 AM
jacek committed rCOMMa5d44d43531c: [web] Introduce `AddMembersItem` component (authored by jacek).
[web] Introduce `AddMembersItem` component
Apr 29 2022, 3:44 AM
jacek committed rCOMM3b3a273460d7: [web] Introduce `AddMemberGroup` component (authored by jacek).
[web] Introduce `AddMemberGroup` component
Apr 29 2022, 3:44 AM
jacek closed D3813: [web] Introduce `:disabled` and `:hover` styles for `Button`.
Apr 29 2022, 3:44 AM
jacek committed rCOMMeb321af746f6: [web] Introduce `:disabled` and `:hover` styles for `Button` (authored by jacek).
[web] Introduce `:disabled` and `:hover` styles for `Button`
Apr 29 2022, 3:44 AM
jacek updated the diff for D3744: [web] Add callback adding members to thread in `AddMembersModal`.

rebase

Apr 29 2022, 3:18 AM
jacek updated the diff for D3743: [web] Introduce searching users in `AddMembersModal`.

rebase

Apr 29 2022, 3:17 AM
jacek updated the diff for D3742: [web] Introduce `AddMembersModal` component.

rebase

Apr 29 2022, 3:17 AM
jacek updated the diff for D3741: [web] Introduce `AddMembersList` component.

rebase

Apr 29 2022, 3:16 AM
jacek updated the diff for D3740: [web] Introduce `AddMemberGroup` component.

rebase

Apr 29 2022, 3:16 AM
jacek updated the diff for D3739: [web] Introduce `AddMembersItem` component.

rebase

Apr 29 2022, 3:15 AM
jacek updated the diff for D3813: [web] Introduce `:disabled` and `:hover` styles for `Button`.

rebase

Apr 29 2022, 3:15 AM
jacek updated the diff for D3745: [web] Introduce "Add Members" button in `MembersModal`.

Move canAddMembers outside the useMemo.

Apr 29 2022, 3:12 AM
jacek added inline comments to D3745: [web] Introduce "Add Members" button in `MembersModal`.
Apr 29 2022, 2:57 AM
jacek requested changes to D3565: Deep-link user to applications settings when they try to enable notifications for a thread without notifications enabled globally for Comm application..
Apr 29 2022, 2:52 AM
jacek accepted D3809: [web] [feat] [ENG-991] add modal prompt.
Apr 29 2022, 2:35 AM

Apr 27 2022

jacek updated the diff for D3744: [web] Add callback adding members to thread in `AddMembersModal`.

rebase

Apr 27 2022, 2:39 AM
jacek updated the diff for D3743: [web] Introduce searching users in `AddMembersModal`.

Simplify memo & rebase

Apr 27 2022, 2:38 AM
jacek updated the diff for D3742: [web] Introduce `AddMembersModal` component.

rebase

Apr 27 2022, 2:34 AM
jacek updated the diff for D3741: [web] Introduce `AddMembersList` component.

rebase

Apr 27 2022, 2:33 AM
jacek updated the diff for D3740: [web] Introduce `AddMemberGroup` component.

rebase

Apr 27 2022, 2:32 AM
jacek updated the diff for D3739: [web] Introduce `AddMembersItem` component.

rebase

Apr 27 2022, 2:31 AM
jacek updated the diff for D3813: [web] Introduce `:disabled` and `:hover` styles for `Button`.

replace background-color with background & rebase

Apr 27 2022, 2:29 AM
jacek requested changes to D3809: [web] [feat] [ENG-991] add modal prompt.
Apr 27 2022, 2:08 AM

Apr 26 2022

jacek closed D3836: [web] Change `ConfirmLeaveThreadModal` size to `fit-content`.
Apr 26 2022, 9:09 AM
jacek closed D3671: [web] Adjust `MembersModal` size to match designs.
Apr 26 2022, 9:09 AM
jacek committed rCOMM793626f9a376: [web] Change `ConfirmLeaveThreadModal` size to `fit-content` (authored by jacek).
[web] Change `ConfirmLeaveThreadModal` size to `fit-content`
Apr 26 2022, 9:09 AM
jacek closed D3672: [web] Adjust `SubchannelsModal` size to match designs.
Apr 26 2022, 9:09 AM
jacek committed rCOMM7daabdc391c1: [web] Adjust `MembersModal` size to match designs (authored by jacek).
[web] Adjust `MembersModal` size to match designs
Apr 26 2022, 9:09 AM
jacek committed rCOMMd8e2452fd22d: [web] Adjust `SubchannelsModal` size to match designs (authored by jacek).
[web] Adjust `SubchannelsModal` size to match designs
Apr 26 2022, 9:09 AM
jacek closed D3670: [web] Allow passing `Modal` parameters into `SearchModal`.
Apr 26 2022, 9:09 AM
jacek committed rCOMMd0de89e4792c: [web] Allow passing `Modal` parameters into `SearchModal` (authored by jacek).
[web] Allow passing `Modal` parameters into `SearchModal`
Apr 26 2022, 9:09 AM
jacek closed D3669: [web] Redesign `Modal` to match Figma.
Apr 26 2022, 9:09 AM
jacek closed D3668: [web] Remove `Modal`s usused style.
Apr 26 2022, 9:09 AM
jacek committed rCOMM3274d77df84a: [web] Remove `Modal`s usused style (authored by jacek).
[web] Remove `Modal`s usused style
Apr 26 2022, 9:09 AM
jacek committed rCOMM1a646434baa1: [web] Redesign `Modal` to match Figma (authored by jacek).
[web] Redesign `Modal` to match Figma
Apr 26 2022, 9:09 AM
jacek closed D3667: [web] Convert `Modal` into functional component.
Apr 26 2022, 9:09 AM
jacek closed D3666: [web] Center modals vertically.
Apr 26 2022, 9:09 AM
jacek committed rCOMM2986754c24d3: [web] Convert `Modal` into functional component (authored by jacek).
[web] Convert `Modal` into functional component
Apr 26 2022, 9:09 AM
jacek committed rCOMMff68fc69e922: [web] Center modals vertically (authored by jacek).
[web] Center modals vertically
Apr 26 2022, 9:09 AM
jacek closed D3665: [web] Allow displaying multiple modals.
Apr 26 2022, 9:09 AM
jacek committed rCOMMe2d045ebf313: [web] Allow displaying multiple modals (authored by jacek).
[web] Allow displaying multiple modals
Apr 26 2022, 9:09 AM
jacek updated the diff for D3836: [web] Change `ConfirmLeaveThreadModal` size to `fit-content`.

revert accidental change after rebase

Apr 26 2022, 9:02 AM
jacek updated the diff for D3669: [web] Redesign `Modal` to match Figma.

removed redundant min-height

Apr 26 2022, 8:55 AM
jacek added inline comments to D3669: [web] Redesign `Modal` to match Figma.
Apr 26 2022, 8:54 AM
jacek updated the diff for D3836: [web] Change `ConfirmLeaveThreadModal` size to `fit-content`.

rebase

Apr 26 2022, 8:35 AM
jacek updated the diff for D3672: [web] Adjust `SubchannelsModal` size to match designs.

rebase

Apr 26 2022, 8:35 AM
jacek updated the diff for D3671: [web] Adjust `MembersModal` size to match designs.

rebase

Apr 26 2022, 8:34 AM
jacek updated the diff for D3670: [web] Allow passing `Modal` parameters into `SearchModal`.

rebase

Apr 26 2022, 8:34 AM
jacek updated the diff for D3669: [web] Redesign `Modal` to match Figma.

rebase

Apr 26 2022, 8:34 AM
jacek updated the diff for D3668: [web] Remove `Modal`s usused style.

rebase

Apr 26 2022, 8:33 AM
jacek updated the diff for D3667: [web] Convert `Modal` into functional component.

rebase

Apr 26 2022, 8:33 AM
jacek updated the diff for D3666: [web] Center modals vertically.

rebase

Apr 26 2022, 8:32 AM
jacek updated the diff for D3665: [web] Allow displaying multiple modals.

rebase

Apr 26 2022, 8:32 AM
jacek closed D3854: [web] [fix] Replace `overflow: scroll` with `auto` to automatically hide scrollbars.
Apr 26 2022, 7:52 AM
jacek committed rCOMM5fd125e47f79: [web] [fix] Replace `overflow: scroll` with `auto` to automatically hide… (authored by jacek).
[web] [fix] Replace `overflow: scroll` with `auto` to automatically hide…
Apr 26 2022, 7:52 AM
jacek added a comment to D3836: [web] Change `ConfirmLeaveThreadModal` size to `fit-content`.

Are there any other modals that need this update? Adding @atul as a blocking reviewer to make sure he sees this as he's been cleaning up some modals recently

Apr 26 2022, 7:47 AM
jacek updated the diff for D3854: [web] [fix] Replace `overflow: scroll` with `auto` to automatically hide scrollbars.

rebase

Apr 26 2022, 7:43 AM
jacek added a comment to D3854: [web] [fix] Replace `overflow: scroll` with `auto` to automatically hide scrollbars.
In D3854#106911, @palys-swm wrote:

Could you maybe search the whole codebase and check if we're using overflow: scroll anywhere?

Apr 26 2022, 7:42 AM
jacek published D3854: [web] [fix] Replace `overflow: scroll` with `auto` to automatically hide scrollbars for review.
Apr 26 2022, 5:06 AM
jacek updated the diff for D3742: [web] Introduce `AddMembersModal` component.

changed type

Apr 26 2022, 4:51 AM
jacek updated the diff for D3742: [web] Introduce `AddMembersModal` component.

change overflow from scroll to auto

Apr 26 2022, 4:49 AM
jacek added inline comments to D3742: [web] Introduce `AddMembersModal` component.
Apr 26 2022, 4:44 AM
jacek requested changes to D3809: [web] [feat] [ENG-991] add modal prompt.

I'm wondering if, instead of creating separate SidebarPromoteModal component, shouldn't we use existing logic already implemented in ConfirmLeaveThreadModal and create universal ConfirmModal component, that can receive e.g. title, message (content), and confirm action name? I think, there are quite many places, where something like this could be used in web app. What do you think?

Apr 26 2022, 4:33 AM

Apr 25 2022

jacek updated the diff for D3672: [web] Adjust `SubchannelsModal` size to match designs.

rebase

Apr 25 2022, 10:29 AM
jacek updated the diff for D3671: [web] Adjust `MembersModal` size to match designs.

rebase

Apr 25 2022, 10:29 AM
jacek updated the diff for D3670: [web] Allow passing `Modal` parameters into `SearchModal`.

rebase

Apr 25 2022, 10:28 AM