Page MenuHomePhabricator
Feed Advanced Search

Oct 24 2022

max updated the summary of D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
Oct 24 2022, 9:26 AM
max updated the diff for D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.

Removed unused and deprecated requirements.
Fixed GTest include in Docker(Ubuntu) build.

Oct 24 2022, 9:25 AM
max updated the summary of D5431: [services] Tunnelbroker - Removing of deprecated C++ files.
Oct 24 2022, 9:22 AM
max updated the summary of D5429: [services] Tunnelbroker - Initialization function exposed to Rust.
Oct 24 2022, 9:21 AM
max updated the summary of D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure.
Oct 24 2022, 9:19 AM
max planned changes to D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
Oct 24 2022, 6:40 AM
max planned changes to D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo`.
Oct 24 2022, 3:52 AM
max planned changes to D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.
Oct 24 2022, 3:41 AM
max updated the diff for D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.

Updating on a stack reordering.

Oct 24 2022, 3:39 AM
max planned changes to D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.
Oct 24 2022, 3:35 AM
max updated the diff for D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.

Updating on the stack reordering.
Adding of services/tunnelbroker/src/libcpp/test/build directory to ignore the C++ gTest building cache.

Oct 24 2022, 3:35 AM
max planned changes to D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.
Oct 24 2022, 3:34 AM
max updated the diff for D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.

Updating on the stack reordering.

Oct 24 2022, 3:25 AM
max updated the diff for D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust.

Update on a stack reordering.

Oct 24 2022, 3:22 AM
max updated the diff for D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.

Fixing shared path, removing of unused commands, changes the stack order.

Oct 24 2022, 3:18 AM
max updated the summary of D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
Oct 24 2022, 3:16 AM
max updated the diff for D5431: [services] Tunnelbroker - Removing of deprecated C++ files.

Updating stack dependencies.

Oct 24 2022, 3:09 AM

Oct 22 2022

max updated the summary of D5431: [services] Tunnelbroker - Removing of deprecated C++ files.
Oct 22 2022, 5:15 AM

Oct 21 2022

max published D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo` for review.
Oct 21 2022, 3:20 PM
max published D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker for review.
Oct 21 2022, 12:02 PM
max updated the diff for D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.

Fixing include path to meet the Docker, adding of linking double-conversion and gflags for the building in Ubuntu Docker container.

Oct 21 2022, 11:00 AM
max added a comment to D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure.
In D5428#161080, @jon wrote:

The CI gates should be updated as part of this as well, having two failing gates isn't good.

I would also be fine with some additional diffs later in the stack which fix the builds later on, however, delaying being "green to green" also means that we will have a lot of intermediate diffs which fail to build or pass tests :(

Oct 21 2022, 10:26 AM
max requested review of D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust.
Oct 21 2022, 10:19 AM
max closed D5380: [services] Tunnelbroker - Unifying paths in Docker according to the local repository.
Oct 21 2022, 9:15 AM
max committed rCOMM0f2b7c8a169b: [services] Tunnelbroker - Unifying paths in Docker according to the local… (authored by max).
[services] Tunnelbroker - Unifying paths in Docker according to the local…
Oct 21 2022, 9:15 AM
max added a comment to D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.

Adding @ashoat as a final review.

Oct 21 2022, 9:13 AM
max added a reviewer for D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app: ashoat.
Oct 21 2022, 9:12 AM
max updated the summary of D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.
Oct 21 2022, 9:00 AM
max updated the diff for D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.

Adding of prost and futures.

Oct 21 2022, 8:53 AM
max updated the diff for D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.

Removing of unused PathBuff.

Oct 21 2022, 8:48 AM
max updated the diff for D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.

Adding of -w flag to the C++ building process to suppress flooding of warnings.

Oct 21 2022, 8:39 AM

Oct 20 2022

max added inline comments to D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.
Oct 20 2022, 9:09 AM
max updated the diff for D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.

Adding of Tunnelbroker[.h,.cpp] to the if-changed scope.

Oct 20 2022, 9:02 AM
max published D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app for review.
Oct 20 2022, 8:27 AM
max published D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies for review.
Oct 20 2022, 8:26 AM
max published D5431: [services] Tunnelbroker - Removing of deprecated C++ files for review.
Oct 20 2022, 8:24 AM
max published D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only for review.
Oct 20 2022, 8:24 AM
max published D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust for review.
Oct 20 2022, 8:22 AM
max published D5429: [services] Tunnelbroker - Initialization function exposed to Rust for review.
Oct 20 2022, 8:22 AM
max published D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app for review.
Oct 20 2022, 8:21 AM
max published D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure for review.
Oct 20 2022, 8:20 AM
max added a comment to D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.

Adding @tomek as a final reviewer.

Oct 20 2022, 1:48 AM
max added a reviewer for D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`: tomek.
Oct 20 2022, 1:48 AM
max added inline comments to D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.
Oct 20 2022, 1:48 AM
max added a comment to D5380: [services] Tunnelbroker - Unifying paths in Docker according to the local repository.

Adding @tomek as blocking.

Oct 20 2022, 1:46 AM
max added a reviewer for D5380: [services] Tunnelbroker - Unifying paths in Docker according to the local repository: tomek.
Oct 20 2022, 1:46 AM

Oct 17 2022

max published D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs` for review.
Oct 17 2022, 8:24 AM
max published D5380: [services] Tunnelbroker - Unifying paths in Docker according to the local repository for review.
Oct 17 2022, 7:20 AM
max planned changes to D5330: [services] Tunnelbroker - Update on using of `init` in Rust notifications library.
Oct 17 2022, 5:12 AM
max planned changes to D5329: [services] Tunnelbroker - Add `init` function to the Rust notification library.
Oct 17 2022, 5:12 AM
max closed D5361: [services] Tunnelbroker - Update Tunnelbroker protobuf file with ping and new device token in bidirectional stream.
Oct 17 2022, 4:26 AM
max committed rCOMM20586527efc1: [services] Tunnelbroker - Update Tunnelbroker protobuf file with ping and new… (authored by max).
[services] Tunnelbroker - Update Tunnelbroker protobuf file with ping and new…
Oct 17 2022, 4:26 AM
max updated the diff for D5361: [services] Tunnelbroker - Update Tunnelbroker protobuf file with ping and new device token in bidirectional stream.

Adding generated files.

Oct 17 2022, 4:06 AM
max added inline comments to D5361: [services] Tunnelbroker - Update Tunnelbroker protobuf file with ping and new device token in bidirectional stream.
Oct 17 2022, 3:43 AM

Oct 14 2022

max requested review of D5361: [services] Tunnelbroker - Update Tunnelbroker protobuf file with ping and new device token in bidirectional stream.
Oct 14 2022, 11:20 AM

Oct 13 2022

max published D5361: [services] Tunnelbroker - Update Tunnelbroker protobuf file with ping and new device token in bidirectional stream for review.
Oct 13 2022, 8:15 AM
max added a reviewer for D5329: [services] Tunnelbroker - Add `init` function to the Rust notification library: tomek.
Oct 13 2022, 4:52 AM
max added a comment to D5329: [services] Tunnelbroker - Add `init` function to the Rust notification library.

Adding @tomek as a blocking here.

Oct 13 2022, 4:52 AM
max added inline comments to D5329: [services] Tunnelbroker - Add `init` function to the Rust notification library.
Oct 13 2022, 4:51 AM

Oct 12 2022

max added inline comments to D5330: [services] Tunnelbroker - Update on using of `init` in Rust notifications library.
Oct 12 2022, 2:42 PM
max updated the diff for D5330: [services] Tunnelbroker - Update on using of `init` in Rust notifications library.

Fixing multiple reads.

Oct 12 2022, 2:40 PM
max added inline comments to D5329: [services] Tunnelbroker - Add `init` function to the Rust notification library.
Oct 12 2022, 1:35 PM
max updated the diff for D5329: [services] Tunnelbroker - Add `init` function to the Rust notification library.

Changes to use derive(Default), sandbox changed to is_sandbox, removing of unwrap().

Oct 12 2022, 1:27 PM

Oct 11 2022

max planned changes to D5329: [services] Tunnelbroker - Add `init` function to the Rust notification library.
Oct 11 2022, 12:02 PM
max planned changes to D5330: [services] Tunnelbroker - Update on using of `init` in Rust notifications library.
Oct 11 2022, 12:01 PM
max accepted D5338: [Services] Force c++17 usage with cxx builds.
Oct 11 2022, 3:22 AM

Oct 10 2022

max published D5330: [services] Tunnelbroker - Update on using of `init` in Rust notifications library for review.
Oct 10 2022, 7:30 AM
max published D5329: [services] Tunnelbroker - Add `init` function to the Rust notification library for review.
Oct 10 2022, 7:30 AM
max closed D5265: [services] Tunnelbroker - Adding of Tonic crate to cargo dependencies.
Oct 10 2022, 4:24 AM
max committed rCOMM17f6455b8006: [services] Tunnelbroker - Adding of Tonic crate to cargo dependencies (authored by max).
[services] Tunnelbroker - Adding of Tonic crate to cargo dependencies
Oct 10 2022, 4:24 AM

Oct 6 2022

max accepted D5304: [Docs] Update tunnelbroker configuration section.

Git-ignoring the tunnelbroker.ini looks reasonable to me, as well as updating the docs reflecting what the configuration file must contain. Thanks, @jon !

Oct 6 2022, 6:14 AM

Oct 4 2022

max added a comment to D5265: [services] Tunnelbroker - Adding of Tonic crate to cargo dependencies.

@max, before landing can you create a task to unify tonic version across the project and link it here?

Oct 4 2022, 10:43 PM

Oct 3 2022

max closed D5263: [services] Tunnelbroker - Using `rust::notifications` namespace for calling Rust from C++.
Oct 3 2022, 2:57 AM
max committed rCOMM2a895ae97c6b: [services] Tunnelbroker - Using `rust::notifications` namespace for calling… (authored by max).
[services] Tunnelbroker - Using `rust::notifications` namespace for calling…
Oct 3 2022, 2:57 AM
max updated the diff for D5263: [services] Tunnelbroker - Using `rust::notifications` namespace for calling Rust from C++.

Rebased on master changes.

Oct 3 2022, 2:41 AM

Sep 30 2022

max added a comment to D5263: [services] Tunnelbroker - Using `rust::notifications` namespace for calling Rust from C++.

I'm not a big fan of typedef too, but using fully qualified names here looks very ugly (looks like a Flutter-way ;) ).
If you guys think it looks ok and readable I'll remove the typdef here. I do not insist on it, it's just some prettifying.

Sep 30 2022, 10:40 AM
max closed D5262: [services] Tunnelbroker - Changes to use `bail` and `ensure` Anyhow macros.
Sep 30 2022, 7:38 AM
max committed rCOMMde96baf6bece: [services] Tunnelbroker - Changes to use `bail` and `ensure` Anyhow macros (authored by max).
[services] Tunnelbroker - Changes to use `bail` and `ensure` Anyhow macros
Sep 30 2022, 7:38 AM
max closed D5261: [services] Tunnelbroker - Renaming Rust library directory from `rust-notifications` to `rust-lib`.
Sep 30 2022, 7:01 AM
max committed rCOMM1880c350abb9: [services] Tunnelbroker - Renaming Rust library directory from `rust… (authored by max).
[services] Tunnelbroker - Renaming Rust library directory from `rust…
Sep 30 2022, 7:01 AM
max updated the diff for D5261: [services] Tunnelbroker - Renaming Rust library directory from `rust-notifications` to `rust-lib`.

Rebased on master changes.

Sep 30 2022, 6:52 AM
max closed D5250: [services] Tunnelbroker - Move Rust notifications library code to the submodule.
Sep 30 2022, 6:50 AM
max committed rCOMM83c281dc6c74: [services] Tunnelbroker - Move Rust notifications library code to the submodule (authored by max).
[services] Tunnelbroker - Move Rust notifications library code to the submodule
Sep 30 2022, 6:50 AM
max added a comment to D5265: [services] Tunnelbroker - Adding of Tonic crate to cargo dependencies.
In D5265#155121, @tomek wrote:

There are two different versions of the lib used in our project 0.8 and 0.6. We should try to keep them in sync, so it might be a good idea to upgrade the older ones at some point.

Sep 30 2022, 5:16 AM
max added a comment to D5265: [services] Tunnelbroker - Adding of Tonic crate to cargo dependencies.

@max, before landing can you create a task to unify tonic version across the project and link it here?

Sep 30 2022, 5:15 AM
max added inline comments to D5263: [services] Tunnelbroker - Using `rust::notifications` namespace for calling Rust from C++.
Sep 30 2022, 5:14 AM
max added a comment to D5263: [services] Tunnelbroker - Using `rust::notifications` namespace for calling Rust from C++.
In D5263#155118, @tomek wrote:

@max please add @marcin as a reviewer for Rust / C++ diffs - he will add me as a blocking reviewer after the diff is accepted.

Sep 30 2022, 5:12 AM
max added inline comments to D5263: [services] Tunnelbroker - Using `rust::notifications` namespace for calling Rust from C++.
Sep 30 2022, 5:11 AM

Sep 29 2022

max published D5265: [services] Tunnelbroker - Adding of Tonic crate to cargo dependencies for review.
Sep 29 2022, 8:22 AM
max published D5263: [services] Tunnelbroker - Using `rust::notifications` namespace for calling Rust from C++ for review.
Sep 29 2022, 7:44 AM
max published D5262: [services] Tunnelbroker - Changes to use `bail` and `ensure` Anyhow macros for review.
Sep 29 2022, 6:06 AM
max published D5261: [services] Tunnelbroker - Renaming Rust library directory from `rust-notifications` to `rust-lib` for review.
Sep 29 2022, 6:03 AM
max published D5250: [services] Tunnelbroker - Move Rust notifications library code to the submodule for review.
Sep 29 2022, 6:03 AM

Sep 26 2022

max added inline comments to D5207: [services] Tunnelbroker - Update sending of the `newNotifyTokenRequired` in `Get` stream request.
Sep 26 2022, 1:39 AM
max added inline comments to D5207: [services] Tunnelbroker - Update sending of the `newNotifyTokenRequired` in `Get` stream request.
Sep 26 2022, 1:38 AM

Sep 23 2022

max closed D5175: [services] Tunnelbroker - Update device online status in `Get` handler.
Sep 23 2022, 2:07 PM
max committed rCOMM1fa7b64d2d6b: [services] Tunnelbroker - Update device online status in `Get` handler (authored by max).
[services] Tunnelbroker - Update device online status in `Get` handler
Sep 23 2022, 2:07 PM
max closed D5205: [services] Identity - Adding the generated protobuf files.
Sep 23 2022, 2:02 PM
max committed rCOMMf80170b1af8a: [services] Identity - Adding the generated protobuf files (authored by max).
[services] Identity - Adding the generated protobuf files
Sep 23 2022, 2:02 PM
max added a comment to D5175: [services] Tunnelbroker - Update device online status in `Get` handler.
In D5175#153316, @tomek wrote:

I'm still not sure if having this logic in get is the right approach. Added a comment about it in D5174 but accepting this diff because it looks ok

Sep 23 2022, 2:01 PM