Can you add a bit more detail as to what does install and export mean here?
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Nov 27 2022
Nov 22 2022
but wondering: does ANDROID_NDK ever get evaluated as false from the CMakeLists.txts in native/cpp?
@atul , I changed the test plan to include nix develop. I was able to successfully compile the project even with protobuf installed locally with brew.
/Users/atul/comm/native/cpp/CommonCpp/build/grpc/protos/backup.pb.h:17:2: error: This file was generated by an older version of protoc which is
@atul , it's picking up your local protobuf installation.
Nov 21 2022
It' personal preference, generally when dumping a section of text, I think it's easier to read per-line output.
Nov 18 2022
Add back install logic to shared/protos
Nov 17 2022
Rebase on master, quote everything just-in-case
Address feedback
Remove extra "the"
Seems reasonable to me
Nov 16 2022
okay with this as a transition away from C++
I'm okay with this for now. https://phab.comm.dev/D5640#167758 Applies to this as well, but this looks to be moving in the right direction.
I would like to see configuration done in rust, as argument reading + argument validation is a bit nicer using crates like clap. But as a transition, I think this is fine.
Moving diff to https://phab.comm.dev/D5655, as getting git happy + pulling in new changes is odd.
Use relative path
Forgot about the per-workspace differences
Moved to the two separate sections into the main document, and just had it follow installing nix
Unify yarn cleaninstall section in main document
Nov 14 2022
going to refactor the startup logic to a separate script
Fix typo in environment variable
Update native/.ruby-version
Fair enough
Nov 10 2022
going to request another review, the cache misses should be fixed for nix<2.10 in https://phab.comm.dev/D5600
No longer relevant after https://phab.comm.dev/D5508
@atul https://phab.comm.dev/D5600 should fix cache issue. With nix 2.10+, I can't reproduce the issue, but can't be too sure.
@atul, very odd, I didn't have this behavior, it always gave the official nixpkgs binary cache as the default. I'll throw up another diff to add the official repository as a default.
Yeah but bundle exec pod install doesn't work without bundler (which is distinct from the bundle command)
Nov 9 2022
LGTM, but would like to see what tomek thinks
Nov 8 2022
Nov 4 2022
otherwise LGTM
the binary is in the build directory as well if I use just install(TARGETS runTests RUNTIME DESTINATION bin) which must use build/bin directory. But it's not and puts the binary into the build directory.