Page MenuHomePhorge
Feed Search

Nov 27 2022

jon requested review of D5727: [Nix] Package blob.
Nov 27 2022, 5:15 PM

Nov 22 2022

jon added a comment to D5686: [Cmake] Avoid installing targets when used by Android build.

Can you add a bit more detail as to what does install and export mean here?

Nov 22 2022, 7:00 PM
jon added a comment to D5686: [Cmake] Avoid installing targets when used by Android build.

but wondering: does ANDROID_NDK ever get evaluated as false from the CMakeLists.txts in native/cpp?

Nov 22 2022, 6:58 PM
jon requested review of D5686: [Cmake] Avoid installing targets when used by Android build.
Nov 22 2022, 6:51 PM
jon added a comment to D5686: [Cmake] Avoid installing targets when used by Android build.

@atul , I changed the test plan to include nix develop. I was able to successfully compile the project even with protobuf installed locally with brew.

Nov 22 2022, 6:50 PM
jon updated the test plan for D5686: [Cmake] Avoid installing targets when used by Android build.
Nov 22 2022, 6:46 PM
jon added a comment to D5686: [Cmake] Avoid installing targets when used by Android build.
/Users/atul/comm/native/cpp/CommonCpp/build/grpc/protos/backup.pb.h:17:2: error: This file was generated by an older version of protoc which is

@atul , it's picking up your local protobuf installation.

Nov 22 2022, 6:38 PM
jon closed D5699: [Nix] Add whitespace around message fixing glyph support.
Nov 22 2022, 6:25 PM
jon committed rCOMMa7db79a3b4fb: [Nix] Add whitespace around message fixing glyph support.
Nov 22 2022, 6:25 PM

Nov 21 2022

jon added a comment to D5699: [Nix] Add whitespace around message fixing glyph support.

It' personal preference, generally when dumping a section of text, I think it's easier to read per-line output.

Nov 21 2022, 9:08 PM
jon requested review of D5699: [Nix] Add whitespace around message fixing glyph support.
Nov 21 2022, 3:32 PM

Nov 18 2022

jon updated the diff for D5686: [Cmake] Avoid installing targets when used by Android build.

Add back install logic to shared/protos

Nov 18 2022, 10:38 PM
jon requested review of D5686: [Cmake] Avoid installing targets when used by Android build.
Nov 18 2022, 10:32 PM
jon closed D5656: [Nix] Default value of ANDROID_HOME.
Nov 18 2022, 10:10 PM
jon committed rCOMM7413dab98cda: [Nix] Default value of ANDROID_HOME.
Nov 18 2022, 10:10 PM

Nov 17 2022

jon updated the diff for D5656: [Nix] Default value of ANDROID_HOME.

Rebase on master, quote everything just-in-case

Nov 17 2022, 7:55 PM
jon closed D5652: [Nix Docs] Mention yarn cleaninstall and git clone.
Nov 17 2022, 7:45 PM
jon committed rCOMM5c199c8adba2: [Nix Docs] Mention yarn cleaninstall and git clone.
Nov 17 2022, 7:44 PM
jon added inline comments to D5652: [Nix Docs] Mention yarn cleaninstall and git clone.
Nov 17 2022, 7:00 PM
jon updated the diff for D5652: [Nix Docs] Mention yarn cleaninstall and git clone.

Address feedback

Nov 17 2022, 7:00 PM
jon accepted D5487: [services] Tunnelbroker - Adding of gRPC `SessionSignature` implementation.
Nov 17 2022, 6:53 PM
jon closed D5651: [Nix] Add node_modules/.bin to path.
Nov 17 2022, 6:48 PM
jon committed rCOMM661815bbe3c5: [Nix] Add node_modules/.bin to path.
Nov 17 2022, 6:48 PM
jon updated the diff for D5656: [Nix] Default value of ANDROID_HOME.

Remove extra "the"

Nov 17 2022, 6:47 PM
jon accepted D5592: [services] Tunnelbroker - Adding handling of messages to send from the client.

Seems reasonable to me

Nov 17 2022, 5:27 PM

Nov 16 2022

jon requested review of D5656: [Nix] Default value of ANDROID_HOME.
Nov 16 2022, 11:15 PM
jon closed D5655: [Nix Docs] Mention Nix and Android Studio in section about JDK.
Nov 16 2022, 11:13 PM
jon committed rCOMM46242acdc0e2: [Nix Docs] Mention Nix and Android Studio in section about JDK.
Nov 16 2022, 11:13 PM
jon accepted D5639: [services] Tunnelbroker - Expose config to the Rust.

okay with this as a transition away from C++

Nov 16 2022, 10:56 PM
jon added inline comments to D5642: [services] Tunnelbroker - Updating notifications libraries with the config.
Nov 16 2022, 10:56 PM
jon accepted D5641: [services] Tunnelbroker - Notifications config initialization.

I'm okay with this for now. https://phab.comm.dev/D5640#167758 Applies to this as well, but this looks to be moving in the right direction.

Nov 16 2022, 10:51 PM
jon accepted D5640: [services] Tunnelbroker - Expose `isSandbox` to the Rust.

I would like to see configuration done in rust, as argument reading + argument validation is a bit nicer using crates like clap. But as a transition, I think this is fine.

Nov 16 2022, 10:50 PM
jon abandoned D5544: [Nix Docs] Add section about JDK for Android Studio.

Moving diff to https://phab.comm.dev/D5655, as getting git happy + pulling in new changes is odd.

Nov 16 2022, 10:45 PM
jon updated the test plan for D5651: [Nix] Add node_modules/.bin to path.
Nov 16 2022, 10:34 PM
jon updated the diff for D5651: [Nix] Add node_modules/.bin to path.

Use relative path

Nov 16 2022, 10:34 PM
jon added a comment to D5651: [Nix] Add node_modules/.bin to path.

Forgot about the per-workspace differences

Nov 16 2022, 10:32 PM
jon added a comment to D5652: [Nix Docs] Mention yarn cleaninstall and git clone.

Moved to the two separate sections into the main document, and just had it follow installing nix

Nov 16 2022, 10:31 PM
jon updated the diff for D5652: [Nix Docs] Mention yarn cleaninstall and git clone.

Unify yarn cleaninstall section in main document

Nov 16 2022, 10:31 PM
jon requested review of D5652: [Nix Docs] Mention yarn cleaninstall and git clone.
Nov 16 2022, 5:48 PM

Nov 14 2022

jon planned changes to D4948: [Nix] Add rabbitmq-up command.

going to refactor the startup logic to a separate script

Nov 14 2022, 3:43 PM
jon updated the diff for D4948: [Nix] Add rabbitmq-up command.

Fix typo in environment variable

Nov 14 2022, 3:19 PM
jon closed D5565: [Nix] Add bundler for pod install.
Nov 14 2022, 2:49 PM
jon committed rCOMMa6f8a2305759: [Nix] Add bundler for pod install.
Nov 14 2022, 2:49 PM
jon updated the diff for D5565: [Nix] Add bundler for pod install.

Update native/.ruby-version

Nov 14 2022, 2:42 PM
jon added inline comments to D5565: [Nix] Add bundler for pod install.
Nov 14 2022, 2:41 PM
jon abandoned D5602: [Nix Docs] Add steps for updating nixpkgs and pushing to cache.

Moved to https://www.notion.so/commapp/Updating-flake-and-binary-cache-81d84682824f4b458186ab5b24bebada

Nov 14 2022, 2:36 PM
jon added a comment to D5602: [Nix Docs] Add steps for updating nixpkgs and pushing to cache.

Fair enough

Nov 14 2022, 2:34 PM

Nov 10 2022

jon closed D5563: [Nix] Bump JDK to JDK11.
Nov 10 2022, 9:06 PM
jon committed rCOMM19cfd9fa5da5: [Nix] Bump JDK to JDK11.
Nov 10 2022, 9:06 PM
jon closed D5600: [Nix] Add nixos cache as default for install_nix.sh.
Nov 10 2022, 9:04 PM
jon committed rCOMMc07d197d3916: [Nix] Add nixos cache as default for install_nix.sh.
Nov 10 2022, 9:04 PM
jon requested review of D5602: [Nix Docs] Add steps for updating nixpkgs and pushing to cache.
Nov 10 2022, 7:11 PM
jon requested review of D5563: [Nix] Bump JDK to JDK11.

going to request another review, the cache misses should be fixed for nix<2.10 in https://phab.comm.dev/D5600

Nov 10 2022, 6:41 PM
jon abandoned D5338: [Services] Force c++17 usage with cxx builds.

No longer relevant after https://phab.comm.dev/D5508

Nov 10 2022, 6:30 PM
jon requested review of D5600: [Nix] Add nixos cache as default for install_nix.sh.
Nov 10 2022, 6:30 PM
jon added a comment to D5563: [Nix] Bump JDK to JDK11.

@atul https://phab.comm.dev/D5600 should fix cache issue. With nix 2.10+, I can't reproduce the issue, but can't be too sure.

Nov 10 2022, 6:20 PM
jon requested review of D5544: [Nix Docs] Add section about JDK for Android Studio.
Nov 10 2022, 6:08 PM
jon added a comment to D5563: [Nix] Bump JDK to JDK11.

@atul, very odd, I didn't have this behavior, it always gave the official nixpkgs binary cache as the default. I'll throw up another diff to add the official repository as a default.

Nov 10 2022, 5:52 PM
jon added inline comments to D5563: [Nix] Bump JDK to JDK11.
Nov 10 2022, 5:48 PM
jon requested review of D5565: [Nix] Add bundler for pod install.
Nov 10 2022, 5:46 PM
jon added a comment to D5565: [Nix] Add bundler for pod install.

Yeah but bundle exec pod install doesn't work without bundler (which is distinct from the bundle command)

Nov 10 2022, 5:45 PM
jon closed D5562: [Nix] Remove flakeConfig for cache.
Nov 10 2022, 5:38 PM
jon committed rCOMM14088b6a8a36: [Nix] Remove flakeConfig for cache.
Nov 10 2022, 5:38 PM
jon closed D5561: [Nix] Install comm cache in nix.conf.
Nov 10 2022, 5:38 PM
jon committed rCOMMc2393bbcca66: [Nix] Install comm cache in nix.conf.
Nov 10 2022, 5:38 PM

Nov 9 2022

jon accepted D5573: [services][identity] update get_pake_registration method to use helper.
Nov 9 2022, 7:15 PM
jon accepted D5572: [services][identity] helper function to get item from users table.
Nov 9 2022, 7:15 PM
jon added a comment to D5570: [services][identity] implement get_user_public_key service method.

LGTM, but would like to see what tomek thinks

Nov 9 2022, 7:15 PM
jon added inline comments to D5569: [services][identity] db client method to get user public key.
Nov 9 2022, 7:13 PM
jon accepted D5568: [services][identity] helper function to parse map attributes from dynamodb.
Nov 9 2022, 7:07 PM
jon accepted D5584: [services] Tunnelbroker - Removing processed messages.
Nov 9 2022, 7:05 PM
jon accepted D5580: [services] Tunnelbroker - Adding delivering messages from the deliveryBroker to the messages stream.
Nov 9 2022, 7:04 PM
jon accepted D5540: [services] Tunnelbroker - Adding delivering of undelivered messages from the database to the messages stream.
Nov 9 2022, 7:03 PM
jon accepted D5536: [services] Tunnelbroker - Adding of requesting a new notification token if empty.
Nov 9 2022, 7:02 PM
jon accepted D5534: [services] Tunnelbroker - Adding of handling of the `NewNotifyToken` message.
Nov 9 2022, 7:02 PM

Nov 8 2022

jon requested review of D5562: [Nix] Remove flakeConfig for cache.
Nov 8 2022, 6:55 PM
jon requested review of D5565: [Nix] Add bundler for pod install.
Nov 8 2022, 6:50 PM
jon requested review of D5563: [Nix] Bump JDK to JDK11.
Nov 8 2022, 6:28 PM
jon requested review of D5561: [Nix] Install comm cache in nix.conf.
Nov 8 2022, 6:15 PM

Nov 4 2022

jon added inline comments to D5536: [services] Tunnelbroker - Adding of requesting a new notification token if empty.
Nov 4 2022, 6:05 PM
jon requested changes to D5534: [services] Tunnelbroker - Adding of handling of the `NewNotifyToken` message.

otherwise LGTM

Nov 4 2022, 6:02 PM
jon accepted D5529: [services] Tunnelbroker - Adding the pinging loop and online status of the client check.
Nov 4 2022, 6:00 PM
jon accepted D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata.
Nov 4 2022, 5:59 PM
jon accepted D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
Nov 4 2022, 5:57 PM
jon added a comment to D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.

the binary is in the build directory as well if I use just install(TARGETS runTests RUNTIME DESTINATION bin) which must use build/bin directory. But it's not and puts the binary into the build directory.

Nov 4 2022, 5:57 PM
jon accepted D5535: [services] Tunnelbroker - Removing of emptiness check for notification token.
Nov 4 2022, 5:55 PM

Nov 3 2022

jon accepted D5526: [services] Tunnelbroker - Adding of `constants.rs` file.
Nov 3 2022, 5:04 PM
jon accepted D5527: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo.
Nov 3 2022, 5:03 PM
jon added inline comments to D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata.
Nov 3 2022, 5:03 PM
jon added inline comments to D5529: [services] Tunnelbroker - Adding the pinging loop and online status of the client check.
Nov 3 2022, 4:55 PM
jon added inline comments to D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
Nov 3 2022, 4:50 PM
jon closed D5479: [iOS] Support Nix iOS dev shell.
Nov 3 2022, 4:46 PM
jon closed D5509: [Nix] Move to rustup supplied tooling.
Nov 3 2022, 4:46 PM
jon committed rCOMMb3d927bea242: [Nix] Move to rustup supplied tooling.
Nov 3 2022, 4:46 PM
jon committed rCOMMabd3fb3dbd32: [iOS] Support Nix iOS dev shell.
Nov 3 2022, 4:46 PM
jon closed D5508: [iOS] Fix pod install and react-native with nix env.
Nov 3 2022, 4:46 PM
jon closed D5488: [Nix] Fix whitespace quoting for path.
Nov 3 2022, 4:46 PM
jon committed rCOMM4c40865824a4: [iOS] Fix pod install and react-native with nix env.
Nov 3 2022, 4:46 PM
jon committed rCOMM9fee06a231c0: [Nix] Fix whitespace quoting for path.
Nov 3 2022, 4:46 PM
jon accepted D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.
Nov 3 2022, 4:45 PM