Apply rename to new code from previous diff feedback
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 18 2023
Aug 17 2023
Rebase on master
Rebase on master
Rebase on master
Rebase on master
Rebase on master
Rebase on master
Remove now unused import
Rebase on changes to previous diffs
Apply suggestions
Include MacOS
CMake changes look good to me
Apply feedback
Address Kamil's feedback
Combine imports
Use userID when able to
Capitalize Keyserver and Tunnelbroker in comments
Add comments in keyserver.js
Address feedback
Address feedback
Re-introduce comment which was accidentally deleted due to bad rebase
Address comments, refactor one time key addtions to single method
Address feedback on docker COPY command
Aug 16 2023
Address feedback
Aug 15 2023
Fix some missed comments
Missed some comments
Missed a comment
Address feedback
Re-apply feedback which was lost during bad arc patch
uggh, not sure why, but I got a stale patch when doing the one-time refactor
Accepting to not block progress.
Propagate onetime -> one-time changes
"onetime" -> "one-time" for this diff
Aug 14 2023
Aug 11 2023
Aug 10 2023
we can move the expansion of commapp_url details to another diff, as ashoat mentioned
Aug 9 2023
Rebase on changes
Revert back to using initial "read all" logic
In D8675#259065, @varun wrote:sorry I didn't catch this earlier but we should be consistent about onetime vs one-time/oneTime/OneTime/one_time. the latter matches the white paper, so we should remove all uses of the former. i noted a couple instances where we're using the wrong format inline, but it's not an exhaustive list. some other comments inline too.
also, we have to update the add_user_to_users_table function, right?
Address feedback
Aug 8 2023
We need to make sure that the identity service has the codeVersion of the client. When we launch the device list work, the identity service will need to be able to identify whether a given client is able to support the "new" workflow and function as a primary device. This is just one example of many... it's critical that Comm services are aware of the client version
Chunkify other BatchWriteItem
Address feedback
I landed D8627, please rebase
makes sense to me
Aug 7 2023
need to do a another async/await pass, and hit on commentary
Rebase on master