rebase before landing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Nov 13 2023
Nov 13 2023
rebase before landing
update after syncing with @inka
fix
update after syncing with @inka
rebase before landing
rebase before landing
Nov 10 2023
Nov 10 2023
ginsu published D9830: [native] introduce functionality for onPressRemoveKeyserver callback for review.
ginsu requested review of D9829: [lib] introduce removeKeyserverActionType condition to keyserver reducer.
ginsu requested review of D9826: [lib/native] extend keyserverAdminUsername to be keyserverAdminUserInfo.
Nov 9 2023
Nov 9 2023
forgot to hit save on my editor
Is 50 / 60 / 70 / 80 / 90 actually arithmetically accurate? I have a suspicion it's not. If we actually took real mathematic percentages of pure black, what would it really be?
rebase one more time (forgot to pull from master first)
ginsu updated the diff for D9726: [native] introduce barebones keyserver selection bottom sheet to root navigator.
rebase one more time (forgot to pull from master first)
rebase before landing
ginsu updated the diff for D9726: [native] introduce barebones keyserver selection bottom sheet to root navigator.
rebase before landing
ginsu added inline comments to D9795: [native] calculate snap points for keyserver selection bottomsheet.
I'm wondering if this will result in flickering screen considering how often the disconnected bar appears / disappears on prod. Do you have any way of testing this?
ginsu added inline comments to D9726: [native] introduce barebones keyserver selection bottom sheet to root navigator.
It seems like "90" and "80" are super close. Are you sure we need this new color? Can you explain / justify its introduction a bit more?
fix logout action
ginsu published D9795: [native] calculate snap points for keyserver selection bottomsheet for review.
update after @inka's recently landed diffs
update after @inka's recently landed diffs
Nov 8 2023
Nov 8 2023
ginsu published D9791: [native] update drawerOpenCommunityBackground color with panelBackgroundAccent for review.
address comments
ginsu accepted D9776: [Flow202][web][skip-ci] [10/x] Fix nonsensical use of selectors in ThreadPickerModal.
thanks for fixing this
Nov 7 2023
Nov 7 2023
ginsu requested review of D9726: [native] introduce barebones keyserver selection bottom sheet to root navigator.
Ran into a bug later in the stack with reading some of the route params, and thought the issue was with this diff, but it was actually with something else
rebase before landing
ginsu updated the diff for D9724: [native] update Keyserver selection => to be Keyservers in profile settings.
rebase before landing
Nov 6 2023
Nov 6 2023
ginsu requested review of D9724: [native] update Keyserver selection => to be Keyservers in profile settings.
rebase before landing
Nov 3 2023
Nov 3 2023
Nov 2 2023
Nov 2 2023
accepting but let's return null instead of using an invariant
address comments + rebase before landing
address comments + rebase before landing