- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 6 2022
replace spread with Array.from & rebase before landing
rebase
May 4 2022
As far as I remember, all modals before D3669 (the smaller and the larger ones) had the max-height set to 500px, so when redesigning I didn't want to change this size.
I'm open to removing this height limit, but please make sure it doesn't break existing modals.
Apr 29 2022
rebase
rebase
rebase
rebase
rebase
rebase
rebase
Move canAddMembers outside the useMemo.
Apr 27 2022
rebase
Simplify memo & rebase
rebase
rebase
rebase
rebase
replace background-color with background & rebase
Apr 26 2022
revert accidental change after rebase
removed redundant min-height
rebase
rebase
rebase
rebase
rebase
rebase
rebase
In D3836#106509, @ashoat wrote:Are there any other modals that need this update? Adding @atul as a blocking reviewer to make sure he sees this as he's been cleaning up some modals recently
rebase
In D3854#106911, @palys-swm wrote:Could you maybe search the whole codebase and check if we're using overflow: scroll anywhere?
changed type
change overflow from scroll to auto
I'm wondering if, instead of creating separate SidebarPromoteModal component, shouldn't we use existing logic already implemented in ConfirmLeaveThreadModal and create universal ConfirmModal component, that can receive e.g. title, message (content), and confirm action name? I think, there are quite many places, where something like this could be used in web app. What do you think?
Apr 25 2022
rebase
rebase
rebase