Page MenuHomePhorge
Feed Search

Apr 28 2023

jon added inline comments to D7671: [Identity] Use content to describe main olm account.
Apr 28 2023, 10:24 PM
jon updated the diff for D7671: [Identity] Use content to describe main olm account.

Clarify content vs identity in some instances

Apr 28 2023, 8:43 PM
jon updated the diff for D7671: [Identity] Use content to describe main olm account.

Address feedback

Apr 28 2023, 5:46 PM

Apr 27 2023

jon closed D7610: [Tunnelbroker] Add initial websocket connection support and connection map.
Apr 27 2023, 3:59 PM
jon committed rCOMMd51b1f099fd1: [Tunnelbroker] Add initial websocket connection support and connection map.
Apr 27 2023, 3:59 PM
jon updated the summary of D7661: [Tunnelbroker] Add integration tests.
Apr 27 2023, 3:55 PM
jon requested review of D7671: [Identity] Use content to describe main olm account.
Apr 27 2023, 3:51 PM
jon accepted D7634: [web] Ignore opaque-ke WASM modules in .flowconfig.
Apr 27 2023, 2:43 PM
jon requested review of D7661: [Tunnelbroker] Add integration tests.
Apr 27 2023, 2:40 PM
jon requested review of D7659: [Tunnelbroker] Remove references to cxx.
Apr 27 2023, 2:24 PM
jon added inline comments to D7610: [Tunnelbroker] Add initial websocket connection support and connection map.
Apr 27 2023, 2:08 PM
jon updated the diff for D7610: [Tunnelbroker] Add initial websocket connection support and connection map.

Use only major.minor for versions.

Apr 27 2023, 2:01 PM

Apr 26 2023

jon closed D7580: [Identity] Rename key request RPCs to reflect Olm terms.
Apr 26 2023, 4:35 PM
jon committed rCOMM060ebb3b65fe: [Identity] Rename key request RPCs to reflect Olm terms.
Apr 26 2023, 4:35 PM

Apr 25 2023

jon updated the diff for D7580: [Identity] Rename key request RPCs to reflect Olm terms.

Rebase on master, again

Apr 25 2023, 7:17 PM
jon requested review of D7610: [Tunnelbroker] Add initial websocket connection support and connection map.
Apr 25 2023, 4:15 PM

Apr 24 2023

jon requested review of D7580: [Identity] Rename key request RPCs to reflect Olm terms.
Apr 24 2023, 10:49 PM
jon accepted D7540: [identity] wallet login.
Apr 24 2023, 10:25 PM
jon accepted D7596: [identity] some nits.
Apr 24 2023, 10:23 PM
jon accepted D7595: [identity] use ed25519 key instead of curve as map key.
Apr 24 2023, 10:22 PM
jon accepted D7594: [identity] verify user access token.
Apr 24 2023, 10:21 PM
jon accepted D7539: [identity] finish login.
Apr 24 2023, 8:25 PM
jon requested changes to D7540: [identity] wallet login.
Apr 24 2023, 8:24 PM
jon accepted D7544: [identity] delete user RPC.
Apr 24 2023, 8:08 PM
jon accepted D7538: [identity] login start.

I'm not sure the best path forward for handling the dynamodb logic, but in time I'm sure we will become more clear.

Apr 24 2023, 8:08 PM
jon accepted D7553: [identity] update user password.
Apr 24 2023, 7:42 PM
jon accepted D7483: [services][blob] Add upload blob HTTP handler.
Apr 24 2023, 7:41 PM
jon added inline comments to D7538: [identity] login start.
Apr 24 2023, 7:38 PM

Apr 20 2023

jon added inline comments to D7538: [identity] login start.
Apr 20 2023, 9:57 PM
jon accepted D7533: [identity] register start.
Apr 20 2023, 9:54 PM
jon accepted D7532: [identity] get reserved usernames from JSON.
Apr 20 2023, 9:53 PM
jon requested changes to D7538: [identity] login start.
Apr 20 2023, 6:51 PM
jon accepted D7531: [identity] db method to check if username is taken.
Apr 20 2023, 6:37 PM
jon accepted D7552: Remove reference to pod-patch in .dockerignore.
Apr 20 2023, 6:37 PM
jon accepted D7536: [identity] manage login state.

Nevermind, the struct is used to also hold the login state later on.

Apr 20 2023, 5:59 PM
jon accepted D7537: [identity] return user ID on login.
Apr 20 2023, 5:56 PM
jon requested changes to D7536: [identity] manage login state.
Apr 20 2023, 5:55 PM
jon accepted D7535: [identity] fix numbering issues in proto file.
Apr 20 2023, 5:53 PM
jon accepted D7534: [identity] register user finish.

Rust looks fine to me

Apr 20 2023, 5:53 PM
jon requested changes to D7533: [identity] register start.
Apr 20 2023, 5:49 PM
jon requested changes to D7532: [identity] get reserved usernames from JSON.
Apr 20 2023, 5:39 PM

Apr 19 2023

jon closed D7526: [Tunnelbroker] Use more consistent renaming.
Apr 19 2023, 6:15 PM
jon committed rCOMM370e4254e08c: [Tunnelbroker] Use more consistent renaming.
Apr 19 2023, 6:15 PM
jon requested review of D7526: [Tunnelbroker] Use more consistent renaming.
Apr 19 2023, 5:48 PM
jon closed D7480: [Tunnelbroker] Create session creation and key messages.
Apr 19 2023, 5:25 PM
jon committed rCOMMbb6772194b9a: [Tunnelbroker] Create session creation and key messages.
Apr 19 2023, 5:25 PM

Apr 18 2023

jon closed D7431: [Tunnelbroker] Use new services protobuf.
Apr 18 2023, 5:09 PM
jon committed rCOMM80e076925b3c: [Tunnelbroker] Use new services protobuf.
Apr 18 2023, 5:09 PM
jon closed D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.
Apr 18 2023, 5:09 PM
jon committed rCOMMf6854fa59b22: [Tunnelbroker] Create gRPC service for emitting messages to devices.
Apr 18 2023, 5:09 PM
jon closed D7479: [Protos] Remove tunnelbroker.proto.
Apr 18 2023, 5:09 PM
jon committed rCOMM524c1ee3c64c: [Protos] Remove tunnelbroker.proto.
Apr 18 2023, 5:09 PM
jon accepted D7465: [services][blob] Implement Get blob HTTP handler.
Apr 18 2023, 5:08 PM
jon requested changes to D7483: [services][blob] Add upload blob HTTP handler.

Might be nice to factor out all of the failable s3 code, which returns an s3 error, then we can just assert the error once from the calling code.

Apr 18 2023, 5:07 PM
jon accepted D7482: [services][blob] Add assign holder HTTP endpoint.
Apr 18 2023, 4:44 PM
jon updated the diff for D7431: [Tunnelbroker] Use new services protobuf.

Rebase on latest master

Apr 18 2023, 4:42 PM
jon updated the diff for D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.

Rebase on latest master

Apr 18 2023, 4:42 PM
jon updated the diff for D7479: [Protos] Remove tunnelbroker.proto.

Rebase on latest master

Apr 18 2023, 4:41 PM
jon updated the diff for D7431: [Tunnelbroker] Use new services protobuf.

identity -> grpc

Apr 18 2023, 3:40 PM
jon accepted D7441: [services][blob] Add http_port config option.
Apr 18 2023, 3:19 PM
jon added inline comments to D7466: [services][blob] Implement Delete blob HTTP handler.
Apr 18 2023, 3:19 PM
jon requested review of D7480: [Tunnelbroker] Create session creation and key messages.
Apr 18 2023, 3:16 PM
jon requested changes to D7465: [services][blob] Implement Get blob HTTP handler.
Apr 18 2023, 3:13 PM
jon accepted D7464: [services][blob] Introduce HTTP context utils.
Apr 18 2023, 3:06 PM
jon updated the diff for D7431: [Tunnelbroker] Use new services protobuf.

Remove usage of "Comm"

Apr 18 2023, 2:58 PM
jon added a comment to D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.

This was rebased on top of deleting the old tunnelbroker.proto. Which is why I had it as something else originally.

Apr 18 2023, 2:53 PM
jon updated the diff for D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.

Address feedback

Apr 18 2023, 2:52 PM
jon updated the diff for D7431: [Tunnelbroker] Use new services protobuf.

Rebase on changes

Apr 18 2023, 1:49 AM
jon requested review of D7479: [Protos] Remove tunnelbroker.proto.
Apr 18 2023, 12:39 AM
jon added inline comments to D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.
Apr 18 2023, 12:36 AM
jon updated the diff for D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.

Fixup comment

Apr 18 2023, 12:34 AM
jon retitled D7431: [Tunnelbroker] Use new services protobuf from [Tunnelbroker] Use identity protobuf
Apr 18 2023, 12:30 AM
jon updated the diff for D7431: [Tunnelbroker] Use new services protobuf.

Use service agnostic protobuf

Apr 18 2023, 12:30 AM
jon updated the diff for D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.

Rename protobuf file

Apr 18 2023, 12:29 AM
jon retitled D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices from [Identity/Tunnelbroker] Create refresh user keys protobuf RPC
Apr 18 2023, 12:16 AM
jon updated the diff for D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.

Make service-agnostic

Apr 18 2023, 12:16 AM

Apr 14 2023

jon requested review of D7431: [Tunnelbroker] Use new services protobuf.
Apr 14 2023, 8:50 PM
jon closed D7436: [Native] Remove tunnelbroker grpc code from native library.
Apr 14 2023, 5:52 PM
jon committed rCOMM867a36ca0016: [Native] Remove tunnelbroker grpc code from native library.
Apr 14 2023, 5:52 PM
jon resigned from D7450: [native][codegen] Generate CommUtilsModule C++ spec.

CMake looks fine to me, defer to others for the rest

Apr 14 2023, 5:51 PM
jon accepted D7442: [services][blob] Extract BlobItem creation.
Apr 14 2023, 4:24 PM
jon requested changes to D7441: [services][blob] Add http_port config option.
Apr 14 2023, 4:20 PM
jon accepted D7440: [services][blob] Rename gRPC module.
Apr 14 2023, 4:10 PM
jon added a comment to D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.

Shouldn't matter if the message is opaque to the Tunnelbroker service

Apr 14 2023, 2:31 PM
jon requested review of D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.

If we ever need some other internal service to send a message via Tunnelbroker, we won't need to update the .proto

Apr 14 2023, 2:23 PM
jon requested changes to D7450: [native][codegen] Generate CommUtilsModule C++ spec.
Apr 14 2023, 1:38 PM
jon requested review of D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.
Apr 14 2023, 1:34 PM
jon added a comment to D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.

Decision to create a separate service specifically for service A to talk to service B, versus just a unified service definition for service B

Apr 14 2023, 1:33 PM

Apr 13 2023

jon requested review of D7436: [Native] Remove tunnelbroker grpc code from native library.
Apr 13 2023, 9:50 PM
jon closed D7432: [Treewide] Update h2 crate.
Apr 13 2023, 9:28 PM
jon committed rCOMM4d82450c3188: [Treewide] Update h2 crate.
Apr 13 2023, 9:28 PM
jon requested review of D7425: [Tunnelbroker] Create gRPC service for emitting messages to devices.
Apr 13 2023, 5:08 PM
jon closed D7405: [Keyserver/rust-node-addon] Remove tunnelbroker grpc client.
Apr 13 2023, 3:58 PM
jon committed rCOMM34d11786c934: [Keyserver/rust-node-addon] Remove tunnelbroker grpc client.
Apr 13 2023, 3:58 PM

Apr 12 2023

jon requested review of D7405: [Keyserver/rust-node-addon] Remove tunnelbroker grpc client.
Apr 12 2023, 10:04 PM
jon closed D7400: [Tunnelbroker] Add message types for existing protobuf messages.
Apr 12 2023, 7:46 PM
jon closed D7392: [Tunnelbroker] Create websocket server.
Apr 12 2023, 7:46 PM
jon committed rCOMM54acb86ee883: [Tunnelbroker] Add message types for existing protobuf messages.
Apr 12 2023, 7:46 PM
jon committed rCOMM6b6fa484ea82: [Tunnelbroker] Create websocket server.
Apr 12 2023, 7:46 PM
jon closed D7391: [Tunnelbroker] Update example tunnelbroker.ini.
Apr 12 2023, 7:46 PM