Page MenuHomePhorge
Feed Search

Apr 23 2023

atul added inline comments to D7578: [native] Fix Android CI.
Apr 23 2023, 1:52 AM
atul accepted D7579: [native] Delete broken Android custom font symlinks.

Wonder if older versions of Android may fallback to font?

Apr 23 2023, 1:15 AM
atul accepted D7578: [native] Fix Android CI.
Apr 23 2023, 1:13 AM
atul added a reverting change for rCOMMbca8fec213cb: [native] Temporary changes for staff release: rCOMM09343139a02d: Revert "[native] Temporary changes for staff release".
Apr 23 2023, 12:52 AM
atul committed rCOMM09343139a02d: Revert "[native] Temporary changes for staff release".
Apr 23 2023, 12:52 AM
atul committed rCOMM8b1c8e96a25a: [native] `codeVersion` -> 210.
Apr 23 2023, 12:52 AM
atul committed rCOMMbca8fec213cb: [native] Temporary changes for staff release.
Apr 23 2023, 12:52 AM
atul committed rCOMM19110a5eb5a5: [native] `codeVersion` -> 209.
Apr 23 2023, 12:52 AM

Apr 21 2023

atul accepted D7574: [native] Prevent media cache errors from crashing app.
Apr 21 2023, 9:33 PM
atul attached a referenced file: F501506: 02ede4.png.
Apr 21 2023, 9:19 PM
atul added inline comments to D7568: Implement fetcher and updater for olm accounts on the keyserver.
Apr 21 2023, 9:19 PM

Apr 20 2023

atul added a comment to D7551: [DRAFT][native] Introduce `persistMigrationForThreadAvatarPermission` to update thread permissions.

While the changes in edit-thread-avatar-permission need to be revisited, the code in persist.js is solid (shoutout @rohan who wrote it).

Apr 20 2023, 6:29 PM
atul added a comment to D7551: [DRAFT][native] Introduce `persistMigrationForThreadAvatarPermission` to update thread permissions.

Okay well as a starting point trying the migration with my already correct threadStore led to some inconsistencies...

Apr 20 2023, 7:16 AM
atul attached a referenced file: F498058: 58a7a3.png.
Apr 20 2023, 5:59 AM
atul attached a referenced file: F498065: b034ef.png.
Apr 20 2023, 5:59 AM
atul updated subscribers of D7551: [DRAFT][native] Introduce `persistMigrationForThreadAvatarPermission` to update thread permissions.
Apr 20 2023, 5:59 AM
atul requested review of D7551: [DRAFT][native] Introduce `persistMigrationForThreadAvatarPermission` to update thread permissions.
Apr 20 2023, 5:39 AM
atul closed D7547: [native] Match changes made to `EditUserAvatar` for `EditThreadAvatar`.
Apr 20 2023, 3:29 AM
atul committed rCOMM61eb0e026466: [native] Match changes made to `EditUserAvatar` for `EditThreadAvatar`.
Apr 20 2023, 3:29 AM
atul updated the diff for D7547: [native] Match changes made to `EditUserAvatar` for `EditThreadAvatar`.

address feedback before landing

Apr 20 2023, 3:14 AM
atul added inline comments to D7547: [native] Match changes made to `EditUserAvatar` for `EditThreadAvatar`.
Apr 20 2023, 1:18 AM

Apr 19 2023

atul updated the summary of D7547: [native] Match changes made to `EditUserAvatar` for `EditThreadAvatar`.
Apr 19 2023, 11:48 PM
atul published D7547: [native] Match changes made to `EditUserAvatar` for `EditThreadAvatar` for review.
Apr 19 2023, 11:46 PM
atul added a comment to D7543: [native] Alert user when `UPDATE_USER_AVATAR` call fails.

The Android build was consistently failing here… any cause for concern?

Apr 19 2023, 11:45 PM
atul closed D7543: [native] Alert user when `UPDATE_USER_AVATAR` call fails.
Apr 19 2023, 11:08 PM
atul committed rCOMM040694b61c0b: [native] Alert user when `UPDATE_USER_AVATAR` call fails.
Apr 19 2023, 11:08 PM
atul updated the diff for D7543: [native] Alert user when `UPDATE_USER_AVATAR` call fails.

rebase and land

Apr 19 2023, 11:07 PM
atul closed D7545: [native] Pass `customKeyName` to `dispatchActionPromise` in `selectFromGalleryAndUpdateThreadAvatar`.
Apr 19 2023, 10:36 PM
atul committed rCOMM13ec87f8d8d1: [native] Pass `customKeyName` to `dispatchActionPromise` in….
Apr 19 2023, 10:36 PM
atul updated the diff for D7545: [native] Pass `customKeyName` to `dispatchActionPromise` in `selectFromGalleryAndUpdateThreadAvatar`.

rebase and land

Apr 19 2023, 10:36 PM
atul updated the diff for D7543: [native] Alert user when `UPDATE_USER_AVATAR` call fails.

fix..

Apr 19 2023, 10:33 PM
atul requested review of D7543: [native] Alert user when `UPDATE_USER_AVATAR` call fails.

Oh no shit it wasn't updating the image.... I'm awaiting without returning smh

Apr 19 2023, 10:32 PM
atul planned changes to D7543: [native] Alert user when `UPDATE_USER_AVATAR` call fails.
Apr 19 2023, 10:31 PM
atul added a comment to D7543: [native] Alert user when `UPDATE_USER_AVATAR` call fails.

I have no idea why, but it looks like this diff is breaking things..

Apr 19 2023, 10:29 PM
atul published D7545: [native] Pass `customKeyName` to `dispatchActionPromise` in `selectFromGalleryAndUpdateThreadAvatar` for review.
Apr 19 2023, 10:11 PM
atul closed D7542: [native] Fix error check condition.
Apr 19 2023, 9:06 PM
atul committed rCOMM4fdefafb4868: [native] Fix error check condition.
Apr 19 2023, 9:06 PM
atul updated the diff for D7542: [native] Fix error check condition.

rebase and land

Apr 19 2023, 9:06 PM
atul published D7543: [native] Alert user when `UPDATE_USER_AVATAR` call fails for review.
Apr 19 2023, 9:05 PM
atul published D7542: [native] Fix error check condition for review.
Apr 19 2023, 8:54 PM
atul closed D7530: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar`.
Apr 19 2023, 7:39 PM
atul committed rCOMM82a7ceda75f8: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar`.
Apr 19 2023, 7:39 PM
atul updated the diff for D7530: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar`.

address feedback (human readable alert titles)

Apr 19 2023, 7:34 PM
atul closed D7529: [native] Show `ActivityIndicator` in `EditUserAvatar` during update.
Apr 19 2023, 7:28 PM
atul closed D7528: [native] Update `useRemoveUserAvatar` to return `isLoading`.
Apr 19 2023, 7:28 PM
atul committed rCOMM4fda6f042654: [native] Show `ActivityIndicator` in `EditUserAvatar` during update.
Apr 19 2023, 7:28 PM
atul committed rCOMMd21240a7692b: [native] Update `useRemoveUserAvatar` to return `isLoading`.
Apr 19 2023, 7:28 PM
atul closed D7527: [native] Update `useSelectFromGalleryAndUpdateUserAvatar` to return `isLoading`.
Apr 19 2023, 7:28 PM
atul committed rCOMM4d3ff6bec4bb: [native] Update `useSelectFromGalleryAndUpdateUserAvatar` to return `isLoading`.
Apr 19 2023, 7:28 PM
atul added a comment to D7530: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar`.

Can we replace the ALERT_TITLES with "Alert title", to make them more human-readable?

Apr 19 2023, 7:26 PM
atul updated the summary of D7530: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar`.
Apr 19 2023, 7:06 PM
atul updated the summary of D7530: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar`.
Apr 19 2023, 7:06 PM
atul updated the summary of D7530: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar`.
Apr 19 2023, 7:05 PM
atul updated the summary of D7530: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar`.
Apr 19 2023, 7:05 PM
atul updated the summary of D7530: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar`.
Apr 19 2023, 7:04 PM
atul published D7530: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar` for review.
Apr 19 2023, 7:04 PM
atul published D7529: [native] Show `ActivityIndicator` in `EditUserAvatar` during update for review.
Apr 19 2023, 6:48 PM
atul published D7528: [native] Update `useRemoveUserAvatar` to return `isLoading` for review.
Apr 19 2023, 6:31 PM
atul added a comment to D7527: [native] Update `useSelectFromGalleryAndUpdateUserAvatar` to return `isLoading`.

Wouldn't it be more simple / readable to handle this at the callsite for selectFromGalleryAndUpdateUserAvatar? Eg. like this:

const [userAvatarUpdateInProgress, setUserAvatarUpdateInProgress] = React.useState(false);
const updateCallback = React.useCallback(async () => {
  setUserAvatarUpdateInProgress(true);
  try {
    const result = await selectFromGalleryAndUpdateUserAvatar(params);
  } finally {
    setUserAvatarUpdateInProgress(false);
  }
}. [selectFromGalleryAndUpdateUserAvatar, params]);

It will lead to a little bit of copy-paste, but might be worth it for the improved readability / simplicity. What do you think?

Apr 19 2023, 6:22 PM
atul published D7527: [native] Update `useSelectFromGalleryAndUpdateUserAvatar` to return `isLoading` for review.
Apr 19 2023, 6:00 PM
atul accepted D7515: [native] Use CommUtilsModule for encrypted media.
Apr 19 2023, 4:45 PM
atul accepted D7501: [native] Introduce RegistrationContainer.
Apr 19 2023, 4:44 PM
atul accepted D7500: [native] Style RegistrationNavigator header.
Apr 19 2023, 4:44 PM
atul accepted D7496: [native] Add empty RegistrationNavigator & KeyserverSelection.
Apr 19 2023, 4:40 PM
atul closed D7513: [native] Introduce `useRemoveThreadAvatar` hook.
Apr 19 2023, 4:29 PM
atul committed rCOMM7e902a758592: [native] Introduce `useRemoveThreadAvatar` hook.
Apr 19 2023, 4:28 PM
atul closed D7512: [native] Introduce `useRemoveUserAvatar` hook.
Apr 19 2023, 4:28 PM
atul closed D7511: [native] Introduce naive `useSelectFromGalleryAndUpdateThreadAvatar` hook.
Apr 19 2023, 4:28 PM
atul committed rCOMM683fb7914ed5: [native] Introduce `useRemoveUserAvatar` hook.
Apr 19 2023, 4:28 PM
atul committed rCOMMa6e4615a5521: [native] Introduce naive `useSelectFromGalleryAndUpdateThreadAvatar` hook.
Apr 19 2023, 4:28 PM
atul closed D7509: [native] Move `ThreadAvatar` "inside" `EditThreadAvatar`.
Apr 19 2023, 4:28 PM
atul closed D7510: [native] Introduce naive `useSelectFromGalleryAndUpdateUserAvatar` hook.
Apr 19 2023, 4:28 PM
atul committed rCOMMa51ab899c288: [native] Move `ThreadAvatar` "inside" `EditThreadAvatar`.
Apr 19 2023, 4:28 PM
atul committed rCOMM3ece4b60c42e: [native] Introduce naive `useSelectFromGalleryAndUpdateUserAvatar` hook.
Apr 19 2023, 4:28 PM
atul closed D7508: [native] Move `UserAvatar` "inside" `EditUserAvatar`.
Apr 19 2023, 4:28 PM
atul closed D7507: [native] Move complexity of `actionSheetConfig` to `useShowAvatarActionSheet`.
Apr 19 2023, 4:28 PM
atul committed rCOMM38a498dbe6ce: [native] Move complexity of `actionSheetConfig` to `useShowAvatarActionSheet`.
Apr 19 2023, 4:28 PM
atul committed rCOMM912799556ba0: [native] Move `UserAvatar` "inside" `EditUserAvatar`.
Apr 19 2023, 4:28 PM
atul closed D7506: [native] Pull `useShowAvatarActionSheet` out of `Edit*Avatar`.
Apr 19 2023, 4:28 PM
atul committed rCOMM45d2bc435f8a: [native] Pull `useShowAvatarActionSheet` out of `Edit*Avatar`.
Apr 19 2023, 4:28 PM
atul updated the diff for D7510: [native] Introduce naive `useSelectFromGalleryAndUpdateUserAvatar` hook.

address feedback

Apr 19 2023, 4:17 PM
atul added inline comments to D7510: [native] Introduce naive `useSelectFromGalleryAndUpdateUserAvatar` hook.
Apr 19 2023, 4:16 PM
atul updated the diff for D7507: [native] Move complexity of `actionSheetConfig` to `useShowAvatarActionSheet`.

explicit undefined

Apr 19 2023, 4:14 PM
atul updated the diff for D7507: [native] Move complexity of `actionSheetConfig` to `useShowAvatarActionSheet`.

address feedback ($ReadOnlyArray<>)

Apr 19 2023, 4:13 PM
atul attached a referenced file: F495706: 218599.png.
Apr 19 2023, 3:45 PM
atul added inline comments to D7507: [native] Move complexity of `actionSheetConfig` to `useShowAvatarActionSheet`.
Apr 19 2023, 3:45 PM
atul accepted D7523: [native] Put Calendar tab after Inbox.
Apr 19 2023, 12:50 PM
atul published D7513: [native] Introduce `useRemoveThreadAvatar` hook for review.
Apr 19 2023, 3:22 AM
atul attached a referenced file: F494908: Screenshot_1681873252.png.
Apr 19 2023, 3:01 AM
atul added inline comments to D7512: [native] Introduce `useRemoveUserAvatar` hook.
Apr 19 2023, 3:01 AM
atul published D7512: [native] Introduce `useRemoveUserAvatar` hook for review.
Apr 19 2023, 2:50 AM
atul requested review of D7511: [native] Introduce naive `useSelectFromGalleryAndUpdateThreadAvatar` hook.
Apr 19 2023, 2:25 AM
atul published D7510: [native] Introduce naive `useSelectFromGalleryAndUpdateUserAvatar` hook for review.
Apr 19 2023, 1:44 AM

Apr 18 2023

atul requested review of D7509: [native] Move `ThreadAvatar` "inside" `EditThreadAvatar`.
Apr 18 2023, 11:18 PM
atul requested review of D7508: [native] Move `UserAvatar` "inside" `EditUserAvatar`.
Apr 18 2023, 11:05 PM
atul published D7507: [native] Move complexity of `actionSheetConfig` to `useShowAvatarActionSheet` for review.
Apr 18 2023, 10:39 PM
atul published D7506: [native] Pull `useShowAvatarActionSheet` out of `Edit*Avatar` for review.
Apr 18 2023, 9:33 PM
atul closed D7502: [native] Pull `EditAvatarBadge` into its own component.
Apr 18 2023, 8:20 PM
atul committed rCOMM343b90fb639a: [native] Pull `EditAvatarBadge` into its own component.
Apr 18 2023, 8:20 PM
atul closed D7499: [native] Use `outline` variant of `emote-smile` in `Edit*Avatar` for consistency.
Apr 18 2023, 8:20 PM