Wonder if older versions of Android may fallback to font?
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Apr 23 2023
Apr 21 2023
Apr 20 2023
While the changes in edit-thread-avatar-permission need to be revisited, the code in persist.js is solid (shoutout @rohan who wrote it).
Okay well as a starting point trying the migration with my already correct threadStore led to some inconsistencies...
address feedback before landing
Apr 19 2023
In D7543#223748, @ashoat wrote:The Android build was consistently failing here… any cause for concern?
rebase and land
rebase and land
fix..
Oh no shit it wasn't updating the image.... I'm awaiting without returning smh
I have no idea why, but it looks like this diff is breaking things..
rebase and land
address feedback (human readable alert titles)
In D7530#223434, @ashoat wrote:Can we replace the ALERT_TITLES with "Alert title", to make them more human-readable?
In D7527#223357, @ashoat wrote:Wouldn't it be more simple / readable to handle this at the callsite for selectFromGalleryAndUpdateUserAvatar? Eg. like this:
const [userAvatarUpdateInProgress, setUserAvatarUpdateInProgress] = React.useState(false); const updateCallback = React.useCallback(async () => { setUserAvatarUpdateInProgress(true); try { const result = await selectFromGalleryAndUpdateUserAvatar(params); } finally { setUserAvatarUpdateInProgress(false); } }. [selectFromGalleryAndUpdateUserAvatar, params]);It will lead to a little bit of copy-paste, but might be worth it for the improved readability / simplicity. What do you think?
address feedback
explicit undefined
address feedback ($ReadOnlyArray<>)