Looks good

ladn

address feedback

(feel free to add me back if there's something specific I can be helpful w/, don't have a ton of context here)

Sweet, thanks for addressing feedback!

I don't want to request changes and block this diff, but very extremely strongly feel that we should use the existing and well understood h1 -> h6 system of categorizing text styles instead of rolling our own that "acts in parallel."

Flexbox is a bit more simple to use/understand

<MobileNav> component looks clean!

Defer to @ashoat (setting as blocking) on license/attribution/dependency management.

Looks good to me!

Sweet, I think this will make colors.js much easier to work w/ in the future.

Looks good at a high level. Thanks for including examples in the Test Plan!

I'm guessing these utilities are going to be used widely, so it'd be good to make sure they're as robust as possible. Left some notes inline.

use &apos;

rebase before addressing feedback

rebase and land

I may have misread the following from (https://blog.isquaredsoftware.com/2020/05/blogged-answers-a-mostly-complete-guide-to-react-rendering-behavior/#component-render-optimization-techniques) and misled @ginsu here:

Updated to display "@ ashoat" as default keyserver. Also made the modal "large" so the copy would fit a bit better:

placeholder keyserver name

I also locally tested every typography and made sure that they matched what was in the designs

(Personally think it might look better if the Ethereum logo was above the text)

partially address feedback (copy)

In D7764#230485, @ginsu wrote:

could you link the figma?

Looks good, would be good to get response on snake_case error messages before landing.

Looks good, left a couple of minor notes. Would be good to get response on snake_case error messages before landing.

Changes look good, adding @ashoat as blocking (as formality) since it's a dependency diff.

Disregard... it's a class component. My bad.

It'd also be good to test on native to make sure the generated TTF glyphs look as expected.

Does the sizing look right? Can't really tell from the images from the Test Plan, but as long as things looked right during your testing.

address feedback

rebase (fixing env)

rebase before addressing feedback

In D7722#229022, @ashoat wrote:

Can we just pull this outside of the function body?

actually land

rebase

rebase before landing