Page MenuHomePhabricator

[landing] introduce colors from design system
ClosedPublic

Authored by ginsu on May 9 2023, 5:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 11:53 PM
Unknown Object (File)
Thu, Feb 29, 8:49 PM
Unknown Object (File)
Feb 10 2024, 1:44 PM
Unknown Object (File)
Feb 10 2024, 1:43 PM
Unknown Object (File)
Feb 10 2024, 1:43 PM
Unknown Object (File)
Feb 10 2024, 1:38 PM
Unknown Object (File)
Feb 10 2024, 1:02 PM
Unknown Object (File)
Feb 10 2024, 12:51 PM

Details

Summary

This diff introduces all the colors in Ted's new color design system. For this diff I decided to just add the colors and leave the other variables in for now just so I don't cause any regressions I may be unaware about. As I keep working on the landing page, I will slowly phase out and get rid of any unused colors/variables. One thing to note is that this diff does not include black-95. I was instructed by Ted not to include this since this color is only used in the nav sidebar and Ted said that he just put it in here to record it, but will eventually figure out a better place for that color

Links to color design system:
https://www.figma.com/file/fwKJ6eNgfxlx8a7WxSyAZL/2023-Design-System?node-id=1-427&t=ds82zlYncjLEbFB9-4

Link to landing page specific colors:
https://www.figma.com/file/HAAQwcEIjM32gnEMy2d0k5/Comm-%2F-Landing?node-id=3263-41925&t=EVfPbbD9hMG9rkrB-4

Depends on D7755

Test Plan

Had ted double check this, and got his stamp of approval

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu added reviewers: atul, kamil.
ginsu requested review of this revision.May 9 2023, 5:58 AM
This revision is now accepted and ready to land.May 10 2023, 5:23 AM
landing/global.css
37 ↗(On Diff #26287)

This name seems like it might be a little too general?

landing/global.css
37 ↗(On Diff #26287)

This should be an easy fix, I'll talk to Ted about this just so everyone is aware/aligned

ginsu added inline comments.
landing/global.css
37–38 ↗(On Diff #26521)

@ted I updated these names in the figma too, so everything should be in sync