Details

Reviewers

atul
kamil

Commits

rCOMMcb315ae7cde7: [landing] add feedback text to subscription form component

Summary

As part of the subscription form redesign we need to show some feedback text to the user depending on the result of the email entered in the subscription form. For reference here are the designs:

Screenshot 2023-05-31 at 12.25.25 PM.png (1×3 px, 1 MB)

Screenshot 2023-05-22 at 5.10.53 PM.png (2×3 px, 2 MB)

Depends on D7917

Test Plan

Please see the screenshots below to see what the feedback text looks like:

Desktop:

Screenshot 2023-05-31 at 12.15.17 PM.png (2×3 px, 1 MB)

Screenshot 2023-05-31 at 12.15.27 PM.png (2×3 px, 1 MB)

Tablet:

Screenshot 2023-05-31 at 12.22.02 PM.png (2×3 px, 1006 KB)

Screenshot 2023-05-31 at 12.22.06 PM.png (2×3 px, 997 KB)

Mobile:

Screenshot 2023-05-31 at 12.21.49 PM.png (2×3 px, 992 KB)

Screenshot 2023-05-31 at 12.21.44 PM.png (2×3 px, 987 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.May 31 2023, 9:26 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 31 2023, 9:26 AM

ginsu edited the summary of this revision. (Show Details)May 31 2023, 9:28 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D7915: [landing] redesign the subscription form component.

ginsu attached a referenced file: F566295: Screenshot 2023-05-31 at 12.21.44 PM.png. (Show Details)

ginsu attached a referenced file: F566296: Screenshot 2023-05-31 at 12.21.49 PM.png. (Show Details)

ginsu attached a referenced file: F566292: Screenshot 2023-05-31 at 12.22.06 PM.png. (Show Details)

ginsu attached a referenced file: F566293: Screenshot 2023-05-31 at 12.22.02 PM.png. (Show Details)

ginsu attached a referenced file: F566290: Screenshot 2023-05-31 at 12.15.27 PM.png. (Show Details)

ginsu attached a referenced file: F566291: Screenshot 2023-05-31 at 12.15.17 PM.png. (Show Details)

ginsu attached a referenced file: F566288: Screenshot 2023-05-22 at 5.10.53 PM.png. (Show Details)

ginsu attached a referenced file: F566287: Screenshot 2023-05-31 at 12.25.25 PM.png. (Show Details)

Harbormaster completed remote builds in B19928: Diff 27308.May 31 2023, 9:44 AM

ginsu requested review of this revision.May 31 2023, 9:44 AM

ginsu added a child revision: D8054: [landing] remove deprecated info blocks.Jun 1 2023, 10:08 AM

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D7917: [landing] fix css class names for subscription form component.

ginsu removed a parent revision: D7915: [landing] redesign the subscription form component.

atul accepted this revision.Jun 1 2023, 11:09 AM

atul added inline comments.

landing/subscription-form.css
67 ↗	(On Diff #27308)	Personally think this green is dull, but subjective

This revision is now accepted and ready to land.Jun 1 2023, 11:09 AM

Tablet / mobile screenshots have buttons with text that doesn't appear vertically centered. Can we look into that and ideally resolve it before landing?