Page MenuHomePhabricator
Differential D7914

[landing] remove react-text-loop dependency
ClosedPublic
Actions

Authored by ginsu on May 22 2023, 6:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 2:51 AM
Unknown Object (File)
Thu, Feb 27, 7:54 AM
Unknown Object (File)
Thu, Feb 27, 7:54 AM
Unknown Object (File)
Thu, Feb 27, 7:54 AM
Unknown Object (File)
Wed, Feb 26, 4:25 AM
Unknown Object (File)
Tue, Feb 25, 4:29 AM
Unknown Object (File)
Tue, Feb 25, 4:29 AM
Unknown Object (File)
Tue, Feb 25, 4:29 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
kamil
ashoat
Commits
rCOMM5119a4a27a09: [landing] remove react-text-loop dependency
Summary

In D7911 we removed usage of react-text-loop in our app. This dependency is now no longer used in the project, so I figured it would be good to remove it from our package dependency list

Adding @ashoat as a reviewer since this is a dependency diff

Depends on D7911

Test Plan

N/A for this diff just ran yarn remove react-text-loop in the landing directory

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.May 22 2023, 6:52 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 22 2023, 6:52 AM
ginsu edited the summary of this revision. (Show Details)May 22 2023, 6:55 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil, ashoat.
ginsu added a parent revision: D7911: [landing] change text content on HeroContent component.
ginsu edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B19596: Diff 26781.May 22 2023, 7:08 AM
ginsu requested review of this revision.May 22 2023, 7:08 AM
ginsu added a child revision: D7915: [landing] redesign the subscription form component.May 22 2023, 7:16 AM
ashoat accepted this revision.May 22 2023, 8:02 AM

Love a red diff!

This revision is now accepted and ready to land.May 22 2023, 8:02 AM
ginsu updated this revision to Diff 29675.Aug 8 2023, 12:26 PM

rebase before landing

Harbormaster completed remote builds in B21629: Diff 29675.Aug 8 2023, 1:38 PM
Closed by commit rCOMM5119a4a27a09: [landing] remove react-text-loop dependency (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5119a4a27a09: [landing] remove react-text-loop dependency.

Revision Contents
Changeset List

PathSize
landing/
1 line
42 lines

Diff 29746

View Options

landing/package.json

Show All 31 Lines.questionText {
color: var(--white-100); color: var(--white-100);
} }
.icon { .icon {
margin-left: 24px; margin-left: 24px;
} }
.answerContainer { .answerContainer {
max-height: 0; display: grid;
overflow: hidden; grid-template-rows: 0fr;
transition: grid-template-rows 500ms;
} }
.activeAnswerContainer { .activeAnswerContainer {
max-height: fit-content; grid-template-rows: 1fr;
} }
.answerText { .answerText {
color: var(--white-100); color: var(--white-100);
margin-top: 16px; margin-top: 16px;
overflow: hidden;
} }
.link { .link {
color: inherit; color: inherit;
text-decoration: underline; text-decoration: underline;
transition: color 150ms; transition: color 150ms;
} }
.link:hover { .link:hover {
color: var(--violet-dark-100); color: var(--violet-dark-100);
transition: color 150ms; transition: color 150ms;
} }
View Options

yarn.lock

Show All 31 Lines.questionText {
color: var(--white-100); color: var(--white-100);
} }
.icon { .icon {
margin-left: 24px; margin-left: 24px;
} }
.answerContainer { .answerContainer {
max-height: 0; display: grid;
overflow: hidden; grid-template-rows: 0fr;
transition: grid-template-rows 500ms;
} }
.activeAnswerContainer { .activeAnswerContainer {
max-height: fit-content; grid-template-rows: 1fr;
} }
.answerText { .answerText {
color: var(--white-100); color: var(--white-100);
margin-top: 16px; margin-top: 16px;
overflow: hidden;
} }
.link { .link {
color: inherit; color: inherit;
text-decoration: underline; text-decoration: underline;
transition: color 150ms; transition: color 150ms;
} }
.link:hover { .link:hover {
color: var(--violet-dark-100); color: var(--violet-dark-100);
transition: color 150ms; transition: color 150ms;
} }