Paths

Table of Contentst

Differential D7898

[landing] minor improvements to mobile nav ui
AcceptedPublic
Actions

Authored by ginsu on Sun, May 21, 1:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 29, 5:06 PM

	Unknown Object (File)
	Sun, May 21, 2:26 AM

	F548647: Screen Recording 2023-05-21 at 11.48.58 AM.mov
	Sun, May 21, 1:49 AM

Subscribers

Details

Reviewers

atul
kamil

Summary

Earlier this week, I synced with @ted and we went over the whole header/mobile nav together, and we talked about some minor UI improvements we could make. This diff addresses those improvements. The improvements that were made were:

Increase the horizontal padding in the MobileNav so it lined up better with the header
When a user hovered over the tabs or icons in the MobileNav we should show a lighter white

Depends on D7871

Test Plan

Please watch the demo video below:

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Sun, May 21, 1:44 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptSun, May 21, 1:44 AM

ginsu edited the summary of this revision. (Show Details)Sun, May 21, 1:49 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu attached a referenced file: F548647: Screen Recording 2023-05-21 at 11.48.58 AM.mov. (Show Details)

Harbormaster completed remote builds in B19544: Diff 26725.Sun, May 21, 2:02 AM

ginsu requested review of this revision.Sun, May 21, 2:02 AM

ginsu added a child revision: D7911: [landing] change text content on HeroContent component.Mon, May 22, 6:49 AM

ginsu edited the summary of this revision. (Show Details)Mon, May 22, 6:56 AM

ginsu added a parent revision: D7871: [landing] fix mobile nav bar peeking into screen when quickly resizing window.

atul accepted this revision.Mon, May 22, 8:21 AM

This revision is now accepted and ready to land.Mon, May 22, 8:21 AM

Revision Contents
Changeset List

Path

Size

landing/

6 lines

Diff 26725

landing/mobile-nav.css

Loading...