Details

Reviewers

atul
kamil

Commits

rCOMM3109eb8f6915: [landing] introduce request access compoonent

Summary

As part of the redesign for the landing page there is Request access call to action at the bottom of the main page. This diff creates that section into its own component. Here is a screenshot of the designs for extra context

Screenshot 2023-06-02 at 4.03.43 PM.png (1×3 px, 2 MB)

Depends on D8079

Test Plan

Please watch the demo video below/see the screenshots

Desktop/Responsive:

Tablet:

Screenshot 2023-06-02 at 3.59.40 PM.png (2×3 px, 980 KB)

Mobile:

Screenshot 2023-06-02 at 4.06.58 PM.png (2×3 px, 884 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 2 2023, 1:02 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2023, 1:02 PM

ginsu edited the summary of this revision. (Show Details)Jun 2 2023, 1:07 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8079: [landing] repurpose InfoBlock component.

ginsu attached a referenced file: F569870: Screenshot 2023-06-02 at 4.06.58 PM.png. (Show Details)

ginsu attached a referenced file: F569868: Screenshot 2023-06-02 at 3.59.40 PM.png. (Show Details)

ginsu attached a referenced file: F569861: Screen Recording 2023-06-02 at 3.58.04 PM.mov. (Show Details)

ginsu attached a referenced file: F569860: Screenshot 2023-06-02 at 4.03.43 PM.png. (Show Details)

fix missed merge conflict

ginsu added inline comments.Jun 2 2023, 1:14 PM

landing/global.css
30 ↗	(On Diff #27418)	Kinda unrelated, but as I was working on this diff, I noticed that I had two `--violet-dark-40`.
landing/request-access.css
33 ↗	(On Diff #27418)	If I have time at the end, I will take a look at using `box-shadow` here and in D8076

ginsu added a child revision: D8081: [landing] add all section components to AppLanding.Jun 2 2023, 1:18 PM

Harbormaster completed remote builds in B20000: Diff 27417.Jun 2 2023, 1:22 PM

Harbormaster completed remote builds in B20001: Diff 27418.Jun 2 2023, 1:27 PM

ginsu requested review of this revision.Jun 2 2023, 1:27 PM

kamil accepted this revision.Jun 6 2023, 2:59 AM

kamil added inline comments.

landing/request-access.react.js
15 ↗	(On Diff #27418)	Font size seems too big on mobile after looking at the design but not sure how up-to-date are those

This revision is now accepted and ready to land.Jun 6 2023, 2:59 AM

kamil added inline comments.Jun 6 2023, 3:18 AM

landing/request-access.css
5 ↗	(On Diff #27418)	After looking at the demo the gap between this and upper component feels too big but it's just my personal opinion

ginsu added a subscriber: • ted.Jun 9 2023, 12:45 PM

ginsu added inline comments.

landing/request-access.css
5 ↗	(On Diff #27418)	Spoke to @ted about this, but we ultimately decided to just keep this as is
landing/request-access.react.js
15 ↗	(On Diff #27418)	This will be addressed in a subsequent diff (will link diff momentarily)