Differential D7869 Authored by ginsu on May 19 2023, 11:47 AM.
Tags None Referenced Files
Details Summary This is the last diff that updates the header component. This diff changes the hamburger menu icon to a close icon depending if the mobile nav is active or not. Depends on D7868 Test Plan Please see the screenshots below: When the mobile nav is not active:  When the mobile nav is active: 
Diff Detail
Event TimelineHerald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 19 2023, 11:47 AM2023-05-19 11:47:17 (UTC+0) ginsu edited the summary of this revision. (Show Details)May 19 2023, 11:50 AM2023-05-19 11:50:13 (UTC+0) Harbormaster completed remote builds in B19501: Diff 26666.May 19 2023, 12:05 PM2023-05-19 12:05:55 (UTC+0) This revision is now accepted and ready to land.May 19 2023, 5:50 PM2023-05-19 17:50:40 (UTC+0) Harbormaster completed remote builds in B21606: Diff 29646.Aug 8 2023, 7:30 PM2023-08-08 19:30:53 (UTC+0) Closed by commit rCOMMf4fd228b7c06: [landing] show close icon when mobile nav is active. · Explain WhyAug 8 2023, 9:07 PM2023-08-08 21:07:53 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 29723 |