Paths

Table of Contentst

Differential D8078

[landing] introduce new assetMetaData
ClosedPublic
Actions

Authored by ginsu on Jun 2 2023, 12:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 17, 2:18 AM

	Unknown Object (File)
	Sun, Nov 17, 1:38 AM

	Unknown Object (File)
	Sun, Nov 17, 1:38 AM

	Unknown Object (File)
	Sun, Nov 17, 1:38 AM

	Unknown Object (File)
	Sun, Nov 17, 1:38 AM

	Unknown Object (File)
	Sun, Nov 17, 1:38 AM

	Unknown Object (File)
	Sun, Nov 17, 1:38 AM

	Unknown Object (File)
	Sat, Nov 16, 11:28 PM

Subscribers

Details

Reviewers

atul
kamil

Commits

rCOMMa8cf43fef363: [landing] introduce new assetMetaData

Summary

In preparation of repurposing the InfoBlocks to match the new designs, I reintroduced and updated the type for the assetMetaData array.

They copy for this file was copy and pasted from DES-74 and DES-75

Depends on D8077

Test Plan

Please look at the screenshots below:

Keyserver info block:

Screenshot 2023-08-07 at 3.53.25 PM.png (2×3 px, 867 KB)

Team info block:
No hover:

Screenshot 2023-08-07 at 3.39.31 PM.png (2×3 px, 818 KB)

Hover over "Ashoat":

Screenshot 2023-08-07 at 3.39.36 PM.png (2×3 px, 830 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 2 2023, 12:09 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2023, 12:09 PM

ginsu edited the summary of this revision. (Show Details)Jun 2 2023, 12:14 PM

ginsu added a parent revision: D8077: [landing] move hero section code into own component.

Harbormaster completed remote builds in B19997: Diff 27414.Jun 2 2023, 12:26 PM

ginsu requested review of this revision.Jun 2 2023, 12:26 PM

ginsu added a child revision: D8079: [landing] repurpose InfoBlock component.Jun 2 2023, 12:49 PM

update copy

ginsu retitled this revision from DRAFT: [landing] introduce new assetMetaData to [landing] introduce new assetMetaData.Aug 7 2023, 1:01 PM

ginsu edited the summary of this revision. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu attached a referenced file: F678290: Screenshot 2023-08-07 at 3.39.36 PM.png. (Show Details)

ginsu attached a referenced file: F678289: Screenshot 2023-08-07 at 3.39.31 PM.png. (Show Details)

ginsu attached a referenced file: F678288: Screenshot 2023-08-07 at 3.53.25 PM.png. (Show Details)

ginsu added inline comments.Aug 7 2023, 1:08 PM

landing/asset-meta-data.js
20 ↗	(On Diff #29597)	In this linear comment, @ashoat and I talked about making `infoBlockContent` a piece of JSX instead of just a string (which was what we originally had) so that we can easily embed links into the content
90 ↗	(On Diff #29597)	Flow makes us explicitly annotate the type here:

ginsu attached a referenced file: F678297: Screenshot 2023-08-07 at 4.06.44 PM.png. (Show Details)Aug 7 2023, 1:08 PM

Harbormaster completed remote builds in B21573: Diff 29597.Aug 7 2023, 1:17 PM

improve types

ginsu added inline comments.Aug 7 2023, 2:18 PM

landing/asset-meta-data.js
20 ↗	(On Diff #29601)	In this linear comment, @ashoat and I talked about making infoBlockContent a piece of JSX instead of just a string (which was what we originally had) so that we can easily embed links into the content

Harbormaster completed remote builds in B21577: Diff 29601.Aug 7 2023, 2:36 PM

atul accepted this revision.Aug 7 2023, 10:33 PM

This revision is now accepted and ready to land.Aug 7 2023, 10:33 PM

rebase before landing

add transition

Harbormaster completed remote builds in B21638: Diff 29684.Aug 8 2023, 2:06 PM

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:08 PM

Closed by commit rCOMMa8cf43fef363: [landing] introduce new assetMetaData (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMa8cf43fef363: [landing] introduce new assetMetaData.

Harbormaster completed remote builds in B21666: Diff 29712.Aug 8 2023, 3:29 PM

Revision Contents
Changeset List

Path

Size

landing/

asset-meta-data.js

82 lines

29 lines

use-pre-load-image-assets.react.js

2 lines

Diff 29754

landing/asset-meta-data.js

Loading...

landing/landing.css

Loading...

landing/use-pre-load-image-assets.react.js

Loading...