Details

Reviewers

atul
kamil

Commits

rCOMM012eb7a550ce: [landing] redesign footer component

Summary

This is the second part to implmenenting the redesign for the footer component. This diff adds the new elments that are shown in the figma design (screenshot below) and arranges them to match the design

Screenshot 2023-06-02 at 5.02.20 PM.png (1×3 px, 2 MB)

Screenshot 2023-06-02 at 5.02.13 PM.png (1×3 px, 1 MB)

Depends on D8082

Test Plan

Please watch the demo video/see the screenshots below:

Desktop/Responsive:

Tablet:

Screenshot 2023-06-02 at 5.00.55 PM.png (2×3 px, 939 KB)

Mobile:

Screenshot 2023-06-02 at 5.01.01 PM.png (2×3 px, 900 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 2 2023, 1:55 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2023, 1:55 PM

ginsu edited the summary of this revision. (Show Details)Jun 2 2023, 2:05 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8082: [landing] remove subscription form from footer.

ginsu attached a referenced file: F570012: Screenshot 2023-06-02 at 5.01.01 PM.png. (Show Details)

ginsu attached a referenced file: F570011: Screenshot 2023-06-02 at 5.00.55 PM.png. (Show Details)

ginsu attached a referenced file: F570001: Screen Recording 2023-06-02 at 4.59.27 PM.mov. (Show Details)

ginsu attached a referenced file: F569999: Screenshot 2023-06-02 at 5.02.13 PM.png. (Show Details)

ginsu attached a referenced file: F570000: Screenshot 2023-06-02 at 5.02.20 PM.png. (Show Details)

Harbormaster completed remote builds in B20004: Diff 27421.Jun 2 2023, 2:15 PM

ginsu requested review of this revision.Jun 2 2023, 2:15 PM

ginsu added a child revision: D8092: [landing] introduce keyserver faq data.Jun 5 2023, 6:42 AM

kamil accepted this revision.Jun 6 2023, 4:05 AM

kamil added inline comments.

landing/footer.css
26 ↗	(On Diff #27421)	maybe that will make it more clear which icons it contains?
34 ↗	(On Diff #27421)	Isn't this value a bit too big? design vs demo
landing/footer.react.js
77 ↗	(On Diff #27421)	I am assuming that `arrow-up-right icon` is not available in the codebase to better match the design?
92–107 ↗	(On Diff #27421)	wondering, shouldn't those be opened in a new tab?

This revision is now accepted and ready to land.Jun 6 2023, 4:05 AM

kamil attached a referenced file: F573288: image.png. (Show Details)Jun 6 2023, 4:06 AM

kamil attached a referenced file: F573287: image.png. (Show Details)

address comments

ginsu added a subscriber: • ted.Jun 9 2023, 12:43 PM

ginsu added inline comments.

landing/footer.react.js
77 ↗	(On Diff #27421)	Yea we couldn't find a free icon that matched the design perfectly. @ted said this icon would suffice
92–107 ↗	(On Diff #27421)	This will be addressed in a subsequent diff (will link diff momentarily)