Paths

Table of Contentst

-
landing/
1/2
info-block.css
1/2
info-block.react.js

[landing] repurpose InfoBlock component
ClosedPublic
Actions

Authored by ginsu on Jun 2 2023, 12:44 PM.

Details

Reviewers

atul
kamil

Commits

rCOMMe917432ea51a: [landing] repurpose InfoBlock component

Summary

This diff repurposes the InfoBlock component to work for this landing page redesign. A big change with this InfoBlock component is that we no longer need an image, and all the content in the InfoBlock is centered. Here is a screenshot of the designs for extra context:

Screenshot 2023-06-02 at 3.47.19 PM.png (1×3 px, 1 MB)

Screenshot 2023-06-02 at 3.47.14 PM.png (1×3 px, 1 MB)

Depends on D8078

Test Plan

Please see the demo videos/screenshots below to see how the new InfoBlock component:

Desktop/Responsive:

Tablet:

Screenshot 2023-06-02 at 3.41.06 PM.png (2×3 px, 972 KB)

Mobile:

Screenshot 2023-06-02 at 3.40.59 PM.png (2×3 px, 971 KB)

Screenshot 2023-06-02 at 3.49.45 PM.png (2×3 px, 937 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 2 2023, 12:44 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2023, 12:44 PM

ginsu edited the summary of this revision. (Show Details)Jun 2 2023, 12:49 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8078: [landing] introduce new assetMetaData.

ginsu edited the test plan for this revision. (Show Details)

ginsu attached a referenced file: F569832: Screenshot 2023-06-02 at 3.49.45 PM.png. (Show Details)

ginsu attached a referenced file: F569827: Screenshot 2023-06-02 at 3.40.59 PM.png. (Show Details)

ginsu attached a referenced file: F569826: Screenshot 2023-06-02 at 3.41.06 PM.png. (Show Details)

ginsu attached a referenced file: F569811: Screen Recording 2023-06-02 at 3.39.28 PM.mov. (Show Details)

ginsu attached a referenced file: F569824: Screenshot 2023-06-02 at 3.47.14 PM.png. (Show Details)

ginsu attached a referenced file: F569825: Screenshot 2023-06-02 at 3.47.19 PM.png. (Show Details)

Harbormaster completed remote builds in B19999: Diff 27416.Jun 2 2023, 1:03 PM

ginsu requested review of this revision.Jun 2 2023, 1:03 PM

ginsu added a child revision: D8080: [landing] introduce request access compoonent.Jun 2 2023, 1:07 PM

ginsu added inline comments.Jun 2 2023, 2:03 PM

landing/info-block.css
13–16 ↗	(On Diff #27416)	We talked about using these styles already in D7911

atul accepted this revision.Jun 2 2023, 3:09 PM

This revision is now accepted and ready to land.Jun 2 2023, 3:09 PM

rebase

Harbormaster completed remote builds in B21575: Diff 29599.Aug 7 2023, 1:55 PM

rebase before landing

Harbormaster completed remote builds in B21639: Diff 29685.Aug 8 2023, 2:08 PM

Closed by commit rCOMMe917432ea51a: [landing] repurpose InfoBlock component (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMe917432ea51a: [landing] repurpose InfoBlock component.

Revision Contents
Changeset List

Path

Size

landing/

info-block.css

56 lines

info-block.react.js

68 lines

Diff 29755

View Options

landing/info-block.css

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines