Page MenuHomePhorge
Feed Search

Jul 24 2023

atul accepted D8601: [CommCoreModule] Move `runSyncOrThrowJSError` to a separate file.

Looks like a straightforward move, didn't review too carefully

Jul 24 2023, 5:33 PM
atul added inline comments to D8564: [native] Support the edit_role action on the keyserver.
Jul 24 2023, 5:05 AM
atul added a reviewer for D8564: [native] Support the edit_role action on the keyserver: ashoat.

Adding @ashoat as blocking reviewer here since I don't have enough context on roles/permissions to give this a thorough review

Jul 24 2023, 4:59 AM
atul accepted D8359: [native] Create the community roles screen.
Jul 24 2023, 4:56 AM
atul accepted D8524: [native] Navigate to the role creation screen with pre-populated fields for editing roles.
Jul 24 2023, 4:46 AM

Jul 23 2023

atul accepted D8478: [lib] Add unit tests for user-facing permissions to verify the result.
Jul 23 2023, 9:10 PM
atul accepted D8599: [native] upgrade rn-emoji-keyboard to v1.5.0.
Jul 23 2023, 8:17 PM

Jul 17 2023

atul accepted D8477: [landing] clean up competitor comparison UI.
Jul 17 2023, 6:29 AM
atul accepted D8031: [landing] introduce keybase competitor data.
Jul 17 2023, 6:25 AM
atul accepted D8469: [CI] Buildkite for web emscripten build.

Looks good.

Jul 17 2023, 6:25 AM

Jul 12 2023

atul added a reverting change for rCOMMe4b007b4d5f2: [native] Temporary changes for staff release: rCOMMaaf816d8476d: Revert "[native] Temporary changes for staff release".
Jul 12 2023, 3:13 AM
atul committed rCOMMaaf816d8476d: Revert "[native] Temporary changes for staff release".
Jul 12 2023, 3:13 AM
atul committed rCOMM06e0b5a8b34f: [native] `codeVersion` -> 232.
Jul 12 2023, 3:13 AM
atul committed rCOMMe4b007b4d5f2: [native] Temporary changes for staff release.
Jul 12 2023, 3:13 AM
atul committed rCOMM49bbb91331b3: [native] `codeVersion` -> 231.
Jul 12 2023, 3:13 AM

Jul 11 2023

atul added a comment to D8031: [landing] introduce keybase competitor data.

Please use rsquo for all apostrophes, and make sure you adjust the whole competitor-data.js file to reflect that

Jul 11 2023, 1:25 AM
atul added a comment to D8447: [identity] hard-code the platform type for the identity docker image.

Why not use arm64 instances? Are they more expensive? Vaguely recall the AWS Graviton instances having better price/performance?

Jul 11 2023, 12:38 AM

Jun 29 2023

atul updated the test plan for D8364: [web] Move `exifRotate` from `input-state-container` to `media-utils`.
Jun 29 2023, 1:50 AM
atul added a comment to D8355: [lib] Generate converters from validators.
  1. I worry that the codegenned file might get out of sync with its inputs. Before landing, can you create a Linear task to add a CI job that regenerates the file and confirms there are no changes? We should make sure we complete that task before we ship this project.
Jun 29 2023, 1:49 AM
atul requested review of D8343: Move registrationMode-related logic from `setUserAvatar` to `nativeSetUserAvatar`.

I'm confused – what was not platform-agnostic about this before? It seems like you still need the state in lib, so I'm not really sure what this diff is achieving

Jun 29 2023, 1:42 AM
atul requested review of D8345: Move registrationMode-related logic from `updateImageUserAvatar` to `nativeUpdateUserImageAvatar`.

updateImageUserAvatar previously took (selection: NativeMediaSelection) as an argument to satisfy the mediaSelection: NativeMediaSelection field of the object passed to registrationModeRef.current.successCallback when needsUpload is true.

Jun 29 2023, 1:41 AM

Jun 28 2023

atul published D8364: [web] Move `exifRotate` from `input-state-container` to `media-utils` for review.
Jun 28 2023, 10:52 PM
atul updated the summary of D8363: [lib] Consolidate `baseUpdateImageUserAvatar` into `baseSetUserAvatar`.
Jun 28 2023, 10:48 PM
atul published D8363: [lib] Consolidate `baseUpdateImageUserAvatar` into `baseSetUserAvatar` for review.
Jun 28 2023, 10:10 PM
atul added inline comments to D8160: [native] Create a ChangeRolesHeaderRightButton to save role changes.
Jun 28 2023, 10:06 PM
atul closed D8362: [web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus`.
Jun 28 2023, 8:38 PM
atul committed rCOMMeb4630c6ba30: [web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus`.
Jun 28 2023, 8:38 PM
atul updated the diff for D8362: [web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus`.

cherrypick and land

Jun 28 2023, 8:34 PM
atul retitled D8362: [web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus` from [web] Set emoji `Picker` to always be "dark" mode
Jun 28 2023, 8:29 PM
atul updated the diff for D8362: [web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus`.

include autofocus change

Jun 28 2023, 8:28 PM
atul published D8362: [web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus` for review.
Jun 28 2023, 8:25 PM
atul requested review of D8360: [lib] Rename `updateImageUserAvatar` to `baseUpdateImageUserAvatar` in `EditUserAvatarProvider`.
Jun 28 2023, 7:57 PM
atul updated the summary of D8344: [lib] Rename `setUserAvatar` to `baseSetUserAvatar` in `*EditUserAvatarProvider`.
Jun 28 2023, 7:38 PM
atul added a reviewer for D8244: [services] Delete shared C++ lib: ashoat. atul added 1 blocking reviewer(s) for D8244: [services] Delete shared C++ lib: jon.

Should've added @ashoat and @jon as blocking to take another look

Jun 28 2023, 7:33 PM
atul planned changes to D8297: [native] Bump `react-native-ffmpeg` to `5.2.0`.
Jun 28 2023, 7:26 PM
atul accepted D8244: [services] Delete shared C++ lib.

Nice, no more reactors!

Jun 28 2023, 7:25 PM
atul accepted D8325: [web] Rename multimedia holder to blobURI.
Jun 28 2023, 7:15 PM
atul accepted D8324: [lib][native] Disambiguate URIs in media-cache.
Jun 28 2023, 7:14 PM
atul accepted D8323: [native] Rename holder prop to blobURI.

Looks like a pretty straightforward find and replace

Jun 28 2023, 7:10 PM
atul attached a referenced file: F610896: 578969.png.
Jun 28 2023, 7:07 PM
atul accepted D8322: [lib][keyserver] Rename holder to blobHash where appropriate.

Looks good!

Jun 28 2023, 7:07 PM
atul accepted D8358: [native] Navigate from the community action sheet to the new community roles screen.
Jun 28 2023, 6:49 PM
atul added a comment to D8358: [native] Navigate from the community action sheet to the new community roles screen.

Sweet, thanks for addressing feedback

Jun 28 2023, 6:48 PM
atul added a comment to D8305: [electron-update-server] Introduce new version.

As an aside, might be good to configure docker/build-push-actions for automatically pushing to DockerHub: https://github.com/docker/build-push-action

Jun 28 2023, 6:48 PM
atul added a comment to D8321: [keyserver] Use blob hash to create blob URIs.
In D8321#246316, @atul wrote:

We need to modify blob URI format to be blob-service://BLOB_HASH

Might be an ignorant question, but...

If two pieces of identical media are uploaded to the blob service, will they have the same blob hash?

It looks like blobHash comes from sha256Hash which is computed by commUtilsModule.sha256 which wraps olm_sha256.

It looks like that function is deterministic, are we including a counter or something in the bytes that we hash?

I'm guessing this is accounted for somewhere, just wondering where/how

Jun 28 2023, 6:32 PM
atul accepted D8321: [keyserver] Use blob hash to create blob URIs.

We need to modify blob URI format to be blob-service://BLOB_HASH

Jun 28 2023, 6:31 PM
atul added a comment to D8321: [keyserver] Use blob hash to create blob URIs.

This change is breaking, but I think nobody except me had any blob-service stored multimedia.

Jun 28 2023, 6:10 PM
atul accepted D8320: [web] Use local holder for blob deletion.
Jun 28 2023, 6:09 PM
atul requested changes to D8359: [native] Create the community roles screen.

Couple of suggestions inline. Only one that's blocking this diff from being accepted is the use of \n\n for layout, let's break that text apart and use eg padding/margin/etc to lay things out properly.

Jun 28 2023, 6:02 PM
atul requested changes to D8358: [native] Navigate from the community action sheet to the new community roles screen.

Let's update CommunityRolesHeaderLeftButton to move the styles outside of the component to unboundStyles and then consume them within the component via the useStyles(...) hook.

Jun 28 2023, 5:39 PM
atul accepted D8337: [web] Handle unsaved changes if the modal close button is clicked.

Looks reasonable, thanks for including the video

Jun 28 2023, 5:29 PM
atul added inline comments to D8338: [web] Use colors from themes.css in dropdown.
Jun 28 2023, 5:28 PM
atul accepted D8338: [web] Use colors from themes.css in dropdown.

Let's make sure to fix typo before landing

Jun 28 2023, 5:26 PM
atul accepted D8334: [chore] remove unused files and folders.
Jun 28 2023, 5:25 PM
atul added a reviewer for D8341: [native] Introduce `useNativeSetUserAvatar` and use throughout `native`: rohan.
Jun 28 2023, 1:30 AM
atul published D8348: Rename `BaseEditUserAvatarProvider` to `EditUserAvatarProvider` for review.
Jun 28 2023, 1:30 AM
atul published D8347: Consolidate `[Web/Native/Base]EditUserAvatarProvider` into `BaseEditUserAvatarProvider` for review.
Jun 28 2023, 1:28 AM
atul published D8346: Move `native`-specific `uploadSelectedMedia` from `updateImageUserAvatar` to `nativeUpdateUserImageAvatar` for review.
Jun 28 2023, 1:25 AM
atul updated the test plan for D8345: Move registrationMode-related logic from `updateImageUserAvatar` to `nativeUpdateUserImageAvatar`.
Jun 28 2023, 1:16 AM
atul updated the test plan for D8345: Move registrationMode-related logic from `updateImageUserAvatar` to `nativeUpdateUserImageAvatar`.
Jun 28 2023, 1:15 AM
atul published D8345: Move registrationMode-related logic from `updateImageUserAvatar` to `nativeUpdateUserImageAvatar` for review.
Jun 28 2023, 1:00 AM
atul updated the summary of D8344: [lib] Rename `setUserAvatar` to `baseSetUserAvatar` in `*EditUserAvatarProvider`.
Jun 28 2023, 12:38 AM
atul published D8344: [lib] Rename `setUserAvatar` to `baseSetUserAvatar` in `*EditUserAvatarProvider` for review.
Jun 28 2023, 12:35 AM
atul published D8343: Move registrationMode-related logic from `setUserAvatar` to `nativeSetUserAvatar` for review.
Jun 28 2023, 12:34 AM

Jun 27 2023

atul published D8342: [lib][native] Remove `displayFailureAlert` prop from `*EditUserAvatarProvider` for review.

On second thought, this totally could've been squashed with D8341

Jun 27 2023, 9:55 PM
atul published D8341: [native] Introduce `useNativeSetUserAvatar` and use throughout `native` for review.
Jun 27 2023, 9:50 PM
atul updated the summary of D8339: [native] Introduce `useNativeUpdateUserImageAvatar()` to `avatar-hooks.react`.
Jun 27 2023, 9:44 PM
atul updated the diff for D8339: [native] Introduce `useNativeUpdateUserImageAvatar()` to `avatar-hooks.react`.

fix invariant message

Jun 27 2023, 8:00 PM
atul accepted D8308: [lib/native] add user-filled to comm icons pack.

Sweet! Could you check web as well before landing?

Jun 27 2023, 7:42 PM
atul published D8340: [native] Consume `useNativeUpdateUserImageAvatar` in `useSelectFromGalleryAndUpdateUserAvatar` for review.
Jun 27 2023, 7:26 PM
atul updated the test plan for D8339: [native] Introduce `useNativeUpdateUserImageAvatar()` to `avatar-hooks.react`.
Jun 27 2023, 7:11 PM
atul published D8339: [native] Introduce `useNativeUpdateUserImageAvatar()` to `avatar-hooks.react` for review.
Jun 27 2023, 7:00 PM
atul accepted D8335: [native] Create a roles navigator to handle the role creation flow.
Jun 27 2023, 4:22 PM
atul accepted D8333: [native] Show Roles option in community action sheet.
Jun 27 2023, 4:21 PM
atul accepted D8332: [native] Rename InviteLinksButton to CommunityActionsButton.
Jun 27 2023, 4:20 PM
atul closed D8318: [lib] Move `selectFromGalleryAndUpdateUserAvatar` from provider to `avatar-hooks`.
Jun 27 2023, 4:17 PM
atul committed rCOMMb309c505208e: [lib] Move `selectFromGalleryAndUpdateUserAvatar` from provider to `avatar….
Jun 27 2023, 4:17 PM
atul accepted D8330: [keyserver] fetchUsernames helper function.

Let's rename fetchUsernames to fetchAllUsernames before landing.

Jun 27 2023, 4:14 PM
atul accepted D8336: [chore] clean up more services stuff.

Looks reasonable, would be good to get @jon and @ashoat's sign-off since they have more context on services.

Jun 27 2023, 4:09 PM
atul accepted D8334: [chore] remove unused files and folders.

Looks reasonable, would be good to get @jon and @ashoat's sign-off since they have more context on services.

Jun 27 2023, 4:08 PM
atul updated the diff for D8318: [lib] Move `selectFromGalleryAndUpdateUserAvatar` from provider to `avatar-hooks`.

rebase and land

Jun 27 2023, 4:03 PM
atul added a reverting change for rCOMM8ccfec2c73d5: [native] Temporary changes for staff release: rCOMM613f33133f73: Revert "[native] Temporary changes for staff release".
Jun 27 2023, 3:50 PM
atul committed rCOMM613f33133f73: Revert "[native] Temporary changes for staff release".
Jun 27 2023, 3:50 PM
atul committed rCOMM6437f6357d4f: [native] `codeVersion` -> 230.
Jun 27 2023, 3:50 PM
atul committed rCOMM8ccfec2c73d5: [native] Temporary changes for staff release.
Jun 27 2023, 3:50 PM
atul committed rCOMMc83b64055f9d: [native] `codeVersion` -> 229.
Jun 27 2023, 3:50 PM
atul closed D8316: [lib] Make `displayFailureAlert` optional in `BaseEditUserAvatar`.
Jun 27 2023, 3:30 PM
atul committed rCOMM2dabda2b573f: [lib] Make `displayFailureAlert` optional in `BaseEditUserAvatar`.
Jun 27 2023, 3:30 PM
atul updated the diff for D8316: [lib] Make `displayFailureAlert` optional in `BaseEditUserAvatar`.

rebase and land

Jun 27 2023, 3:28 PM
atul closed D8315: [web] Add "file" `input` to `imageMenuItem` in `EditUserAvatarMenu`.
Jun 27 2023, 2:53 PM
atul committed rCOMMdbfb73e88803: [web] Add "file" `input` to `imageMenuItem` in `EditUserAvatarMenu`.
Jun 27 2023, 2:53 PM
atul updated the diff for D8315: [web] Add "file" `input` to `imageMenuItem` in `EditUserAvatarMenu`.

rebase before landing

Jun 27 2023, 2:40 PM
atul closed D8313: [web] Introduce `large` variant of `ColorSelector`.
Jun 27 2023, 2:35 PM
atul committed rCOMM30f18a849fb5: [web] Introduce `large` variant of `ColorSelector`.
Jun 27 2023, 2:35 PM
atul added a comment to D8276: Introduce NEW_CODE_VERSION constant.

I will change it before EOD today.

Jun 27 2023, 2:29 PM
atul updated the diff for D8313: [web] Introduce `large` variant of `ColorSelector`.

rebase before landing

Jun 27 2023, 2:28 PM

Jun 26 2023

atul published D8318: [lib] Move `selectFromGalleryAndUpdateUserAvatar` from provider to `avatar-hooks` for review.
Jun 26 2023, 10:32 PM
atul published D8316: [lib] Make `displayFailureAlert` optional in `BaseEditUserAvatar` for review.
Jun 26 2023, 10:02 PM
atul requested review of D8315: [web] Add "file" `input` to `imageMenuItem` in `EditUserAvatarMenu`.
Jun 26 2023, 8:27 PM
atul requested changes to D8308: [lib/native] add user-filled to comm icons pack.

The comm-icon-config.json was copied and pasted from the selection.json in this folder from dropbox

Jun 26 2023, 8:08 PM