Looks like a straightforward move, didn't review too carefully
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Jul 24 2023
Adding @ashoat as blocking reviewer here since I don't have enough context on roles/permissions to give this a thorough review
Jul 23 2023
Jul 17 2023
Jul 12 2023
Jul 11 2023
Please use rsquo for all apostrophes, and make sure you adjust the whole competitor-data.js file to reflect that
Why not use arm64 instances? Are they more expensive? Vaguely recall the AWS Graviton instances having better price/performance?
Jun 29 2023
In D8355#246571, @ashoat wrote:
- I worry that the codegenned file might get out of sync with its inputs. Before landing, can you create a Linear task to add a CI job that regenerates the file and confirms there are no changes? We should make sure we complete that task before we ship this project.
In D8343#246573, @ashoat wrote:I'm confused – what was not platform-agnostic about this before? It seems like you still need the state in lib, so I'm not really sure what this diff is achieving
updateImageUserAvatar previously took (selection: NativeMediaSelection) as an argument to satisfy the mediaSelection: NativeMediaSelection field of the object passed to registrationModeRef.current.successCallback when needsUpload is true.
Jun 28 2023
cherrypick and land
include autofocus change
Looks like a pretty straightforward find and replace
Looks good!
Sweet, thanks for addressing feedback
As an aside, might be good to configure docker/build-push-actions for automatically pushing to DockerHub: https://github.com/docker/build-push-action
In D8321#246316, @atul wrote:We need to modify blob URI format to be blob-service://BLOB_HASH
Might be an ignorant question, but...
If two pieces of identical media are uploaded to the blob service, will they have the same blob hash?
It looks like blobHash comes from sha256Hash which is computed by commUtilsModule.sha256 which wraps olm_sha256.
It looks like that function is deterministic, are we including a counter or something in the bytes that we hash?
I'm guessing this is accounted for somewhere, just wondering where/how
We need to modify blob URI format to be blob-service://BLOB_HASH
This change is breaking, but I think nobody except me had any blob-service stored multimedia.
Couple of suggestions inline. Only one that's blocking this diff from being accepted is the use of \n\n for layout, let's break that text apart and use eg padding/margin/etc to lay things out properly.
Let's update CommunityRolesHeaderLeftButton to move the styles outside of the component to unboundStyles and then consume them within the component via the useStyles(...) hook.
Looks reasonable, thanks for including the video
Let's make sure to fix typo before landing
Jun 27 2023
On second thought, this totally could've been squashed with D8341
fix invariant message
Sweet! Could you check web as well before landing?
Let's rename fetchUsernames to fetchAllUsernames before landing.
rebase and land
rebase and land
rebase before landing
I will change it before EOD today.
rebase before landing
Jun 26 2023
The comm-icon-config.json was copied and pasted from the selection.json in this folder from dropbox