fix
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Sep 21 2023
Sep 21 2023
address feedback
In D9262#272502, @ashoat wrote:In the past, we would need to update websites-responders.js when adding a new field to Redux state. Now that Redux state for the web is fetched via an API call, is there a different place we should be updating?
atul updated the diff for D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.
rebase
Sep 20 2023
Sep 20 2023
atul added reviewers for D9235: [lib] introduce createPendingPersonalThread function: ashoat, tomek.
In D9251#272216, @ashoat wrote:Android failure is unrelated
Looks good, left comments but they're purely personal preference so feel free to land as is
atul added a comment to D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.
In D9227#272137, @ashoat wrote:Can you create a GitHub issue on the Expo repo and link it here before landing?
Was there maybe some corresponding keyserver change that needed to be deployed before this release or something?
atul updated the diff for D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`.
toggle withEnableSampleProfiling on DEBUG
In D9233#271801, @ashoat wrote:Okay, please make sure that upstream React Native does this on all builds too before landing!
atul added a comment to D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.
In D9227#271710, @ashoat wrote:Is there a GitHub issue in Expo's GitHub repo for this?
Sep 19 2023
Sep 19 2023
atul committed rCOMMbb73b304a2e6: Bump webpki from 0.22.0 to 0.22.1 in /services/feature-flags (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMeb3e37ff76d6: Bump webpki from 0.22.0 to 0.22.1 in /services/backup (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM5b994dbc623d: Bump webpki from 0.22.0 to 0.22.1 in /services/comm-services-lib (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM88f1887d900f: Bump webpki from 0.22.0 to 0.22.1 in /services/blob (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM92f52ec682b5: Bump webpki from 0.22.0 to 0.22.1 in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM50c9eb9535d9: Bump webpki from 0.22.0 to 0.22.1 in /services/reports (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMe52697f28480: Bump webpki from 0.22.0 to 0.22.1 in /services/commtest (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMd2f9770dca2b: Bump electron from 25.3.0 to 25.8.1 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM55f60fee8c1a: Bump webpki from 0.22.0 to 0.22.1 in /services/identity (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMb2deff08ea76: Bump apollo-server-core from 3.11.1 to 3.12.1 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMcbe88c3eecd2: Bump rustls-webpki from 0.101.3 to 0.101.4 in /services/identity (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM2d17a1619894: Bump activesupport from 6.1.7.3 to 6.1.7.6 in /native (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM3796da87658b: Bump rustls-webpki in /keyserver/addons/rust-node-addon (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMe3acc63103fd: Bump rustls-webpki from 0.101.3 to 0.101.4 in /shared/grpc_clients (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMacd5e89c8ec8: Bump rustls-webpki from 0.100.1 to 0.100.2 in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul updated the diff for D9228: [iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock iOS build.
rebase and land
(I think the profiler gets disabled on prod builds, I'll do a little more research)
In D9233#271796, @ashoat wrote:It seems sketchy to do this in production, especially given it's undocumented. I'm worried about the potential impact on performance. Can we restrict this change to dev builds?
atul published D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig` for review.
atul published D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma for review.
@tomek Sorry, you’re totally right that this is useless. I tested performance with/without this diff in isolation and there was no difference.
Sep 18 2023
Sep 18 2023
atul updated the diff for D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.
rebase around D9211 to land
rebase around D9211 to land
land
atul updated the diff for D9209: [native] Forward `searchInputRef` from `ChatThreadList` to `ChatThreadListSearch`.
merge conflicts
atul updated the diff for D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.
rebase
rebase
rebase
rebase
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
rebase
atul added inline comments to D9209: [native] Forward `searchInputRef` from `ChatThreadList` to `ChatThreadListSearch`.
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
address feedback: early-return
atul added inline comments to D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
rebase
atul updated the diff for D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`.
rebase
atul added inline comments to D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`.
rebase after resolve merge conflict
In D9211#271261, @tomek wrote:Have you tested if memoizing the list is beneficial? FlatList is already memoized internally (PureComponent) so wrapping it with memo shouldn't improve anything, but maybe I'm missing something.
Sep 17 2023
Sep 17 2023
type fn return values as mixed
rebase and land