Attaching videos here since it's the last diff in the stack:
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Oct 10 2023
Oct 10 2023
Rebase
Changing this diff to upgrade Lottie packages instead. Way better idea than forcing a Yarn resolution that may break things in the future
Upgrade Lottie instead
I'm missing some test videos here. Will fill this in after I finish testing.
Fix for landing
Oct 9 2023
Oct 9 2023
ashoat added a comment to D9401: Implement stateful and deferrable notification decryption and use it on iOS in NSE.
Avoiding "request changes" to keep this on other reviewers' queues
Appears to be some miscommunication between Buildkite and Harbormaster. The iOS build appears to have succeeded in Buildkite, but Harbormaster hasn't gotten the message (yet?)
ashoat requested review of D9424: [lib][native][web] Stop passing password up to deleteAccount endpoint.
Oct 7 2023
Oct 7 2023
Good call out, thanks for linking them.
Oct 6 2023
Oct 6 2023
ashoat requested review of D9405: [lib][landing][web] Update patch versions of Rainbowkit and Wagmi.
ashoat accepted D9236: [keyserver] Update keyserver delete account endpoint to not require password.
Ah, my bad... I expected to see the old validator still there, and was surprised to see ignoredArgumentValidator (which I wasn't familiar with). After examining it more closely, it looks like it does what I probably should've concluded it does from the name – ignores all arguments
ashoat requested review of D9403: [keyserver] Modify filename column in MariaDB uploads table to utf8.
ashoat requested changes to D9236: [keyserver] Update keyserver delete account endpoint to not require password.
Copy-pasting from my last review:
Oct 5 2023
Oct 5 2023
Keeping constants that are imported from lots of different places in separate files also helps to avoid import cycles
Adding @ashoat as blocking since I don't have a ton of experience w/ Reanimated and had some issues w/ refactoring Reanimated code in the past (specifically https://phab.comm.dev/D9206#271158)
Oct 4 2023
Oct 4 2023
Thanks @michal!
Thanks!! This looks clean, and I was able to confirm that it works on Safari version 15 running on macOS 12 via lambdatest.com
ashoat added inline comments to D8795: Implement synchronization mechanisms to address process, thread and class level concurrency..
ashoat added inline comments to D9344: [lib] Remove negative lookbehind assertions from chat mention regex.
ashoat requested changes to D9344: [lib] Remove negative lookbehind assertions from chat mention regex.
This diff was really hard to review. I wish somebody else could have done it, but @patryk's limited time to address his regression here (I was told that he had 4 hours) made me feel like I had to be personally involved in order to fix master and unblock releases again ASAP.
Before landing, please add a comment to ENG-4516 to make sure this change is reverted when that task is completed
Oct 3 2023
Oct 3 2023
ashoat requested changes to D9344: [lib] Remove negative lookbehind assertions from chat mention regex.
@marcin should be back tomorrow, but might need some time to catch up on things... might be good to add another reviewer to this
how often are we rotating the token?
ashoat added a comment to D9325: [lib] Introduce a canBeSidebarSource function in each message spec.
This ensures that we'll only ever need to update the specific message spec in one place if we ever want to change this.
Oct 2 2023
Oct 2 2023
ashoat added a comment to D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.
Would be great to get this landed soon as more of the team installs Xcode 15. I looked through Expo's GitHub issues and was surprised I couldn't find anybody else experiencing this, and that the file still had this "issue" on main.
Oct 1 2023
Oct 1 2023
Accepting to unblock, but I have some questions and nits