Fix import

Simplify

Fix a bug

Fix error handling.

Update error handling.

Fix the webpack issue and the urls pointing to the wasm file. Renamed databaseModuleFilePath. Removed unnecessary code in the dockerfile.

• Renamed _generated folder to wasm because it will also include the flow types
• Made the clean-backup-client-wasm skip the flow type file, and the eslint skip only the generated file
• Added a run_wasmpack.sh script (inspired by run_emscripten.sh) as there are two additional actions we need to take and I think this is enough complexity to warrant a script file:
  • remove the autogenerated .gitignore file
  • add "@generated" at the top of the generated JS file
• Update the flow types

Fix build issue

Move the function call to the correct place.

Fix naming

In that case, I will abandon this diff as we will go with a different approach.

Reverted the changes to emscripten buildkite CI job for now, I will add a new buildkite job in a later revision. Add the target folder to the general yarn workspace web clean command.

Old diff, that isn't applicable to the current blob service.

Old diff, that isn't applicable to the current backup service.

Old diff, that isn't applicable to the current backup service.

Seems like the emscripten CI uses emscripten/emsdk:3.1.17 docker image which probably doesn't have yarn. In that case it would probably be easier to introduce a new buildkite job for backup-client-wasm.

Rebase

Rebase

Confused why Phabricator isn't hiding the files in the _generated folder.

Me too, I'm not sure why. I wonder if it's broken? D10838 (a random diff which modified comm_query_executor) also doesn't have hidden files.

Updated the approach to be more similar to the comm_query_executor (so no additional yarn workspace, the rust crate is now part of web).

Move actual WASM compilation to a separate crate -> web/backup-client-wasm.

The only remaining thing to test is removing the [lib] section of the backup_client crate.

The minimal WASM changes triggered the CI error. Now I'm testing removing serde-wasm-bindgen which was the only new WASM crate in native_rust_library (the others already existed as dependencies of comm-opaque2 crate).

Minimal changes for WASM to see if they trigger the CI failure.

Add wasm-only dependencies, without any code changes

Missed lock for the native library

Abandoning as it is an old diff. Something similar to this has been implemented in D10858

Updated the test plan to log out and in.

Nice!

Simplified the codeflow a bit after changes to the previous diff.

Decided to change the approach a bit:

Actually one question: logs won't be captured if backupID isn't set. It's set during compaction creation and only primary device will run this code. So the code is correct, but it will currently still create a session on all devices, including secondary devices. Additionally, on the secondary device, the session will never be cleared (detached). Do you think this could have a performance impact/ it's worth only enabling session if we have created a compaction?

It might be better to for navInfo do the same thing we do for actualizedCalendarQuery - in specific reducer use defaultCalendarQuery(getConfig().platformDetails.platform).