Page MenuHomePhabricator
Feed Advanced Search

Mon, Nov 4

bartek updated the diff for D13125: [native] add ability to remove devices from linked devices bottom sheet.

Add missing bottom padding

Mon, Nov 4, 3:40 AM
bartek attached a referenced file: F3146598: Simulator Screenshot - iPhone 15 Pro - 2024-10-25 at 10.25.13.png.
Mon, Nov 4, 3:39 AM
bartek added a comment to D13125: [native] add ability to remove devices from linked devices bottom sheet.

Thanks for sharing the video! Unfortunately, the button appears over the home pill. Can you make sure that the button appears above the home pill? As an example, take a look at the use of useSafeAreaInsets in KeyserverSelectionBottomSheet

Mon, Nov 4, 3:39 AM

Oct 20 2024

bartek requested review of D13125: [native] add ability to remove devices from linked devices bottom sheet.
Oct 20 2024, 11:27 PM
bartek attached a referenced file: F3000590: simulator-screen-recording-iphone-15-pro-2024-10-18-at-105452_pkSZ9lPA.mp4.
Oct 20 2024, 11:26 PM

Oct 18 2024

bartek updated the diff for D13125: [native] add ability to remove devices from linked devices bottom sheet.

Feedback: Fixed capitalizing, parallelized sending messages. Attached video to the test plan

Oct 18 2024, 2:47 AM
bartek updated the diff for D13262: [native] only display remove device button if current device is primary device.

Feedback: Added the early-exit condition, merged useState, simplified variables

Oct 18 2024, 2:46 AM
bartek attached a referenced file: F3000688: Simulator Screenshot - iPhone 15 Pro - 2024-10-18 at 10.55.22.png.
Oct 18 2024, 2:34 AM
bartek updated the test plan for D13747: [native] Improve device labels on device list screen.
Oct 18 2024, 2:33 AM
bartek updated the test plan for D13125: [native] add ability to remove devices from linked devices bottom sheet.
Oct 18 2024, 2:22 AM
bartek updated the test plan for D13125: [native] add ability to remove devices from linked devices bottom sheet.
Oct 18 2024, 2:21 AM
bartek updated the test plan for D13125: [native] add ability to remove devices from linked devices bottom sheet.
Oct 18 2024, 2:14 AM
bartek updated the test plan for D13125: [native] add ability to remove devices from linked devices bottom sheet.
Oct 18 2024, 2:13 AM

Oct 17 2024

bartek requested review of D13747: [native] Improve device labels on device list screen.
Oct 17 2024, 8:01 AM
bartek added inline comments to D13262: [native] only display remove device button if current device is primary device.
Oct 17 2024, 7:24 AM
bartek updated the diff for D13262: [native] only display remove device button if current device is primary device.
  • Removed ternary from JSX
  • Fixed logic to disallow removing self device
Oct 17 2024, 7:19 AM
bartek updated the diff for D13125: [native] add ability to remove devices from linked devices bottom sheet.

Broadcast device list update to all peers

Oct 17 2024, 6:59 AM
bartek planned changes to D13125: [native] add ability to remove devices from linked devices bottom sheet.
Oct 17 2024, 3:17 AM
bartek commandeered D13125: [native] add ability to remove devices from linked devices bottom sheet.
Oct 17 2024, 3:16 AM
bartek commandeered D13262: [native] only display remove device button if current device is primary device.
Oct 17 2024, 3:16 AM

Oct 15 2024

bartek closed D13711: [terraform] Staging: deploy Blob 1.2.1, Identity 0.42.
Oct 15 2024, 4:40 AM
bartek committed rCOMM98ed7f450672: [terraform] Staging: deploy Blob 1.2.1, Identity 0.42 (authored by bartek).
[terraform] Staging: deploy Blob 1.2.1, Identity 0.42
Oct 15 2024, 4:40 AM
bartek published D13711: [terraform] Staging: deploy Blob 1.2.1, Identity 0.42 for review.
Oct 15 2024, 4:21 AM
bartek closed D13704: [commtest] Add test for removing holders on logout.
Oct 15 2024, 3:43 AM
bartek committed rCOMMb7d8ac4d5ea7: [commtest] Add test for removing holders on logout (authored by bartek).
[commtest] Add test for removing holders on logout
Oct 15 2024, 3:43 AM

Oct 14 2024

bartek closed D13653: [lib] Add handler component for retrying holder processing.
Oct 14 2024, 7:51 AM
bartek committed rCOMM4c7e52542f99: [lib] Add handler component for retrying holder processing (authored by bartek).
[lib] Add handler component for retrying holder processing
Oct 14 2024, 7:51 AM
bartek updated the diff for D13653: [lib] Add handler component for retrying holder processing.

Set timeout to 30s, use throttle

Oct 14 2024, 7:26 AM
bartek closed D13652: [identity] Remove blob holders on logout and account deletion.
Oct 14 2024, 7:20 AM
bartek closed D13651: [identity] Pass Blob client to AuthenticatedService.
Oct 14 2024, 7:20 AM
bartek committed rCOMM7617de987f2d: [identity] Remove blob holders on logout and account deletion (authored by bartek).
[identity] Remove blob holders on logout and account deletion
Oct 14 2024, 7:20 AM
bartek closed D13650: [identity] Add function to remove holders for devices.
Oct 14 2024, 7:20 AM
bartek committed rCOMMbc71ac4c9c70: [identity] Pass Blob client to AuthenticatedService (authored by bartek).
[identity] Pass Blob client to AuthenticatedService
Oct 14 2024, 7:20 AM
bartek committed rCOMMf54b7e5ef580: [identity] Add function to remove holders for devices (authored by bartek).
[identity] Add function to remove holders for devices
Oct 14 2024, 7:20 AM
bartek closed D13649: [comm-lib] Add missing feature dependency to Cargo.toml.
Oct 14 2024, 7:20 AM
bartek closed D13648: [comm-lib][blob-client] Add support for removing holders by tags.
Oct 14 2024, 7:20 AM
bartek committed rCOMMb5d7583ea75d: [comm-lib][blob-client] Add support for removing holders by tags (authored by bartek).
[comm-lib][blob-client] Add support for removing holders by tags
Oct 14 2024, 7:20 AM
bartek committed rCOMM4dd91d929b9c: [comm-lib] Add missing feature dependency to Cargo.toml (authored by bartek).
[comm-lib] Add missing feature dependency to Cargo.toml
Oct 14 2024, 7:20 AM
bartek closed D13647: [blob] Add support for removing holders by tags.
Oct 14 2024, 7:20 AM
bartek committed rCOMM20d0368eeb53: [blob] Add support for removing holders by tags (authored by bartek).
[blob] Add support for removing holders by tags
Oct 14 2024, 7:20 AM
bartek closed D13646: [comm-lib][blob] Add tags support to remove holders request payload.
Oct 14 2024, 7:20 AM
bartek closed D13644: [comm-lib] Add remove_multiple_holders to Blob client.
Oct 14 2024, 7:20 AM
bartek closed D13645: [comm-lib][blob-client] Extract error handling logic.
Oct 14 2024, 7:20 AM
bartek committed rCOMM6c8640428254: [comm-lib][blob] Add tags support to remove holders request payload (authored by bartek).
[comm-lib][blob] Add tags support to remove holders request payload
Oct 14 2024, 7:20 AM
bartek committed rCOMM406f6cc12f66: [comm-lib][blob-client] Extract error handling logic (authored by bartek).
[comm-lib][blob-client] Extract error handling logic
Oct 14 2024, 7:20 AM
bartek committed rCOMMe31290555a24: [comm-lib] Add remove_multiple_holders to Blob client (authored by bartek).
[comm-lib] Add remove_multiple_holders to Blob client
Oct 14 2024, 7:20 AM
bartek closed D13643: [identity] Move backup and tunnelbroker mods to a submodule.
Oct 14 2024, 7:20 AM
bartek closed D13642: [terraform] Provide Blob service addr to Identity env.
Oct 14 2024, 7:20 AM
bartek committed rCOMM51d280b64023: [identity] Move backup and tunnelbroker mods to a submodule (authored by bartek).
[identity] Move backup and tunnelbroker mods to a submodule
Oct 14 2024, 7:20 AM
bartek committed rCOMMcf280265b9f1: [terraform] Provide Blob service addr to Identity env (authored by bartek).
[terraform] Provide Blob service addr to Identity env
Oct 14 2024, 7:19 AM
bartek closed D13641: [identity] Add config for Blob service URL.
Oct 14 2024, 7:19 AM
bartek committed rCOMM450ee7a77ccd: [identity] Add config for Blob service URL (authored by bartek).
[identity] Add config for Blob service URL
Oct 14 2024, 7:19 AM
bartek published D13704: [commtest] Add test for removing holders on logout for review.
Oct 14 2024, 7:18 AM
bartek closed D13705: [terraform] Deploy Tunnelbroker 0.18.1 to prod.
Oct 14 2024, 6:45 AM
bartek committed rCOMMef46992df62c: [terraform] Deploy Tunnelbroker 0.18.1 to prod (authored by bartek).
[terraform] Deploy Tunnelbroker 0.18.1 to prod
Oct 14 2024, 6:45 AM
bartek closed D13703: [tunnelbroker] Ignore CONNECTIONFORCED error message.
Oct 14 2024, 6:45 AM
bartek committed rCOMMed9275b0a10a: [tunnelbroker] Ignore CONNECTIONFORCED error message (authored by bartek).
[tunnelbroker] Ignore CONNECTIONFORCED error message
Oct 14 2024, 6:45 AM
bartek published D13705: [terraform] Deploy Tunnelbroker 0.18.1 to prod for review.
Oct 14 2024, 6:36 AM
bartek updated the diff for D13651: [identity] Pass Blob client to AuthenticatedService.

Improve AWS config init

Oct 14 2024, 5:03 AM
bartek updated the diff for D13650: [identity] Add function to remove holders for devices.

Address feedback - retry RPC fails too

Oct 14 2024, 5:03 AM
bartek updated the diff for D13648: [comm-lib][blob-client] Add support for removing holders by tags.

Remove confusing impl

Oct 14 2024, 5:03 AM
bartek closed D13696: [lib] Make Blob service facts types more strict.
Oct 14 2024, 1:07 AM
bartek committed rCOMMde679c3c4910: [lib] Make Blob service facts types more strict (authored by bartek).
[lib] Make Blob service facts types more strict
Oct 14 2024, 1:07 AM
bartek published D13703: [tunnelbroker] Ignore CONNECTIONFORCED error message for review.
Oct 14 2024, 12:58 AM

Oct 13 2024

bartek updated the diff for D13696: [lib] Make Blob service facts types more strict.

Readonly

Oct 13 2024, 11:16 PM
bartek added inline comments to D13696: [lib] Make Blob service facts types more strict.
Oct 13 2024, 11:15 PM

Oct 10 2024

bartek requested review of D13696: [lib] Make Blob service facts types more strict.
Oct 10 2024, 2:51 PM
bartek closed D13657: [lib] Use batch Blob service endpoints in processHolders action.
Oct 10 2024, 2:06 PM
bartek closed D13656: [lib] Use response validators in multiple-holder calls.
Oct 10 2024, 2:06 PM
bartek committed rCOMM6d07670bce77: [lib] Use batch Blob service endpoints in processHolders action (authored by bartek).
[lib] Use batch Blob service endpoints in processHolders action
Oct 10 2024, 2:06 PM
bartek committed rCOMM4ca6710fe160: [lib] Use response validators in multiple-holder calls (authored by bartek).
[lib] Use response validators in multiple-holder calls
Oct 10 2024, 2:06 PM
bartek closed D13654: [lib] Make types consistent for assignMultipleHolders.
Oct 10 2024, 2:06 PM
bartek closed D13655: [lib] Add types for Blob Service requests and responses.
Oct 10 2024, 2:06 PM
bartek committed rCOMM11b6ebffce87: [lib] Add types for Blob Service requests and responses (authored by bartek).
[lib] Add types for Blob Service requests and responses
Oct 10 2024, 2:06 PM
bartek closed D13618: [blob] Add DB method to query holders by prefix.
Oct 10 2024, 2:06 PM
bartek committed rCOMMf0606882cb1b: [lib] Make types consistent for assignMultipleHolders (authored by bartek).
[lib] Make types consistent for assignMultipleHolders
Oct 10 2024, 2:06 PM
bartek committed rCOMM4762e1c22626: [blob] Add DB method to query holders by prefix (authored by bartek).
[blob] Add DB method to query holders by prefix
Oct 10 2024, 2:06 PM
bartek closed D13617: [blob] Move HTTP request/response types to comm-lib.
Oct 10 2024, 2:06 PM
bartek closed D13616: [terraform] Add index for holder prefixes.
Oct 10 2024, 2:06 PM
bartek committed rCOMMb6f911a681b1: [blob] Move HTTP request/response types to comm-lib (authored by bartek).
[blob] Move HTTP request/response types to comm-lib
Oct 10 2024, 2:06 PM
bartek committed rCOMMdfa118b6b33b: [terraform] Add index for holder prefixes (authored by bartek).
[terraform] Add index for holder prefixes
Oct 10 2024, 2:06 PM
bartek closed D13615: [blob] Store indexable tag in DDB for holders.
Oct 10 2024, 2:06 PM
bartek committed rCOMMb069c41703dd: [blob] Store indexable tag in DDB for holders (authored by bartek).
[blob] Store indexable tag in DDB for holders
Oct 10 2024, 2:06 PM
bartek updated the diff for D13652: [identity] Remove blob holders on logout and account deletion.

Rebase

Oct 10 2024, 12:19 PM
bartek updated the diff for D13657: [lib] Use batch Blob service endpoints in processHolders action.

Rebase

Oct 10 2024, 11:54 AM
bartek updated the diff for D13655: [lib] Add types for Blob Service requests and responses.

Rebase

Oct 10 2024, 11:54 AM
bartek added inline comments to D13653: [lib] Add handler component for retrying holder processing.
Oct 10 2024, 11:43 AM
bartek updated the diff for D13615: [blob] Store indexable tag in DDB for holders.

Add appropriate comment

Oct 10 2024, 11:41 AM
bartek updated the diff for D13657: [lib] Use batch Blob service endpoints in processHolders action.

Rebase

Oct 10 2024, 11:22 AM
bartek updated the diff for D13655: [lib] Add types for Blob Service requests and responses.

Rebase

Oct 10 2024, 11:22 AM
bartek updated the diff for D13657: [lib] Use batch Blob service endpoints in processHolders action.

Use approach with Set of JSON-stringified items

Oct 10 2024, 11:18 AM
bartek updated the diff for D13655: [lib] Add types for Blob Service requests and responses.

Address feedback: Rename types, remove request validators, add comments

Oct 10 2024, 11:03 AM
bartek added a comment to D13655: [lib] Add types for Blob Service requests and responses.
  1. I don't think we need validators for requests, those won't be used
Oct 10 2024, 6:24 AM
bartek updated the diff for D13647: [blob] Add support for removing holders by tags.

Address feedback. Deleting holders by querying tags now requires a s2s token.

Oct 10 2024, 5:31 AM
bartek accepted D13664: [rust-node-addon] syncPlatformDetails client code and bindings.
Oct 10 2024, 12:11 AM

Oct 9 2024

bartek accepted D13660: [terraform] Bump staging Tunnelbroker to 0.18.1.
Oct 9 2024, 5:21 AM
bartek published D13660: [terraform] Bump staging Tunnelbroker to 0.18.1 for review.
Oct 9 2024, 4:31 AM
bartek accepted D13659: [Tunnelbroker] deprecate errors about invalidating device token.
Oct 9 2024, 3:39 AM
bartek published D13642: [terraform] Provide Blob service addr to Identity env for review.
Oct 9 2024, 3:06 AM
bartek published D13641: [identity] Add config for Blob service URL for review.
Oct 9 2024, 3:06 AM