What is a scenario when this could happen?

Makes sense – I'll defer landing this

Thanks, and sorry for all the iteration here!

Regarding context vs registerConfig - I think we should usually prefer the config because it is simpler. The context approach is necessary when the shared logic is placed inside hooks because these can't be shared via the config. But if the final solution uses the context it is also ok - I think it depends on the decisions from the mentioned tasks.

Nice to clean up the additionalParameters stuff

Merge imports

I'm rethinking whether this should have been a separate step, and now considering whether it should be combined with step 1. My apologies for not considering this earlier. I've tried to leave some more detailed comments in this review, and in particular suggest you read the code comment pointing out by my first inline comment below – it gives some context on the "step" mechanism we're using here

In D11694#336156, @tomek wrote:

It seems like we can extract the logic to lib by creating a function that accepts three functions: for fetching the stamped user ID, clearing the DB, and stamping the DB. What do you think about doing this?

Yeah, I'll make sure to do that

Looks good!

Thanks for adding me!

Getting close!

I think the changes are good here, but I feel like the code comments can be improved, and I'd like to review the updated code comments before this is landed

Exciting that there's only one hack left here!

More context in the task, but I'm abandoning this approach in favor of another, more idiomatic/clean one

Let's just fix $ReadOnlyArray and use getMessageForException

Worried about invariants

In this case since I was the author of most of this code, it probably would've been a good idea to put me on the review

Cool. It looks good to me, but I'd like somebody else to take a look at it as well

we'd need another identity rpc that when given a list of userIDs, returns all their associated farcaster infos

Based on that, are any changes necessary here, or is this still ready to review?

PS there are no reviewers on this diff

but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?

Back to you with questions: