Page MenuHomePhabricator
Feed Advanced Search

Aug 18 2023

jon requested changes to D8863: [identity] getInboundKeysForUser RPC implementation.
Aug 18 2023, 12:58 PM

Aug 17 2023

jon added inline comments to D8843: [Nix] Update nixpkgs.
Aug 17 2023, 10:37 AM
jon requested review of D8751: [Keyserver] Refactor getOneTimeKeyValues.
Aug 17 2023, 10:36 AM
jon added a reviewer for D8843: [Nix] Update nixpkgs: kamil.
Aug 17 2023, 10:35 AM
jon updated the diff for D8817: [Treewide] Rename onetime to one_time.

Apply rename to new code from previous diff feedback

Aug 17 2023, 10:28 AM
jon updated the diff for D8816: [Native] Encode platform type in native_rust_library.

Rebase on master

Aug 17 2023, 10:26 AM
jon updated the diff for D8749: [Identity/Tunnelbroker] Add integration tests.

Rebase on master

Aug 17 2023, 10:26 AM
jon updated the diff for D8748: [Identity] Issue refresh_key_request to tunnelbroker.

Rebase on master

Aug 17 2023, 10:25 AM
jon updated the diff for D8723: [Identity] Allow for tunnelbroker endpoint to be configured.

Rebase on master

Aug 17 2023, 10:25 AM
jon updated the diff for D8721: [Identity] Add some utilties with manipulating DDB results.

Rebase on master

Aug 17 2023, 10:25 AM
jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Rebase on master

Aug 17 2023, 10:25 AM
jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Remove now unused import

Aug 17 2023, 10:23 AM
jon updated the diff for D8817: [Treewide] Rename onetime to one_time.

Rebase on changes to previous diffs

Aug 17 2023, 10:10 AM
jon added inline comments to D8748: [Identity] Issue refresh_key_request to tunnelbroker.
Aug 17 2023, 10:05 AM
jon updated the diff for D8748: [Identity] Issue refresh_key_request to tunnelbroker.

Apply suggestions

Aug 17 2023, 10:05 AM
jon added inline comments to D8816: [Native] Encode platform type in native_rust_library.
Aug 17 2023, 9:17 AM
jon updated the diff for D8816: [Native] Encode platform type in native_rust_library.

Include MacOS

Aug 17 2023, 9:02 AM
jon accepted D8803: Implement isStaffRelease method in PlatformSpecificTools.

CMake changes look good to me

Aug 17 2023, 8:33 AM
jon added inline comments to D8843: [Nix] Update nixpkgs.
Aug 17 2023, 8:32 AM
jon updated the diff for D8476: [Keyserver] Publish prekeys to identity service for cron job.

Apply feedback

Aug 17 2023, 8:31 AM
jon added a reviewer for D8475: [Keyserver] Refactor identity utilities: ashoat.
Aug 17 2023, 8:22 AM
jon added a comment to D8475: [Keyserver] Refactor identity utilities.

Address Kamil's feedback

Aug 17 2023, 8:22 AM
jon updated the diff for D8475: [Keyserver] Refactor identity utilities.

Combine imports

Aug 17 2023, 8:22 AM
jon updated the diff for D8475: [Keyserver] Refactor identity utilities.

Use userID when able to

Aug 17 2023, 8:19 AM
jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Capitalize Keyserver and Tunnelbroker in comments

Aug 17 2023, 8:09 AM
jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Add comments in keyserver.js

Aug 17 2023, 8:07 AM
jon added a comment to D7691: [Keyserver] Open websocket connection with tunnelbroker.

Address feedback

Aug 17 2023, 8:06 AM
jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Address feedback

Aug 17 2023, 8:06 AM
jon added inline comments to D8820: [Keyserver/rust] Used shared identity client.
Aug 17 2023, 6:56 AM
jon added inline comments to D8675: [Identity] Add DDB table for one-time-keys.
Aug 17 2023, 6:55 AM
jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Re-introduce comment which was accidentally deleted due to bad rebase

Aug 17 2023, 12:29 AM
jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Address comments, refactor one time key addtions to single method

Aug 17 2023, 12:26 AM
jon requested review of D8843: [Nix] Update nixpkgs.
Aug 17 2023, 12:14 AM
jon updated the diff for D8820: [Keyserver/rust] Used shared identity client.

Address feedback on docker COPY command

Aug 17 2023, 12:08 AM
jon closed D8804: [Shared] Create shared grpc_client library.
Aug 17 2023, 12:01 AM
jon committed rCOMMd89982af1fce: [Shared] Create shared grpc_client library (authored by jon).
[Shared] Create shared grpc_client library
Aug 17 2023, 12:01 AM

Aug 16 2023

jon added inline comments to D8804: [Shared] Create shared grpc_client library.
Aug 16 2023, 11:59 PM
jon requested review of D8820: [Keyserver/rust] Used shared identity client.
Aug 16 2023, 12:59 PM
jon accepted D8835: [blob-service] Standardize localstack config.
Aug 16 2023, 8:50 AM
jon updated the diff for D8804: [Shared] Create shared grpc_client library.

Address feedback

Aug 16 2023, 8:01 AM

Aug 15 2023

jon updated the diff for D8817: [Treewide] Rename onetime to one_time.

Fix some missed comments

Aug 15 2023, 10:50 AM
jon planned changes to D8817: [Treewide] Rename onetime to one_time.

Missed some comments

Aug 15 2023, 10:48 AM
jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Missed a comment

Aug 15 2023, 10:44 AM
jon added a comment to D8675: [Identity] Add DDB table for one-time-keys.

Address feedback

Aug 15 2023, 10:41 AM
jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Re-apply feedback which was lost during bad arc patch

Aug 15 2023, 10:39 AM
jon planned changes to D8675: [Identity] Add DDB table for one-time-keys.

uggh, not sure why, but I got a stale patch when doing the one-time refactor

Aug 15 2023, 10:33 AM
jon requested review of D8817: [Treewide] Rename onetime to one_time.
Aug 15 2023, 10:20 AM
jon requested review of D8816: [Native] Encode platform type in native_rust_library.
Aug 15 2023, 9:52 AM
jon accepted D8501: [identity] log out user RPC.

Accepting to not block progress.

Aug 15 2023, 9:42 AM
jon updated the diff for D8721: [Identity] Add some utilties with manipulating DDB results.

Propagate onetime -> one-time changes

Aug 15 2023, 7:20 AM
jon requested review of D8722: [Identity] Implement GetKeyserverKeys.
Aug 15 2023, 7:11 AM
jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

"onetime" -> "one-time" for this diff

Aug 15 2023, 6:59 AM

Aug 14 2023

jon closed D8642: Allow for devices to register as a keyserver.
Aug 14 2023, 7:30 AM
jon committed rCOMMc99660536068: Allow for devices to register as a keyserver (authored by jon).
Allow for devices to register as a keyserver
Aug 14 2023, 7:30 AM
jon requested review of D8804: [Shared] Create shared grpc_client library.
Aug 14 2023, 7:18 AM

Aug 11 2023

jon planned changes to D8675: [Identity] Add DDB table for one-time-keys.
Aug 11 2023, 8:14 AM

Aug 10 2023

jon accepted D8577: [Docs] Document keyserver deployment.

we can move the expansion of commapp_url details to another diff, as ashoat mentioned

Aug 10 2023, 11:51 AM
jon requested changes to D8577: [Docs] Document keyserver deployment.
Aug 10 2023, 11:42 AM

Aug 9 2023

jon requested changes to D8765: [identity] more helpers for identity service.
Aug 9 2023, 5:36 PM
jon updated the diff for D8723: [Identity] Allow for tunnelbroker endpoint to be configured.

Rebase on changes

Aug 9 2023, 5:30 PM
jon added inline comments to D8722: [Identity] Implement GetKeyserverKeys.
Aug 9 2023, 5:13 PM
jon updated the diff for D8722: [Identity] Implement GetKeyserverKeys.

Revert back to using initial "read all" logic

Aug 9 2023, 5:11 PM
jon added a comment to D8675: [Identity] Add DDB table for one-time-keys.
In D8675#259065, @varun wrote:

sorry I didn't catch this earlier but we should be consistent about onetime vs one-time/oneTime/OneTime/one_time. the latter matches the white paper, so we should remove all uses of the former. i noted a couple instances where we're using the wrong format inline, but it's not an exhaustive list. some other comments inline too.

also, we have to update the add_user_to_users_table function, right?

Aug 9 2023, 4:04 PM
jon updated the diff for D8722: [Identity] Implement GetKeyserverKeys.

Address feedback

Aug 9 2023, 2:45 PM

Aug 8 2023

jon added a comment to D8642: Allow for devices to register as a keyserver.

We need to make sure that the identity service has the codeVersion of the client. When we launch the device list work, the identity service will need to be able to identify whether a given client is able to support the "new" workflow and function as a primary device. This is just one example of many... it's critical that Comm services are aware of the client version

Aug 8 2023, 4:07 PM
jon planned changes to D8722: [Identity] Implement GetKeyserverKeys.
Aug 8 2023, 10:56 AM
jon added inline comments to D8750: [Keyserver/rust] Implement upload_one_time_keys to identity service.
Aug 8 2023, 10:35 AM
jon added inline comments to D8675: [Identity] Add DDB table for one-time-keys.
Aug 8 2023, 10:33 AM
jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Chunkify other BatchWriteItem

Aug 8 2023, 10:32 AM
jon added inline comments to D8675: [Identity] Add DDB table for one-time-keys.
Aug 8 2023, 9:52 AM
jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Address feedback

Aug 8 2023, 9:52 AM
jon added inline comments to D8642: Allow for devices to register as a keyserver.
Aug 8 2023, 9:28 AM
jon requested changes to D8761: [identity] db method to get inbound keys for user.

I landed D8627, please rebase

Aug 8 2023, 9:02 AM
jon closed D8627: [Identity] Remove static lifetime constraint on DBItemError.
Aug 8 2023, 9:01 AM
jon committed rCOMM83836ecf16b7: [Identity] Remove static lifetime constraint on DBItemError (authored by jon).
[Identity] Remove static lifetime constraint on DBItemError
Aug 8 2023, 9:01 AM
jon closed D8607: [Identity] Refactor DB error logic.
Aug 8 2023, 9:00 AM
jon closed D8606: [Identity] Refactor get user_id and device_id.
Aug 8 2023, 9:00 AM
jon committed rCOMMe2d369186e97: [Identity] Refactor DB error logic (authored by jon).
[Identity] Refactor DB error logic
Aug 8 2023, 9:00 AM
jon committed rCOMM9a3688162429: [Identity] Refactor get user_id and device_id (authored by jon).
[Identity] Refactor get user_id and device_id
Aug 8 2023, 9:00 AM
jon closed D8605: [Protos] Move GetKeyserverInfo to authtenticated service.
Aug 8 2023, 9:00 AM
jon committed rCOMM2406ff73d295: [Protos] Move GetKeyserverInfo to authtenticated service (authored by jon).
[Protos] Move GetKeyserverInfo to authtenticated service
Aug 8 2023, 9:00 AM
jon accepted D8715: [terraform] Expose shared dynamodb tables.
Aug 8 2023, 8:52 AM
jon accepted D8743: [terraform][blob] Use different S3 bucket for staging.
Aug 8 2023, 8:51 AM
jon accepted D8742: [blob-service] Make S3 bucket configurable.
Aug 8 2023, 8:51 AM
jon accepted D8716: [terraform] Add missing Instance Profile resource.
Aug 8 2023, 8:50 AM
jon accepted D8714: [terraform] Add S3 bucket name suffix.
Aug 8 2023, 8:31 AM
jon accepted D8713: [terraform] Use subdomain for staging services.

makes sense to me

Aug 8 2023, 8:30 AM
jon accepted D8731: [tunnelbroker] remove unused dependencies.
Aug 8 2023, 8:25 AM
jon closed D8473: [Keyserver/rust] Add publish_prekeys implementation.
Aug 8 2023, 7:56 AM
jon committed rCOMM7524181bb2d3: [Keyserver/rust] Add publish_prekeys implementation (authored by jon).
[Keyserver/rust] Add publish_prekeys implementation
Aug 8 2023, 7:56 AM
jon closed D8463: [Services-test/identity] Refactor create_device.
Aug 8 2023, 7:56 AM
jon closed D8464: [Identity] Implement RefreshUserPreKey.
Aug 8 2023, 7:56 AM
jon committed rCOMM921c2da41054: [Services-test/identity] Refactor create_device (authored by jon).
[Services-test/identity] Refactor create_device
Aug 8 2023, 7:56 AM
jon committed rCOMM3e9860bd743d: [Identity] Implement RefreshUserPreKey (authored by jon).
[Identity] Implement RefreshUserPreKey
Aug 8 2023, 7:56 AM
jon closed D8434: [Identity] Add authenticated gRPC service.
Aug 8 2023, 7:56 AM
jon committed rCOMMe9f1b63891fa: [Identity] Add authenticated gRPC service (authored by jon).
[Identity] Add authenticated gRPC service
Aug 8 2023, 7:56 AM

Aug 7 2023

jon planned changes to D8752: [Keyserver] Upload new onetime keys to identity service when requested.

need to do a another async/await pass, and hit on commentary

Aug 7 2023, 11:06 AM
jon added inline comments to D8748: [Identity] Issue refresh_key_request to tunnelbroker.
Aug 7 2023, 9:21 AM
jon requested review of D8752: [Keyserver] Upload new onetime keys to identity service when requested.
Aug 7 2023, 8:42 AM
jon updated the diff for D8464: [Identity] Implement RefreshUserPreKey.

Rebase on master

Aug 7 2023, 8:34 AM