What happens if you deploy a debug build to an iOS device that previously had a release build? It would be able to keep using the previously determined encryptionKey, right? (And vice versa, going from debug to release?)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mar 29 2023
Looks good, minor note about swapping out Lodash
Looks good!
Accepting, but noted concerns about filename potentially leaking information in "Cryptography discussion" if you could take a look
Some questions inline
Mar 28 2023
Please address @ashoat's feedback before landing.
Provided a fake encrypted mediaInfo prop, opened the modal and ensured that a spinner is displayed while decryption is in progress and controls are hidded. After successful decryption, the video starts playing.
Thanks @kamil for taking a thorough look at this diff!
Thanks for including aunt sets
Thanks for including a test (and adding a comment explaining what's happening)
True that makes sense
This looks good to me, but full disclosure I have limited familiarity with this side of the codebase... so please keep that in mind before landing (aka maybe consider having someone else take a final look)
Might be missing something, but should we add a migration to native that adds commServicesAccessToken field to Redux if it doesn't already exist?
Thanks for annotating the changes with explanations
(Please address @ashoat's feedback before landing)
(Please address @ashoat's feedback before landing)
(Please address @ashoat's feedback before landing)
(Please address @ashoat's feedback before landing)
rebase and land
rebase and land
Mar 27 2023
rebase and land
Is this diff still in [draft] state? Or is it ready to review?
Mar 26 2023
change avatar !== null check to avatar truthiness check
rebase before addressing all feedback
rebase and land
Mar 25 2023
Mar 24 2023
fix
rebase and land
don't include avatar if null (this should also now be landable as is)
Let's avoid setting avatar unless it exists, and only set it for a given UserInfo when that user calls the upstream methods to actually set their avatar. (At which point UPDATE_USER updates should help us avoid state inconsistencies.)
There shouldn't need to be any native release associated with this landing then, correct?
rebase and land
rebase and land
Mar 23 2023
rebase and land
rebase and land
(Really great to see we're adding DB tests right off the bat)
Do you think we can get rid of these alerts now? Having to click through the alerts is kind of getting annoying on iOS Simulator.
Mar 22 2023
[will add screenshot shortly]
rebase before landing
Mar 21 2023
Mar 20 2023
Wonder if there's a way to catch this sort of thing with CI