Page MenuHomePhabricator
Feed Advanced Search

Mar 29 2023

atul added a comment to D7243: [native] Set SQLite DB password to `DEBUG` for `DEBUG` builds.

What happens if you deploy a debug build to an iOS device that previously had a release build? It would be able to keep using the previously determined encryptionKey, right? (And vice versa, going from debug to release?)

Mar 29 2023, 3:01 PM
atul published D7243: [native] Set SQLite DB password to `DEBUG` for `DEBUG` builds for review.
Mar 29 2023, 1:50 PM
atul accepted D7235: [lib] Support encrypted media types in updateMultimediaMessageMediaAction.

Looks good, minor note about swapping out Lodash

Mar 29 2023, 1:03 PM
atul accepted D7237: [keyserver/lib] Optimistically create the toggle pin message.

Looks good!

Mar 29 2023, 12:42 PM
atul accepted D7234: [native] Add function to encrypt media during media mission.

Accepting, but noted concerns about filename potentially leaking information in "Cryptography discussion" if you could take a look

Mar 29 2023, 12:29 PM
atul accepted D7242: [landing] add ted to team page.
Mar 29 2023, 12:10 PM
atul accepted D7233: [lib][native] Add function to encrypt files.

Some questions inline

Mar 29 2023, 12:09 PM
atul accepted D7232: [native] Extract LoadableImage component.
Mar 29 2023, 12:01 PM

Mar 28 2023

atul accepted D7211: [keyserver/lib/native] Store the number of pinned messages in ThreadInfo.

Please address @ashoat's feedback before landing.

Mar 28 2023, 4:47 PM
atul accepted D7226: [native] VideoPlaybackModal support for encrypted video.

Provided a fake encrypted mediaInfo prop, opened the modal and ensured that a spinner is displayed while decryption is in progress and controls are hidded. After successful decryption, the video starts playing.

Mar 28 2023, 4:30 PM
atul accepted D7202: [native] Add pinned_count column to SQLite threads table.

Thanks @kamil for taking a thorough look at this diff!

Mar 28 2023, 4:23 PM
atul accepted D7228: [native] Fixes for handling encrypted media messages.
Mar 28 2023, 4:18 PM
atul accepted D7224: [native] Add function to decrypt media file.
Mar 28 2023, 4:17 PM
atul accepted D7170: [lib] Store encrypted messages in Client DB.

Thanks for including aunt sets

Mar 28 2023, 4:14 PM
atul accepted D7222: [lib] Add function to calculate padding size.

Thanks for including a test (and adding a comment explaining what's happening)

Mar 28 2023, 3:54 PM
atul added a comment to D7212: [lib][web][native] Introduce commServicesAccessToken to Redux state.

True that makes sense

Mar 28 2023, 1:42 PM
atul accepted D7193: Save message instantly to redux for both foregrounded and backgrounded app.

This looks good to me, but full disclosure I have limited familiarity with this side of the codebase... so please keep that in mind before landing (aka maybe consider having someone else take a final look)

Mar 28 2023, 1:35 PM
atul accepted D7210: [web] render thread avatars on chat screen.
Mar 28 2023, 1:34 PM
atul accepted D7208: [web] render user avatars in typeahead tooltip.
Mar 28 2023, 1:33 PM
atul accepted D7212: [lib][web][native] Introduce commServicesAccessToken to Redux state.

Might be missing something, but should we add a migration to native that adds commServicesAccessToken field to Redux if it doesn't already exist?

Mar 28 2023, 1:27 PM
atul accepted D7201: [web][keyserver] Webpack config and client logic to access opaque-ke2 WASM bindings.

Thanks for annotating the changes with explanations

Mar 28 2023, 1:25 PM
atul accepted D7209: [web] render thread avatars in the community drawer.
Mar 28 2023, 1:22 PM
atul added a comment to D7208: [web] render user avatars in typeahead tooltip.

(Please address @ashoat's feedback before landing)

Mar 28 2023, 1:22 PM
atul accepted D7207: [web] render user avatars in thread memebers modal.

(Please address @ashoat's feedback before landing)

Mar 28 2023, 1:21 PM
atul accepted D7206: [web] render user avatars in chat thread composer.

(Please address @ashoat's feedback before landing)

Mar 28 2023, 1:20 PM
atul accepted D7205: [web] render user avatars in account relationship lists.

(Please address @ashoat's feedback before landing)

Mar 28 2023, 1:20 PM
atul accepted D7196: [web] render user avatars in message reactions modal.
Mar 28 2023, 1:09 PM
atul closed D7203: [keyserver] Update `fetchKnownUserInfos` to include `avatar` field in `UserInfo`s.
Mar 28 2023, 12:46 PM
atul committed rCOMMe2deb3803a31: [keyserver] Update `fetchKnownUserInfos` to include `avatar` field in… (authored by atul).
[keyserver] Update `fetchKnownUserInfos` to include `avatar` field in…
Mar 28 2023, 12:46 PM
atul updated the diff for D7203: [keyserver] Update `fetchKnownUserInfos` to include `avatar` field in `UserInfo`s.

rebase and land

Mar 28 2023, 12:43 PM
atul closed D7204: [keyserver] Get rid of `ExperimentalWarning`s in `keyserver` logs.
Mar 28 2023, 11:22 AM
atul committed rCOMM599a7bbe3351: [keyserver] Get rid of `ExperimentalWarning`s in `keyserver` logs (authored by atul).
[keyserver] Get rid of `ExperimentalWarning`s in `keyserver` logs
Mar 28 2023, 11:22 AM
atul updated the diff for D7204: [keyserver] Get rid of `ExperimentalWarning`s in `keyserver` logs.

rebase and land

Mar 28 2023, 11:09 AM

Mar 27 2023

atul updated the diff for D7204: [keyserver] Get rid of `ExperimentalWarning`s in `keyserver` logs.

rebase and land

Mar 27 2023, 4:14 PM
atul published D7204: [keyserver] Get rid of `ExperimentalWarning`s in `keyserver` logs for review.
Mar 27 2023, 1:42 PM
atul published D7203: [keyserver] Update `fetchKnownUserInfos` to include `avatar` field in `UserInfo`s for review.
Mar 27 2023, 1:42 PM
atul committed rCOMMc47a3162493b: Bump openssl from 0.10.44 to 0.10.48 in /services/commtest (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump openssl from 0.10.44 to 0.10.48 in /services/commtest
Mar 27 2023, 12:11 PM
atul committed rCOMMca10b4527b7d: Bump openssl from 0.10.42 to 0.10.48 in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump openssl from 0.10.42 to 0.10.48 in /services/tunnelbroker
Mar 27 2023, 12:10 PM
atul requested changes to D7187: [native] extend avatar component to handle images.

Is this diff still in [draft] state? Or is it ready to review?

Mar 27 2023, 12:03 PM
atul accepted D7163: [native] Introduce useNativeMessageListData and NativeChatMessageItem.
Mar 27 2023, 12:01 PM
atul accepted D7194: [web] render user avatar in account screen.
Mar 27 2023, 10:37 AM
atul accepted D7192: [web] introduce avatar component.
Mar 27 2023, 10:35 AM

Mar 26 2023

atul closed D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
Mar 26 2023, 3:08 PM
atul committed rCOMM83252ba96c76: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s (authored by atul).
[keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s
Mar 26 2023, 3:08 PM
atul added inline comments to D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
Mar 26 2023, 12:35 PM
atul updated the diff for D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.

change avatar !== null check to avatar truthiness check

Mar 26 2023, 12:35 PM
atul updated the diff for D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.

rebase before addressing all feedback

Mar 26 2023, 12:34 PM
atul closed D7176: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on `codeVersion`.
Mar 26 2023, 12:10 PM
atul committed rCOMM6d756a2c3195: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on… (authored by atul).
[keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on…
Mar 26 2023, 12:10 PM
atul updated the diff for D7176: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on `codeVersion`.

rebase and land

Mar 26 2023, 12:08 PM

Mar 25 2023

atul requested review of D7176: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on `codeVersion`.
Mar 25 2023, 2:33 PM

Mar 24 2023

atul updated the diff for D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.

fix

Mar 24 2023, 2:00 PM
atul closed D7172: [cargo] Add `--release` flag to native library/tunnelbroker builds.
Mar 24 2023, 12:30 PM
atul committed rCOMMf96f662517f4: [cargo] Add `--release` flag to native library/tunnelbroker builds (authored by atul).
[cargo] Add `--release` flag to native library/tunnelbroker builds
Mar 24 2023, 12:30 PM
atul accepted D7173: Allow while(true) in the JS codebase.
Mar 24 2023, 12:29 PM
atul added inline comments to D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Mar 24 2023, 12:27 PM
atul updated the diff for D7172: [cargo] Add `--release` flag to native library/tunnelbroker builds.

rebase and land

Mar 24 2023, 12:17 PM
atul added inline comments to D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
Mar 24 2023, 11:59 AM
atul updated the diff for D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.

don't include avatar if null (this should also now be landable as is)

Mar 24 2023, 11:57 AM
atul updated the summary of D7172: [cargo] Add `--release` flag to native library/tunnelbroker builds.
Mar 24 2023, 11:47 AM
atul published D7172: [cargo] Add `--release` flag to native library/tunnelbroker builds for review.
Mar 24 2023, 11:46 AM
atul added a comment to D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.

Let's avoid setting avatar unless it exists, and only set it for a given UserInfo when that user calls the upstream methods to actually set their avatar. (At which point UPDATE_USER updates should help us avoid state inconsistencies.)

Mar 24 2023, 11:37 AM
atul added a comment to D7164: [keyserver] Launch NSE for build 199 and above.

There shouldn't need to be any native release associated with this landing then, correct?

Mar 24 2023, 11:33 AM
atul accepted D7164: [keyserver] Launch NSE for build 199 and above.
Mar 24 2023, 11:33 AM
atul closed D7157: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo`.
Mar 24 2023, 11:33 AM
atul committed rCOMM59208c2a222a: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo` (authored by atul).
[keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo`
Mar 24 2023, 11:33 AM
atul updated the diff for D7157: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo`.

rebase and land

Mar 24 2023, 11:32 AM
atul closed D7156: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success`.
Mar 24 2023, 11:28 AM
atul committed rCOMM7927b6a593cb: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success` (authored by atul).
[lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success`
Mar 24 2023, 11:28 AM
atul updated the diff for D7156: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success`.

rebase and land

Mar 24 2023, 10:58 AM
atul resigned from D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.
Mar 24 2023, 10:55 AM
atul resigned from D6929: [keyserver] Add a function to toggle the pin status of a message.
Mar 24 2023, 10:54 AM

Mar 23 2023

atul published D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s for review.
Mar 23 2023, 5:30 PM
atul closed D7161: [ios] Add `--repo-update` to `pod install` command.
Mar 23 2023, 2:08 PM
atul committed rCOMMe261fbedae47: [ios] Add `--repo-update` to `pod install` command (authored by atul).
[ios] Add `--repo-update` to `pod install` command
Mar 23 2023, 2:08 PM
atul updated the diff for D7161: [ios] Add `--repo-update` to `pod install` command.

rebase and land

Mar 23 2023, 2:07 PM
atul closed D7152: [keyserver] Introduce `updateUserAvatar` updater and use in `updateUserAvatarResponder`.
Mar 23 2023, 1:42 PM
atul committed rCOMM50260a36931b: [keyserver] Introduce `updateUserAvatar` updater and use in… (authored by atul).
[keyserver] Introduce `updateUserAvatar` updater and use in…
Mar 23 2023, 1:42 PM
atul updated the diff for D7152: [keyserver] Introduce `updateUserAvatar` updater and use in `updateUserAvatarResponder`.

rebase and land

Mar 23 2023, 1:39 PM
atul updated the test plan for D7161: [ios] Add `--repo-update` to `pod install` command.
Mar 23 2023, 1:38 PM
atul published D7161: [ios] Add `--repo-update` to `pod install` command for review.
Mar 23 2023, 1:32 PM
atul added a comment to D7124: [web-db] add unit tests for draft store queries.

(Really great to see we're adding DB tests right off the bat)

Mar 23 2023, 12:51 PM
atul added a comment to D5995: [native] clear database when malformation is detected.

Do you think we can get rid of these alerts now? Having to click through the alerts is kind of getting annoying on iOS Simulator.

Mar 23 2023, 11:25 AM
atul updated the test plan for D7156: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success`.
Mar 23 2023, 11:02 AM
atul updated the test plan for D7157: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo`.
Mar 23 2023, 10:51 AM
atul published D7157: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo` for review.
Mar 23 2023, 10:51 AM
atul published D7156: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success` for review.
Mar 23 2023, 10:33 AM

Mar 22 2023

atul published D7152: [keyserver] Introduce `updateUserAvatar` updater and use in `updateUserAvatarResponder` for review.
Mar 22 2023, 11:21 PM
atul added a comment to D7126: [lib] Introduce `updateUserAvatar` to `user-actions`.

[will add screenshot shortly]

Mar 22 2023, 10:09 PM
atul closed D7126: [lib] Introduce `updateUserAvatar` to `user-actions`.
Mar 22 2023, 9:22 PM
atul committed rCOMM58a87534b387: [lib] Introduce `updateUserAvatar` to `user-actions` (authored by atul).
[lib] Introduce `updateUserAvatar` to `user-actions`
Mar 22 2023, 9:22 PM
atul updated the diff for D7126: [lib] Introduce `updateUserAvatar` to `user-actions`.

rebase before landing

Mar 22 2023, 9:19 PM

Mar 21 2023

atul added a reverting change for rCOMM8b0ff97f2785: [native] Temporary changes for staff release: rCOMM56fdc906a28d: Revert "[native] Temporary changes for staff release".
Mar 21 2023, 1:02 PM
atul committed rCOMM56fdc906a28d: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
Mar 21 2023, 1:01 PM
atul committed rCOMMd30d6383ffe2: [native] `codeVersion` -> 204 (authored by atul).
[native] `codeVersion` -> 204
Mar 21 2023, 1:01 PM
atul committed rCOMM8b0ff97f2785: [native] Temporary changes for staff release (authored by atul).
[native] Temporary changes for staff release
Mar 21 2023, 1:01 PM
atul committed rCOMMc707c5b9a7a6: [native] `codeVersion` -> 203 (authored by atul).
[native] `codeVersion` -> 203
Mar 21 2023, 1:01 PM
atul requested review of D7126: [lib] Introduce `updateUserAvatar` to `user-actions`.
Mar 21 2023, 9:38 AM

Mar 20 2023

atul added a comment to D7111: [lib] Fix `TUnion`/`TInterface` imports.

Wonder if there's a way to catch this sort of thing with CI

Mar 20 2023, 4:55 PM
atul closed D7111: [lib] Fix `TUnion`/`TInterface` imports.
Mar 20 2023, 4:52 PM