About the indicator: in the issues comments it has been decided that this button will open a modal instead of a page. For modals we don't have indicators
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 22 2023
Feb 22 2023
Feb 21 2023
Feb 21 2023
Feb 16 2023
Feb 16 2023
Feb 15 2023
Feb 15 2023
Two things:
- I think we need some kind of indicator (like a purple bottom border for Chat/Calendars buttons), seems really confusing to me from the user's perspective that there is no difference between the selected and not selected apps tab. Hover also will be great.
- Look like it will happen soon, but what if there will be a lot of apps? Shouldn't + be sticked to the right side of the container, always visible, and all items scrollable (talking about situation when entire row is filled with apps)? Or at least all items with '+' button scrollable.
Looks great!
(I know there is an example in linear, but I would love a screenshot/video in the summary)
Feb 14 2023
Feb 14 2023
Feb 13 2023
Feb 13 2023
Feb 8 2023
Feb 8 2023
kamil accepted D6645: [web] Add to calendar filters reducer logic for handling the COMMUNITY filters.
I think the order of diffs in this stack is a little bit mixed, here you use filteredCommunityThreadIDs which is introduced in child revision, but overall looks good
Feb 2 2023
Feb 2 2023
kamil committed rCOMM99ec0f13fd04: [keyserver] enable accepting policies feature (authored by kamil).
[keyserver] enable accepting policies feature
[landing] update Privacy Policy content
fix typo
Feb 1 2023
Feb 1 2023
update version to 181
Requesting review to get the answer
kamil committed rCOMM082d3e630a68: [native/Android] initialize database on app start (authored by kamil).
[native/Android] initialize database on app start
kamil committed rCOMM4e11a2611ec4: [native/iOS] initialize database on app start (authored by kamil).
[native/iOS] initialize database on app start
kamil committed rCOMM78591724e16f: [native] throw exception when migration process will fail (authored by kamil).
[native] throw exception when migration process will fail
kamil committed rCOMM54db816d9eb9: [native] clear database when malformation is detected (authored by kamil).
[native] clear database when malformation is detected
kamil committed rCOMM41de0a56c500: [native/CommCoreModule] add function check if database is malformed and needs… (authored by kamil).
[native/CommCoreModule] add function check if database is malformed and needs…
kamil committed rCOMMe7245b91cfae: [native] add function to set database status after successful structure creation (authored by kamil).
[native] add function to set database status after successful structure creation
kamil committed rCOMMf6ff2dbc33a1: [native] add function to initialize `DatabaseQueryExecutor` (authored by kamil).
[native] add function to initialize `DatabaseQueryExecutor`
update message
Jan 31 2023
Jan 31 2023
kamil committed rCOMM97d98f413845: [native/Android] attach operations on `SecureStore` and `PlatformSpecificTools`… (authored by kamil).
[native/Android] attach operations on `SecureStore` and `PlatformSpecificTools`…
kamil updated the diff for D6416: [native/Android] attach operations on `SecureStore` and `PlatformSpecificTools` to JVM.
rename NativeAndroidAccessible -> NativeAndroidAccessProvider
Jan 30 2023
Jan 30 2023
remove unused imports after rebase
make initialize part of initializeQueryExecutor
move call into attemptDatabaseInitialization and test notifs
rename source
rename source
kamil updated the diff for D5993: [native/CommCoreModule] add function check if database is malformed and needs deletion.
rebase
kamil added inline comments to D5992: [native] add function to set database status after successful structure creation.
kamil updated the diff for D5992: [native] add function to set database status after successful structure creation.
add missing #include <mutex> and comment
use throw instead of terminate, add SQLiteQueryExecutor::initialize to DatabaseManager::initializeQueryExecutor
Jan 27 2023
Jan 27 2023
kamil committed rCOMM9d2a81f963e4: [native] add `clearSensitiveData` to Database Manager (authored by kamil).
[native] add `clearSensitiveData` to Database Manager
Jan 26 2023
Jan 26 2023
kamil committed rCOMM3f22262a05db: [keyserver] disable requiring legal policies for `update_device_token` endpoint (authored by kamil).
[keyserver] disable requiring legal policies for `update_device_token` endpoint
kamil published D6395: [keyserver] disable requiring legal policies for `update_device_token` endpoint for review.
kamil committed rCOMM5fb26991e4cf: [native] track socket crashes and fetch data/logout user when needed (authored by kamil).
[native] track socket crashes and fetch data/logout user when needed
kamil committed rCOMM5b7e1be7c108: [keyserver] disable injecting redux state when policies are not accepted (authored by kamil).
[keyserver] disable injecting redux state when policies are not accepted
kamil committed rCOMMa10f46bf7dc3: [keyserver] disable socket connection when policies are not accepted (authored by kamil).
[keyserver] disable socket connection when policies are not accepted
[lib] validate policies after user login
kamil updated the diff for D6250: [native] track socket crashes and fetch data/logout user when needed.
rebase before landing
kamil updated the diff for D6094: [keyserver] disable injecting redux state when policies are not accepted.
rebase before landing
kamil updated the diff for D6093: [keyserver] disable socket connection when policies are not accepted.
rebase before landing
rebase before landing, base policy fetchers on viewer.id instead of entire object
Jan 25 2023
Jan 25 2023
kamil updated the diff for D6250: [native] track socket crashes and fetch data/logout user when needed.
improve code
re-requesting review to confirm my understanding of setNewSession is correct
avoid setting field if it not exists
Jan 23 2023
Jan 23 2023
Jan 20 2023
Jan 20 2023
kamil added inline comments to D6250: [native] track socket crashes and fetch data/logout user when needed.
kamil updated the diff for D6250: [native] track socket crashes and fetch data/logout user when needed.
update naming, add source, handle refetchUserData exceptions, improve code
kamil updated the diff for D6094: [keyserver] disable injecting redux state when policies are not accepted.
update promises handling
wrap promise inside Promise.all, add notAcknowledgedPolicies to SIWE responder, update LogInResponse fields to be read only
kamil committed rCOMMa027ed5d94af: [keyserver] move logic to fetch not acknowledged policies to separate function (authored by kamil).
[keyserver] move logic to fetch not acknowledged policies to separate function
Jan 12 2023
Jan 12 2023
kamil published D6250: [native] track socket crashes and fetch data/logout user when needed for review.
kamil added inline comments to D6094: [keyserver] disable injecting redux state when policies are not accepted.
kamil updated the diff for D6094: [keyserver] disable injecting redux state when policies are not accepted.
refactor promises
kamil updated the diff for D6093: [keyserver] disable socket connection when policies are not accepted.
rebase
EDIT: tested for SIWE
In D6092#183060, @ashoat wrote:We care only about logging in manually performed by the user.
Can you remind me why that is?
rely on LOG_IN_SUCCESS action
Jan 10 2023
Jan 10 2023
kamil updated the diff for D6091: [keyserver] move logic to fetch not acknowledged policies to separate function.
rebase
Jan 9 2023
Jan 9 2023
avoid repeated code