Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

atul closed D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.
Thu, May 2, 9:59 AM
atul committed rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[lib] Replace `threadHasPermission` with `useThreadHasPermission` in…
Thu, May 2, 9:59 AM
Harbormaster failed remote builds in B28633: Diff 39749 for D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`!
Thu, May 2, 9:58 AM
marcin added a comment to D11858: Specify android notification priority based on its visual action.

It looks like @marcin's investigation has shown that ChatGPT is wrong, and he is pursuing a different theory that perhaps Android is punishing us for sending non-visual notifs (rescind and badge-only) with high priority. I think this is a good direction to explore.

I think ChatGPT was right about setting android: {priority: 'high'} - I just found that this is already handled by firebase-admin. I think that setting priority to high (which we are currently doing) for badge updates and rescinds might be a mistake based on this docs: https://firebase.google.com/docs/cloud-messaging/concept-options#setting-the-priority-of-a-message

Thu, May 2, 9:50 AM
atul updated the diff for D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.

address feedback

Thu, May 2, 9:47 AM
ginsu accepted D11859: [lib] Rename action type to set aux user fids.
Thu, May 2, 9:25 AM
ashoat requested changes to D11856: [native] refactor registration button to be submit button.
Thu, May 2, 8:58 AM
ashoat added a comment to D11856: [native] refactor registration button to be submit button.
  1. I don't think SubmitButton is a great name for this. It's used for actions other than submitting.
  2. I don't think it makes sense to move this component out by itself. It's tightly coupled to the other visual components in the native/account/registration folder, and now it's pretty weird that some of them are in that folder and some are elsewhere.
Thu, May 2, 8:58 AM
will requested review of D11859: [lib] Rename action type to set aux user fids.
Thu, May 2, 8:28 AM
ashoat resigned from D11858: Specify android notification priority based on its visual action.

It looks like @marcin's investigation has shown that ChatGPT is wrong, and he is pursuing a different theory that perhaps Android is punishing us for sending non-visual notifs (rescind and badge-only) with high priority. I think this is a good direction to explore.

Thu, May 2, 8:28 AM
ashoat closed D11849: [native] Prevent user from leaving RegistrationTerms during registration request.
Thu, May 2, 8:16 AM
ashoat closed D11848: [lib][native] Automatically retry keyserverAuth during login/registration.
Thu, May 2, 8:16 AM
ashoat committed rCOMMf2ff6eee2e29: [native] Prevent user from leaving RegistrationTerms during registration request (authored by ashoat).
[native] Prevent user from leaving RegistrationTerms during registration request
Thu, May 2, 8:16 AM
ashoat committed rCOMM6778c6805b7e: [lib][native] Automatically retry keyserverAuth during login/registration (authored by ashoat).
[lib][native] Automatically retry keyserverAuth during login/registration
Thu, May 2, 8:16 AM
ashoat closed D11847: [native] Show "unknown error" alert if keyserver auth fails during registration.
Thu, May 2, 8:15 AM
ashoat committed rCOMMd94e8201ccc7: [native] Show "unknown error" alert if keyserver auth fails during registration (authored by ashoat).
[native] Show "unknown error" alert if keyserver auth fails during registration
Thu, May 2, 8:15 AM
ashoat closed D11846: [lib][native][web] Wait until database deletion before rejecting login/registration attempt.
Thu, May 2, 8:14 AM
ashoat committed rCOMMe27a6dfb78f0: [lib][native][web] Wait until database deletion before rejecting… (authored by ashoat).
[lib][native][web] Wait until database deletion before rejecting…
Thu, May 2, 8:14 AM
ashoat closed D11845: [lib][native] Reset login state if authoritative keyserver fails.
Thu, May 2, 8:14 AM
ashoat committed rCOMM39314e76eb6f: [lib][native] Reset login state if authoritative keyserver fails (authored by ashoat).
[lib][native] Reset login state if authoritative keyserver fails
Thu, May 2, 8:14 AM
ashoat added a comment to D11858: Specify android notification priority based on its visual action.

Oh wait, there are updates on Linear I missed. Let me read them first, sorry for missing that

Thu, May 2, 8:12 AM
ashoat requested changes to D11858: Specify android notification priority based on its visual action.
Thu, May 2, 8:11 AM
ashoat published D11858: Specify android notification priority based on its visual action for review.

I might be missing something, but doesn't the notif have to include android: { priority: 'high' } }? This is what Chat GPT seemed to indicate (transcript linked on Linear)

Thu, May 2, 8:11 AM
varun accepted D11848: [lib][native] Automatically retry keyserverAuth during login/registration.
Thu, May 2, 5:13 AM

Yesterday

ginsu requested review of D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.
Wed, May 1, 11:47 PM
ginsu requested review of D11856: [native] refactor registration button to be submit button.
Wed, May 1, 11:20 PM
ginsu closed D11821: [lib] introduce useDeleteFarcasterChannelTag.
Wed, May 1, 10:52 PM
ginsu committed rCOMMa7783725d1fd: [lib] introduce useDeleteFarcasterChannelTag (authored by ginsu).
[lib] introduce useDeleteFarcasterChannelTag
Wed, May 1, 10:52 PM
ginsu closed D11815: [lib] introduce deleteFarcasterChannelTagActionTypes.
Wed, May 1, 10:52 PM
ginsu closed D11814: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint.
Wed, May 1, 10:52 PM
ginsu committed rCOMMffc0c01586ef: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint (authored by ginsu).
[keyserver/lib] introduce delete_farcaster_channel_tag endpoint
Wed, May 1, 10:52 PM
ginsu committed rCOMMdd631917b6ec: [lib] introduce deleteFarcasterChannelTagActionTypes (authored by ginsu).
[lib] introduce deleteFarcasterChannelTagActionTypes
Wed, May 1, 10:52 PM
ginsu closed D11813: [keyserver] introduce deleteFarcasterChannelTag.
Wed, May 1, 10:51 PM
ginsu committed rCOMMa6d188d1ca79: [keyserver] introduce deleteFarcasterChannelTag (authored by ginsu).
[keyserver] introduce deleteFarcasterChannelTag
Wed, May 1, 10:51 PM
ginsu updated the diff for D11821: [lib] introduce useDeleteFarcasterChannelTag.

rebase before landing

Wed, May 1, 10:46 PM
ginsu added inline comments to D11821: [lib] introduce useDeleteFarcasterChannelTag.
Wed, May 1, 10:46 PM
ginsu updated the diff for D11815: [lib] introduce deleteFarcasterChannelTagActionTypes.

rebase before landing

Wed, May 1, 10:45 PM
ginsu added inline comments to D11815: [lib] introduce deleteFarcasterChannelTagActionTypes.
Wed, May 1, 10:45 PM
ashoat updated the diff for D11848: [lib][native] Automatically retry keyserverAuth during login/registration.

Only retry if we get olm_session_creation_failure. Tested with keyserver patch that returns that error (saw two attempts in logs), and keyserver patch that returns different error (saw only one attempt in logs)

Wed, May 1, 10:43 PM
ginsu updated the diff for D11814: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint.

address comments + rebase before landing

Wed, May 1, 10:42 PM