Active Repositories
- rCOMM Comm
- Thu, May 2, 9:58 AM2024-05-02 09:58:57 (UTC-7)
- Git
Recent Activity
Today
In D11858#339835, @ashoat wrote:It looks like @marcin's investigation has shown that ChatGPT is wrong, and he is pursuing a different theory that perhaps Android is punishing us for sending non-visual notifs (rescind and badge-only) with high priority. I think this is a good direction to explore.
I think ChatGPT was right about setting android: {priority: 'high'} - I just found that this is already handled by firebase-admin. I think that setting priority to high (which we are currently doing) for badge updates and rescinds might be a mistake based on this docs: https://firebase.google.com/docs/cloud-messaging/concept-options#setting-the-priority-of-a-message
address feedback
- I don't think SubmitButton is a great name for this. It's used for actions other than submitting.
- I don't think it makes sense to move this component out by itself. It's tightly coupled to the other visual components in the native/account/registration folder, and now it's pretty weird that some of them are in that folder and some are elsewhere.
It looks like @marcin's investigation has shown that ChatGPT is wrong, and he is pursuing a different theory that perhaps Android is punishing us for sending non-visual notifs (rescind and badge-only) with high priority. I think this is a good direction to explore.
Oh wait, there are updates on Linear I missed. Let me read them first, sorry for missing that
I might be missing something, but doesn't the notif have to include android: { priority: 'high' } }? This is what Chat GPT seemed to indicate (transcript linked on Linear)
Yesterday
rebase before landing
rebase before landing
Only retry if we get olm_session_creation_failure. Tested with keyserver patch that returns that error (saw two attempts in logs), and keyserver patch that returns different error (saw only one attempt in logs)
address comments + rebase before landing