User Details
- User Since
- Jan 24 2022, 7:38 AM (152 w, 12 h)
- Roles
- Disabled
Nov 6 2023
Sep 3 2023
Also, are you going to remove upload_one_time_keys() from unauthenticated client service?
Aug 31 2023
Aug 30 2023
Rebase on top of master
Mostly looks good to me, let someone else review
https://phab.comm.dev/D8966 seems like the right approach. Closing
Aug 29 2023
Aug 27 2023
Make less specific than just identity service
Use debug! for read capacity
Fixed miss rename
Aug 25 2023
Rebase on top of master
Rebase on top of master
Rebase on top of master
Rebase on top of master
Rebase on top of master
Rebase on top of master
Rebase on top of master
Rebase on top of master
Not sure about the specifics of authentication, but the rust looks fine.
rust LGTM, not familiar with reports though, so I would like a second opinion
Aug 23 2023
Fix docker build
Rebase after conflict changes in previous diff
We don't need native as an option here.
To deliberately avoid ambiguity, I explicitly enumerated the full list of device types you should support in two places: Phabricator and Comm ("How to differentiate between different Comm devices" thread under "Services team" channel).
It's already frustrating to me that I have to micromanage to this degree. Ideally I should not have to give you explicit guidance at all, but the fact that guidance is frequently ignored means that I need to review every single one of your diffs.
This is the same problem as in D7691. There is very little that frustrates me more than feeling like the effort I put into careful, thoughtful, explicit communication is wasted and ignored.
- Remove Native
- iOS -> Ios
Add missed changes
Aug 22 2023
Aug 21 2023
Address feedback
Use ConnectionInitializationMessage as message name
Aug 20 2023
When trying to patch this in, it got added to the previous diff. Will add @bartek suggestion to later diff
Emphasize PARTITION_KEY in comment
Address feedback. Correct async/await usage