Page MenuHomePhabricator
Differential D10215

[identity] Implemet attribute conversions for DeviceList row
ClosedPublic
Actions

Authored by bartek on Dec 7 2023, 12:05 AM.
Tags
None
Referenced Files
F2151271: D10215.id35269.diff
Sun, Jun 30, 12:25 PM
Unknown Object (File)
Thu, Jun 27, 1:40 PM
Unknown Object (File)
Wed, Jun 26, 3:33 PM
Unknown Object (File)
Tue, Jun 25, 12:53 PM
Unknown Object (File)
Tue, Jun 25, 12:53 PM
Unknown Object (File)
Tue, Jun 25, 12:53 PM
Unknown Object (File)
Tue, Jun 25, 12:52 PM
Unknown Object (File)
Tue, Jun 25, 12:52 PM
View All 31 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
Commits
rCOMMbffebde31833: [identity] Implemet attribute conversions for DeviceList row
Summary

Same as D10214 but for DeviceListRow

Depends on D10214

Test Plan

Tested later in the stack. TODO: add unit tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Dec 7 2023, 12:05 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 7 2023, 12:05 AM
bartek added a child revision: D10216: identity] Add function to get current device list timestamp.Dec 7 2023, 12:09 AM
Harbormaster failed remote builds in B24843: Diff 34365!Dec 7 2023, 1:02 AM
bartek published this revision for review.Dec 7 2023, 1:05 AM
bartek added inline comments.
services/identity/src/database/device_list.rs
280–287 ↗(On Diff #34365)

Note that we use RFC 3339 string for ItemID while the ATTR_TIMESTAMP uses milliseconds number. Generally I use the former everywhere (simpler parsing without NaiveDateTime conversions) but I thought the latter is easier for DDB to sort by (it's used only as index sorting key and not read anywhere else)

varun accepted this revision.Dec 7 2023, 9:23 PM
This revision is now accepted and ready to land.Dec 7 2023, 9:23 PM
bartek updated this revision to Diff 34500.Dec 11 2023, 11:27 PM

Rebase

Harbormaster completed remote builds in B24962: Diff 34500.Dec 12 2023, 12:09 AM
Closed by commit rCOMMbffebde31833: [identity] Implemet attribute conversions for DeviceList row (authored by bartek). · Explain WhyJan 5 2024, 1:22 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMbffebde31833: [identity] Implemet attribute conversions for DeviceList row.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
113 lines

Diff 35269

View Options

services/identity/src/database/device_list.rs

Loading...