[identity] Add function to retrieve user's devices
ClosedPublic
Actions

Authored by bartek on Dec 7 2023, 12:13 AM.

Details

Reviewers

michal
varun

Commits

rCOMM5bb485784ac3: [identity] Add function to retrieve user's devices

Summary

This function retrieves all Device rows for given user. This is a counterpart of get_keys_for_user function in "legacy" schema.

Depends on D10216

Test Plan

Added a few test rows (with both device- and devicelist- prefixes) to the identity-devices table and verified that the function returns only the device- items.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 7 2023, 12:13 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 7 2023, 12:13 AM

bartek added a child revision: D10218: [identity] Add function to check if device exists.Dec 7 2023, 12:17 AM

bartek published this revision for review.Dec 7 2023, 1:06 AM

Harbormaster failed remote builds in B24845: Diff 34367!Dec 7 2023, 1:29 AM

varun accepted this revision.Dec 8 2023, 12:39 AM

varun added inline comments.

services/identity/src/database/device_list.rs
309 ↗	(On Diff #34367)	maybe i missed it but is there a reason why this isn't a client method? i.e. should this be in an `impl DatabaseClient` block instead?